From nobody Wed Jan 19 17:50:32 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DD82C195D7D2; Wed, 19 Jan 2022 17:50:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JfCpw5Fbzz3j65; Wed, 19 Jan 2022 17:50:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642614632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fATTP6/n87n78478oqvrdhkvSEeOQFbbxA/PQsZFK9U=; b=qMc40glsO6vEXb4S5byAxmj/tFAnyJaVCgI/qPBbb9ApMQV7N7rQcvTaOvuOfYnVet1Dd/ w2dOE5YvM3Xy68n61xiTioOa3GoYxSBPImmlmzzATcE+cGKDiLy4xXpIC3RLiHQNLMBxEf EgFDvLlT2AEebR+Tc5oj8gPpRQVs0uEveiyiwmNMb0AoFEPmkym3QwV12/EpqweFKfwT5B d5FNmaFYmP/wZQ5hZFwkI+yL93WOOGyylEVLDdIYp1IIwKxrNQupG5L1zccPQFNaGcc67+ KKJ/g37ZrwX8ijouNWrcPewf7xBTfhHvLRVYSrxK3UdBvQzie6sIAVgUx2CjRw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8954818D6C; Wed, 19 Jan 2022 17:50:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20JHoWeb085917; Wed, 19 Jan 2022 17:50:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20JHoW0C085916; Wed, 19 Jan 2022 17:50:32 GMT (envelope-from git) Date: Wed, 19 Jan 2022 17:50:32 GMT Message-Id: <202201191750.20JHoW0C085916@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Robert Wing Subject: git: 51fbd894ddad - main - bhyve/snapshot: fix pthread_create() error check List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 51fbd894ddadd6a1bc4cb72de8ac4e92c013bd36 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642614632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fATTP6/n87n78478oqvrdhkvSEeOQFbbxA/PQsZFK9U=; b=TN21peZjUPLnze078foTKDpQXY/5FvL+3xIepmsvO2V32lk8kJFK2hAdfzGK8Wt5+yeFxs k0FF2Jv81VwanITP7pXFtCHiXayCb5Pl3uBA0MdbXj4NpdT0PZcRlr7mhDwHpL9CZYHJCN rjGka/Ru6xQ8S8amqeJwofLNgro53anGUusgkbBG9rJbmJu0A2qFlEyI8WXm4KB7Py2QJl hc824Gr5gh2xZ/wx8GTXgyIg2xMIHzkOQ9ACE7c81ptiPt5S2EQDKMDtmoUny+P1A9wkYF 6B9Lbjfz1YjjATUppRXC41CYLHw8SZV15MEuE2aRker/wqQO0gy8uDVcH0/qXw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642614632; a=rsa-sha256; cv=none; b=g5AuUBsJLe/uZp/K6jaJvwZkcqOj7CO/XJTSl5wyGlsJdh3Sw9h8Ni3At7rH+HD15pBfrJ 8eV/CEj3LWMa31aJn07l4EiRyGDb5evV6jcoA1Y1LSmS46sA/Iz9qFY8IqRGxlLKFyxuhM Jhcg5MBK833mdmD9vaurkAgOpiVg+jWBVC3Inmvl89O6nAtYwzuWJtzAliRgtW5Fq/jT1B WyD6tDZKZRQuhhdLFw/SzKZwr2uU1AjLmAv1NjrY11zaax2bL+NG/BVshHMu2ao5NQr2Wv 1LR7TYSrHXKv8oN8CmlQ7mU532ebM2l63SG0bz73L3Y3+6cOdEDDrI++VoVRYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rew: URL: https://cgit.FreeBSD.org/src/commit/?id=51fbd894ddadd6a1bc4cb72de8ac4e92c013bd36 commit 51fbd894ddadd6a1bc4cb72de8ac4e92c013bd36 Author: Robert Wing AuthorDate: 2022-01-19 17:40:06 +0000 Commit: Robert Wing CommitDate: 2022-01-19 17:40:06 +0000 bhyve/snapshot: fix pthread_create() error check pthread_create() returns 0 on success or an error number on failure. Reviewed by: khng, markj Differential Revision: https://reviews.freebsd.org/D33930 --- usr.sbin/bhyve/snapshot.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/usr.sbin/bhyve/snapshot.c b/usr.sbin/bhyve/snapshot.c index 1a06c3e8d065..4c2cbed2c143 100644 --- a/usr.sbin/bhyve/snapshot.c +++ b/usr.sbin/bhyve/snapshot.c @@ -1520,7 +1520,7 @@ init_checkpoint_thread(struct vmctx *ctx) int socket_fd; pthread_t checkpoint_pthread; char vmname_buf[MAX_VMNAME]; - int ret, err = 0; + int err; memset(&addr, 0, sizeof(addr)); @@ -1555,12 +1555,10 @@ init_checkpoint_thread(struct vmctx *ctx) checkpoint_info->ctx = ctx; checkpoint_info->socket_fd = socket_fd; - ret = pthread_create(&checkpoint_pthread, NULL, checkpoint_thread, + err = pthread_create(&checkpoint_pthread, NULL, checkpoint_thread, checkpoint_info); - if (ret < 0) { - err = ret; + if (err != 0) goto fail; - } return (0); fail: