From nobody Thu Jan 06 07:15:04 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C7484193ACEF; Thu, 6 Jan 2022 07:15:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTyKr3kbbz4c4W; Thu, 6 Jan 2022 07:15:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 2067F4xB089443 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 6 Jan 2022 09:15:07 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 2067F4xB089443 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 2067F4cJ089379; Thu, 6 Jan 2022 09:15:04 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 6 Jan 2022 09:15:04 +0200 From: Konstantin Belousov To: Kyle Evans Cc: src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: 292cba9b4919 - main - rtld: remove mips-specific cases from generic code Message-ID: References: <202201060646.2066kKul064592@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4JTyKr3kbbz4c4W X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, Jan 06, 2022 at 01:00:58AM -0600, Kyle Evans wrote: > On Thu, Jan 6, 2022 at 12:46 AM Konstantin Belousov wrote: > > > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=292cba9b4919ee188ca08cc8bf5057e346514383 > > > > commit 292cba9b4919ee188ca08cc8bf5057e346514383 > > Author: Konstantin Belousov > > AuthorDate: 2022-01-06 00:43:51 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2022-01-06 04:00:39 +0000 > > > > rtld: remove mips-specific cases from generic code > > > > Reviewed by: imp > > Sponsored by: The FreeBSD Foundation > > Differential revision: https://reviews.freebsd.org/D33763 > > --- > > libexec/rtld-elf/rtld.c | 47 ----------------------------------------------- > > libexec/rtld-elf/rtld.h | 6 ------ > > 2 files changed, 53 deletions(-) > > > > diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c > > index fa0e61fe0c5c..14c4d44f50e4 100644 > > --- a/libexec/rtld-elf/rtld.c > > +++ b/libexec/rtld-elf/rtld.c > > @@ -1002,10 +1002,6 @@ rtld_resolve_ifunc(const Obj_Entry *obj, const Elf_Sym *def) > > return ((void *)target); > > } > > > > -/* > > - * NB: MIPS uses a private version of this function (_mips_rtld_bind). > > - * Changes to this function should be applied there as well. > > - */ > > Elf_Addr > > _rtld_bind(Obj_Entry *obj, Elf_Size reloff) > > { > > @@ -1465,19 +1461,6 @@ digest_dynamic1(Obj_Entry *obj, int early, const Elf_Dyn **dyn_rpath, > > obj->fini_array_num = dynp->d_un.d_val / sizeof(Elf_Addr); > > break; > > > > - /* > > - * Don't process DT_DEBUG on MIPS as the dynamic section > > - * is mapped read-only. DT_MIPS_RLD_MAP is used instead. > > - */ > > - > > -#ifndef __mips__ > > - case DT_DEBUG: > > - if (!early) > > - dbg("Filling in DT_DEBUG entry"); > > - (__DECONST(Elf_Dyn *, dynp))->d_un.d_ptr = (Elf_Addr)&r_debug; > > - break; > > -#endif > > - > > case DT_FLAGS: > > if (dynp->d_un.d_val & DF_ORIGIN) > > obj->z_origin = true; > > This one was #ifndef mips and the entire thing was removed, was that > intentional? Woops. Thank you.