From nobody Thu Jan 06 07:00:58 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9736E193810B; Thu, 6 Jan 2022 07:01:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTy1g1mCWz4ZM6; Thu, 6 Jan 2022 07:01:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 1B3626EE0; Thu, 6 Jan 2022 07:01:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f50.google.com with SMTP id o10so1521621qvc.5; Wed, 05 Jan 2022 23:01:11 -0800 (PST) X-Gm-Message-State: AOAM531HHMLMtHLHs1FhgSp7QBpjptNVy98elRgyUh6Al/6qhL9mCa0X zItHnodYJkaJrGqmAe6x10CifVw9+G9d67oNV9Y= X-Google-Smtp-Source: ABdhPJyeW7CXiB1q+8p7oNrL3iapq/uwEmwbqjMqV10LJQLtV5hTaY8AnUmAgeMimgg5QaFjqB7DpxyevFRlh/rc4As= X-Received: by 2002:a05:6214:f6a:: with SMTP id iy10mr51892686qvb.95.1641452470580; Wed, 05 Jan 2022 23:01:10 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202201060646.2066kKul064592@gitrepo.freebsd.org> In-Reply-To: <202201060646.2066kKul064592@gitrepo.freebsd.org> From: Kyle Evans Date: Thu, 6 Jan 2022 01:00:58 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 292cba9b4919 - main - rtld: remove mips-specific cases from generic code To: Konstantin Belousov Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641452471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QkXvc7Vw27kUD5mgWbztf+BseE8UYHCJ/+sBfTz+1tI=; b=iokgj677zu3nuuvN+Ki4TN3vaXJRqsjMVeyQZTdRp4EjOpHhj/jbApu/2nCUH4PYyam8HO L+0lN64D7VyZLPcY39ZOp03s8ZkTBWadsEZypYMC2vWmSfKakAivpI5cR6cBWJNfdisQJd 7wm/XUTCEx3YuQOHMxcwrl9tLiYm+oR2AccR3kF1kT9tB+L2pX1B7k2flg9dnfIkHZvzAV kd1eiKNqSLqCT4USqE3qlJSYRZuZN5DKhAvZZm1aJ18E5OTXpE/Uk76StOhsqxGu1RaJUI HXly6D/EXvIJQbCjrFrN1H6jKdkEXZt/Ag4FSL8jNt3VvZlWS9FiRDzGk3EUnA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641452471; a=rsa-sha256; cv=none; b=wFdpcP7Z0l7tyBH8w6evz/rL3Msx3SZKzkqoRy0G5gdBpIO5+ZUYsyAK/WePMZyKuDSb/u nR+3veqH6fn7wfrd1JkC7iJ1siFT2icw7oNRg5SEi1WwF+Xn0SvwPqOCho02CdaEaS//e0 pa3NoTbryfBL8TcYc+U4NYqtfNn+vy7uKvlZ5kRClDfVAP42tLhIJtC9Gws/VQTqKKYsMA tO0DA9KMdMWYToXWj907MYvpFxnawlG4mAWK+yNRAG1ZIyFcC/zimH64QSUEXHTghA2CLi S+K+hCIkMBu+ZFruAbg1QaapdTpZ9x0IWQPk+xOM/l7nR5921/FgOOV716isQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Thu, Jan 6, 2022 at 12:46 AM Konstantin Belousov wrote: > > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=292cba9b4919ee188ca08cc8bf5057e346514383 > > commit 292cba9b4919ee188ca08cc8bf5057e346514383 > Author: Konstantin Belousov > AuthorDate: 2022-01-06 00:43:51 +0000 > Commit: Konstantin Belousov > CommitDate: 2022-01-06 04:00:39 +0000 > > rtld: remove mips-specific cases from generic code > > Reviewed by: imp > Sponsored by: The FreeBSD Foundation > Differential revision: https://reviews.freebsd.org/D33763 > --- > libexec/rtld-elf/rtld.c | 47 ----------------------------------------------- > libexec/rtld-elf/rtld.h | 6 ------ > 2 files changed, 53 deletions(-) > > diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c > index fa0e61fe0c5c..14c4d44f50e4 100644 > --- a/libexec/rtld-elf/rtld.c > +++ b/libexec/rtld-elf/rtld.c > @@ -1002,10 +1002,6 @@ rtld_resolve_ifunc(const Obj_Entry *obj, const Elf_Sym *def) > return ((void *)target); > } > > -/* > - * NB: MIPS uses a private version of this function (_mips_rtld_bind). > - * Changes to this function should be applied there as well. > - */ > Elf_Addr > _rtld_bind(Obj_Entry *obj, Elf_Size reloff) > { > @@ -1465,19 +1461,6 @@ digest_dynamic1(Obj_Entry *obj, int early, const Elf_Dyn **dyn_rpath, > obj->fini_array_num = dynp->d_un.d_val / sizeof(Elf_Addr); > break; > > - /* > - * Don't process DT_DEBUG on MIPS as the dynamic section > - * is mapped read-only. DT_MIPS_RLD_MAP is used instead. > - */ > - > -#ifndef __mips__ > - case DT_DEBUG: > - if (!early) > - dbg("Filling in DT_DEBUG entry"); > - (__DECONST(Elf_Dyn *, dynp))->d_un.d_ptr = (Elf_Addr)&r_debug; > - break; > -#endif > - > case DT_FLAGS: > if (dynp->d_un.d_val & DF_ORIGIN) > obj->z_origin = true; This one was #ifndef mips and the entire thing was removed, was that intentional?