From nobody Thu Jan 06 00:04:28 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 44B2B1939522; Thu, 6 Jan 2022 00:04:32 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTmmv6j23z4TkM; Thu, 6 Jan 2022 00:04:31 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 20604SZx041478 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 5 Jan 2022 16:04:28 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 20604SQN041477; Wed, 5 Jan 2022 16:04:28 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Wed, 5 Jan 2022 16:04:28 -0800 From: Gleb Smirnoff To: Warner Losh Cc: Alexander Motin , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: ce881170088c - main - atkbd: Disable periodic polling by default. Message-ID: References: <202201052013.205KD3HJ024209@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4JTmmv6j23z4TkM X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, Jan 05, 2022 at 04:18:25PM -0700, Warner Losh wrote: W> On Wed, Jan 5, 2022, 3:47 PM Gleb Smirnoff wrote: W> W> > On Wed, Jan 05, 2022 at 08:13:03PM +0000, Alexander Motin wrote: W> > A> commit ce881170088c4c98c036fe561f8ee8413c2e2585 W> > A> Author: Alexander Motin W> > A> AuthorDate: 2022-01-05 20:00:36 +0000 W> > A> Commit: Alexander Motin W> > A> CommitDate: 2022-01-05 20:12:58 +0000 W> > A> W> > A> atkbd: Disable periodic polling by default. W> > A> W> > A> It is one of the few remaining Giant-locked callouts. It would be W> > A> good to remove it, not mentioning that polling itself is not good. W> > A> W> > A> If this cause keyboard/mouse freezes on some hardware, please set W> > A> loader tunable hw.atkbd.hz=1 as workaround and report the issue. W> > A> W> > A> Submitted by: imp, jhb W> > W> > Lame question: this is related only to a keyboard plugged into PS/2, isn't W> W> Yes. I think this part of the code is only for "legacy" keyboards. I don't W> think mice are affected, but since both attach to the keyboard controller W> there is a tiny chance mice might be affected in some weird hardware... I'd even say to legacy mainboards. Cause I have PS/2 keybooard plugged into USB port and AFAIU it is not affected by this change in any way. I think that even if this change creates some regression, we never know that. Nobody would today run so old mainboard as a desktop. Might have it as a headless appliance. -- Gleb Smirnoff