From nobody Wed Jan 05 21:22:54 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D707E1929131 for ; Wed, 5 Jan 2022 21:23:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTjBd4Gkwz58nQ for ; Wed, 5 Jan 2022 21:23:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x932.google.com with SMTP id v12so819994uar.7 for ; Wed, 05 Jan 2022 13:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HvzQ0yyZhc0VopaT5NRw4UXnCe1APEVl1R6nNMYr3Dc=; b=RGPWQ3uC1TEThYYT5n7ZOTvS3+TdXy8Hw2mKNxiEIzuTLetIfqjz+f5huetZZ6aufS zICP99Mi6uoar0Y+bLYItnbtIAjemD7EmY2l/cc8BgEmdAGS0SCbn79CKAZ9vZrzw2oW Uy7zhiYxJ20XZ+b7U6cYhsa6+Ghm8p6NrCsT1ZfdapwAKqi9ew0pZFgZvWxRhBgxBMAL 5JOKFLPYsOafa0p5ipjtpKo/sn1WsysQSkcKbkz2Xs7zmrrV/Rs20ms8y4SyQkhsgLi5 sxfpS31P2qseEDorGeANAXyfUI44KLyrXxQx4IPjv62OxLjR326Vv9bW6vl0s2/z8hWz MVwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HvzQ0yyZhc0VopaT5NRw4UXnCe1APEVl1R6nNMYr3Dc=; b=ep/iD4K1/gjgyZWOUD4+hfOMq08KBMTuU4kw1Nxt/LSuW3HFi0zqFX6gzMNcCLRCJ6 /sa4pN4RgytUi/NZpENTKKdqJ4tUQqpbmPxATG7grTGmRYHPOUDpFjmJqMwy07XsdNob /w2xcngZ56kBUpp8ZmlWYbL7PV38PfPxeOr459i060QAwODE9lsY58tNnnqvnGgBWKlP sJKU5vRv6+2VyxpbhO85JAiKZaVIu49LhQkK7+TWFKpba1xRvQTUuMS2gmqJMAB4KgL3 z1VDbZEED7AwSW9QHwFpoQyzLFj7dGiHYU8kE8xO+iKw6seZueRfQwAxsLq06QKt1J4S xf+A== X-Gm-Message-State: AOAM533MWohqsgctA5ohQKnnVev5ATNF4YknE9G26CeDLQF3tswNGF0l QRj4sIlGLXTbBgZgrLNx/Cc02CtBCo7RJnOGgyb+nQ== X-Google-Smtp-Source: ABdhPJyqbG5q4RKFvYWgrEbsms50JuUvOAxgjsINiei4QzCLL7rJjtkyshFpjQycEX9ChppM8g3JFIiBJTM6SBvVQ2w= X-Received: by 2002:ab0:13c3:: with SMTP id n3mr16312338uae.39.1641417784879; Wed, 05 Jan 2022 13:23:04 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202112312157.1BVLvLhd040939@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 5 Jan 2022 14:22:54 -0700 Message-ID: Subject: Re: git: 5a73a6c178f6 - main - Add lio back to NOTES To: Ed Maste Cc: Mateusz Guzik , Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ff040105d4dc5b59" X-Rspamd-Queue-Id: 4JTjBd4Gkwz58nQ X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=RGPWQ3uC; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::932) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-0.63 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; NEURAL_SPAM_MEDIUM(0.97)[0.969]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.59)[-0.594]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::932:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org] X-ThisMailContainsUnwantedMimeParts: N --000000000000ff040105d4dc5b59 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022 at 2:09 PM Warner Losh wrote: > > > On Wed, Jan 5, 2022 at 2:06 PM Ed Maste wrote: > >> On Wed, 5 Jan 2022 at 15:47, Warner Losh wrote: >> > >> > NOIP kernels were already broken when I made this commit. I'll take a >> look now that emaste committed fixes for those... >> >> I think w/o INET should have built as of my a6668e31aa3c commit. >> >> I also tried building without both INET and INET6. A number of drivers >> have checksum offload support that calls in_pseudo() (or similar) >> without #ifdef guards, and in_pseduo isn't available in that case. >> After hacking those cases I was able to build without INET and INET6. >> >> Affected drivers: age alc ale bxe fxp jme msk sge sk >> > > Yea, a6668e31aa3c was after my adding lio back. But I'll take a look. > lio just needs to be added to the NOIP exclusion list. Committed a change for that. Sorry for the breakage. Warner --000000000000ff040105d4dc5b59 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jan 5, 2022 at 2:09 PM Warner= Losh <imp@bsdimp.com> wrote:
=


On Wed, Jan 5, 2022 at 2:06 PM Ed Maste <emaste@freebsd.org> wr= ote:
On Wed, 5 J= an 2022 at 15:47, Warner Losh <imp@bsdimp.com> wrote:
>
> NOIP kernels were already broken when I made this commit. I'll tak= e a look now that emaste committed fixes for those...

I think w/o INET should have built as of my a6668e31aa3c commit.

I also tried building without both INET and INET6. A number of drivers
have checksum offload support that calls in_pseudo() (or similar)
without #ifdef guards, and in_pseduo isn't available in that case.
After hacking those cases I was able to build without INET and INET6.

Affected drivers: age alc ale bxe fxp jme msk sge sk
<= br>
Yea,=C2=A0a6668e31aa3c was after my adding lio back. But I= 9;ll take a look.

lio jus= t needs to be added to the NOIP exclusion list. Committed a change for that= . Sorry for the breakage.

Warner=C2=A0
=
--000000000000ff040105d4dc5b59--