Re: git: 5a73a6c178f6 - main - Add lio back to NOTES

From: Mateusz Guzik <mjguzik_at_gmail.com>
Date: Wed, 05 Jan 2022 20:53:40 UTC
On 1/5/22, Warner Losh <imp@bsdimp.com> wrote:
> On Wed, Jan 5, 2022, 1:26 PM Mateusz Guzik <mjguzik@gmail.com> wrote:
>
>> On 12/31/21, Warner Losh <imp@freebsd.org> wrote:
>> > The branch main has been updated by imp:
>> >
>> > URL:
>> >
>> https://cgit.FreeBSD.org/src/commit/?id=5a73a6c178f65b91fe60e52e476a88137e40f0e4
>> >
>> > commit 5a73a6c178f65b91fe60e52e476a88137e40f0e4
>> > Author:     Warner Losh <imp@FreeBSD.org>
>> > AuthorDate: 2021-12-31 21:56:16 +0000
>> > Commit:     Warner Losh <imp@FreeBSD.org>
>> > CommitDate: 2021-12-31 21:56:16 +0000
>> >
>> >     Add lio back to NOTES
>> >
>> >     lio appears to be partially removed from this file. It's a modern
>> > enough
>> >     card, so add it back. It builds everywhere.
>> >
>>
>> This breaks NOIP kernels:
>>
>
> NOIP kernels were already broken when I made this commit. I'll take a look
> now that emaste committed fixes for those...
>

It builds fine without the change.

> Warner
>
> ld: error: undefined symbol: tcp_lro_flush_all
>> >>> referenced by lio_droq.c
>> >>>               lio_droq.o:(lio_droq_process_packets)
>>
>> ld: error: undefined symbol: tcp_lro_rx
>> >>> referenced by lio_core.c
>> >>>               lio_core.o:(lio_push_packet)
>>
>> ld: error: undefined symbol: tcp_lro_init
>> >>> referenced by lio_main.c
>> >>>               lio_main.o:(lio_attach)
>>
>> ld: error: undefined symbol: tcp_lro_free
>> >>> referenced by lio_main.c
>> >>>               lio_main.o:(lio_attach)
>> >>> referenced by lio_main.c
>> >>>               lio_main.o:(lio_destroy_nic_device)
>>
>> >     Sponsored by:           Netflix
>> > ---
>> >  sys/conf/NOTES | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/sys/conf/NOTES b/sys/conf/NOTES
>> > index 65e088cfe7c9..eded586b4491 100644
>> > --- a/sys/conf/NOTES
>> > +++ b/sys/conf/NOTES
>> > @@ -1931,6 +1931,7 @@ envvar          hint.fxp.0.prefer_iomap="0"
>> >  device               gem             # Apple GMAC/Sun ERI/Sun GEM
>> >  device               jme             # JMicron JMC250 Gigabit/JMC260
>> Fast Ethernet
>> >  device               lge             # Level 1 LXT1001 gigabit
>> > Ethernet
>> > +device               lio             # Support for Cavium 23XX
>> > Ethernet
>> adapters
>> >  device               mlxfw           # Mellanox firmware update module
>> >  device               mlx5            # Shared code module between IB
>> and Ethernet
>> >  device               mlx5en          # Mellanox ConnectX-4 and
>> ConnectX-4 LX
>> >
>>
>>
>> --
>> Mateusz Guzik <mjguzik gmail.com>
>>
>


-- 
Mateusz Guzik <mjguzik gmail.com>