From nobody Sun Jan 02 23:01:29 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DBBBD193923D; Sun, 2 Jan 2022 23:01:31 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JRvWb4hn0z3vGr; Sun, 2 Jan 2022 23:01:31 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 202N1TSP028170 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 2 Jan 2022 15:01:29 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 202N1TfB028169; Sun, 2 Jan 2022 15:01:29 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Sun, 2 Jan 2022 15:01:29 -0800 From: Gleb Smirnoff To: Alan Somers Cc: Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: daf481f3d508 - main - rescue: include ping iff at least one of INET & INET6 is enabled Message-ID: References: <202112311818.1BVIIr2P048142@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4JRvWb4hn0z3vGr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sun, Jan 02, 2022 at 10:21:28AM -0700, Alan Somers wrote: A> On Sun, Jan 2, 2022 at 10:17 AM Gleb Smirnoff wrote: A> > A> > On Fri, Dec 31, 2021 at 06:18:53PM +0000, Ed Maste wrote: A> > E> The branch main has been updated by emaste: A> > E> A> > E> URL: https://cgit.FreeBSD.org/src/commit/?id=daf481f3d508e7497b456e8df7db17c90b623ee0 A> > E> A> > E> commit daf481f3d508e7497b456e8df7db17c90b623ee0 A> > E> Author: Ed Maste A> > E> AuthorDate: 2021-12-31 01:11:31 +0000 A> > E> Commit: Ed Maste A> > E> CommitDate: 2021-12-31 18:16:30 +0000 A> > E> A> > E> rescue: include ping iff at least one of INET & INET6 is enabled A> > E> A> > E> Ping does not build (and serves no purpose) if neither is enabled A> > E> (i.e., building WITHOUT_INET and WITHOUT_INET6). A> > E> A> > E> This is equvalent to a4ef9e58bc0c but for rescue/. A> > E> A> > E> PR: 260082 A> > E> Fixes: a4ef9e58bc0c ("sbin: build ping if at least one of...") A> > E> Sponsored by: The FreeBSD Foundation A> > A> > Shouldn't be ping built only with INET and ping6 with INET6? A> > Is there any use of ping on machine that doesn't have IPv4? A> > A> > -- A> > Gleb Smirnoff A> A> In 14.0-CURRENT, ping and ping6 are the same binary. However, parts A> of that binary are conditionally compiled by INET and INET6. Sorry, I missed that. -- Gleb Smirnoff