From nobody Sun Jan 02 18:27:09 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0128319363FE; Sun, 2 Jan 2022 18:27:20 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JRnRC3rgfz4SZ5; Sun, 2 Jan 2022 18:27:19 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:80aa:559d:dcf5:ece7]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id EE09E721BE019; Sun, 2 Jan 2022 19:27:09 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: git: daf481f3d508 - main - rescue: include ping iff at least one of INET & INET6 is enabled From: Michael Tuexen In-Reply-To: <50E91562-8850-43CD-AF44-34A96085EF41@freebsd.org> Date: Sun, 2 Jan 2022 19:27:09 +0100 Cc: Gleb Smirnoff , Ed Maste , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202112311818.1BVIIr2P048142@gitrepo.freebsd.org> <50E91562-8850-43CD-AF44-34A96085EF41@freebsd.org> To: Jessica Clarke X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4JRnRC3rgfz4SZ5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N > On 2. Jan 2022, at 18:22, Jessica Clarke wrote: >=20 > On 2 Jan 2022, at 17:17, Gleb Smirnoff wrote: >>=20 >> On Fri, Dec 31, 2021 at 06:18:53PM +0000, Ed Maste wrote: >> E> The branch main has been updated by emaste: >> E>=20 >> E> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Ddaf481f3d508e7497b456e8df7db17c9= 0b623ee0 >> E>=20 >> E> commit daf481f3d508e7497b456e8df7db17c90b623ee0 >> E> Author: Ed Maste >> E> AuthorDate: 2021-12-31 01:11:31 +0000 >> E> Commit: Ed Maste >> E> CommitDate: 2021-12-31 18:16:30 +0000 >> E>=20 >> E> rescue: include ping iff at least one of INET & INET6 is = enabled >> E> =20 >> E> Ping does not build (and serves no purpose) if neither is = enabled >> E> (i.e., building WITHOUT_INET and WITHOUT_INET6). >> E> =20 >> E> This is equvalent to a4ef9e58bc0c but for rescue/. >> E> =20 >> E> PR: 260082 >> E> Fixes: a4ef9e58bc0c ("sbin: build ping if at least = one of...") >> E> Sponsored by: The FreeBSD Foundation >>=20 >> Shouldn't be ping built only with INET and ping6 with INET6? >> Is there any use of ping on machine that doesn't have IPv4? >=20 > ping does both these days: >=20 > commit 0b1064b00fa3ed9c6ac31e2af1fc56c528d7b47d > Author: asomers > Date: Thu Nov 26 04:29:30 2020 +0000 >=20 > Merge ping6 to ping >=20 > There is now a single ping binary, which chooses to use ICMP or = ICMPv4 > based on the -4 and -6 options, and the format of the address. >=20 > Submitted by: J=C3=A1n Su=C4=8Dan > Sponsored by: Google LLC (Google Summer of Code 2019) > MFC after: Never > Differential Revision: https://reviews.freebsd.org/D21377 What I find surprising is that using now ping some-host-which-is-ipv6-capable uses IPv6 instead of IPv4. So if you want the functionality of the old = ping, you have to use ping -4 now... Best regards Michael >=20 > Jess >=20