From nobody Mon Feb 21 21:57:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C079019EB299; Mon, 21 Feb 2022 21:57:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K2bl93mxLz4gkr; Mon, 21 Feb 2022 21:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645480677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DwL2r32pniDTFGiLnnGuK8dqc5qhR1xcHIj7eUu0HUk=; b=GyluYQy2TIR0VpxMQRj8hb9BVeE9G9fS6HEj1YHsEFxm0cALucD1HKLXzBvEFo7ZjRY+dD ladaA15deYIEPEZOM4PY717Ba/f/KmMwdFbIxTcAxeUEWFBI6701as6j2GNtVbG4g/DScQ 3+bPZ6NFIVYnMAO5HPhYY6Fx9wJhC6D77kO443+/kC3aPWm65kI4zHTrDW7L9g2IASQBIF 5lRaOQHlY+rp1Us1IIP4rWhoNvfQM7LO0bRv02neQx9L3lDPCPY+WaHvxykSVmvOLogtlV yBp3mAvOs1jmMBDFSkKD+lkuVmDNYC5JXo15c/dj8uZcPASTSYKbcOSaLc6noA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B487F180AA; Mon, 21 Feb 2022 21:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21LLvuwL052112; Mon, 21 Feb 2022 21:57:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21LLvur1052111; Mon, 21 Feb 2022 21:57:56 GMT (envelope-from git) Date: Mon, 21 Feb 2022 21:57:56 GMT Message-Id: <202202212157.21LLvur1052111@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Chuck Tuffli Subject: git: d4941306264f - stable/13 - bhyve nvme: Remove redundant AER Limit checks List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: chuck X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d4941306264f2edd12bb2034b7445f47bdd72f37 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645480677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DwL2r32pniDTFGiLnnGuK8dqc5qhR1xcHIj7eUu0HUk=; b=cOqI+zjNif6GQ8aGtbWZ5GwNPqLdYiFu2sQHRglL3b/7PDh2lvdHgXoHQWTjFQVGOYYAye Djh8EPH88e3yZMytReBmq5uxPJDlW9myoMebUFWRfEKZ1CY8Rd9atqTpGuaEPRlhQnZVG5 1L+6DpQBAFRPsmUv0p0yzHO7eP8DUEMoxNRrLbg87zJY55V+Prm3FeJPVqA+YgvxpQQTZu D0qGSqYxwEnIcdDGvmRsvVCpqEsqIQXQBeZStsqfnDHN0IyEy+hpakupUZHOdoxC+ac+XI mpd1BXE3Ke8SEYPe69A7PNuM5Z8aBLo63UsggX+oGLwSd8Hv9IbI1qP8LLrU1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645480677; a=rsa-sha256; cv=none; b=cwWG2A/JNWHBdh9fadkmU3niw+T99TYIf2//7TyoewN+HSP0Q632EoI/9pJbw2rmD06huD zg086F9Bqh84kjZ5/wWAmZnGFY7TgThq4Gz5gZQSwJU1vxTpufiVNtWZ9QV9N65W7VuwgK HxPUqtsaS0bfR37LF7CGh2LItD4Z9cf+Jrsehwh2uQTo9VQt7mC/qcBQzl1/X/n3iFyTrU HDcEXoqCvFd0dtWVGmBxUK1yg0jd6iMR1VsEkTnU/tXhZl+H9Ba7GhKj60+2u8O8VE8TxW fvGnA32tyr2D5H/xv/3Sx+MopPxtD2RSs+MUnCLHcRV45Ak2gY++Sk4ZBlwrEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by chuck: URL: https://cgit.FreeBSD.org/src/commit/?id=d4941306264f2edd12bb2034b7445f47bdd72f37 commit d4941306264f2edd12bb2034b7445f47bdd72f37 Author: Chuck Tuffli AuthorDate: 2022-01-30 07:07:29 +0000 Commit: Chuck Tuffli CommitDate: 2022-02-22 03:26:18 +0000 bhyve nvme: Remove redundant AER Limit checks The NVMe emulation checked if the Asynchronous Event Request Limit (a.k.a AERL) would be exceeded in pci_nvme_aer_add(), but this function is only called from nvme_opc_async_event_req() which also checks for exceeding the AERL. (cherry picked from commit 45ab4076f36b428595ba1ce200515fda6af58a76) --- usr.sbin/bhyve/pci_nvme.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 71abfa17deae..682f7561329c 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -744,9 +744,6 @@ pci_nvme_aer_add(struct pci_nvme_softc *sc, uint16_t cid) { struct pci_nvme_aer *aer = NULL; - if (pci_nvme_aer_limit_reached(sc)) - return (-1); - aer = calloc(1, sizeof(struct pci_nvme_aer)); if (aer == NULL) return (-1);