From nobody Mon Feb 21 07:02:53 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0FD5719E43D6; Mon, 21 Feb 2022 07:03:02 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K2CtX6CwZz3QVJ; Mon, 21 Feb 2022 07:03:00 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-ej1-x62f.google.com with SMTP id d10so30609692eje.10; Sun, 20 Feb 2022 23:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:in-reply-to :content-transfer-encoding; bh=GjlR6DTyfHaMPzoCv3/Wuvgiqd7maVg3HjGqdCrpXsA=; b=C7vQIrMTQGCYCczD+xvX6Y8s00KF0V+YN/m4ZOE/zpghexmG9vMiGeugOih/X16QN9 Csh0RqSAuEMWKS0kdoSA0zlUvWESnKkRJMv1RW+qhaIEK7o0YfvLkGKDYXEz7Tv0dmre ui/vIDzJbadSfP//InH3t6Xv7CiyLDioCZHyMTxqjt4/Ir/82o+ETcXBwwhoDgyap7Rc SMc/3M4uiZS4pnTxhY9CaJBdE3Rm/uZ16JxOOwykdM8YON581VocKGEyXvwA0CH5pIlc A+gpbD9Fdaj1L2IFGIGurcwis71JUMwumID1lB5ghGptV1E9RPeAyONxcmRdt+UIy4th NBfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:message-id:date:mime-version :user-agent:reply-to:subject:content-language:to:references :in-reply-to:content-transfer-encoding; bh=GjlR6DTyfHaMPzoCv3/Wuvgiqd7maVg3HjGqdCrpXsA=; b=c4yXo5BGXaMXbHwKDOpgQUJl235jRvWZy6ep3NEiR5MA8I0dlXS2C3Q7Srgp5qrqyy gLCcTCVd0LThYcZfji/ZC8qAq1hPQ7kRAGkJyMIxvTdIq/5NeUBJ07SVS5ll9hZNdYg6 E4i6ngfCOLbJkLovNZOtvzbDbXFHGPTrk3AidlvSo5GwtfIZE7nbtkqiWQ+OzJ1gWBem tgY/QpMVjCaCtfQaYaouwcoZPwsL/797pzhFQNV53QJ6+p6/iPta2Ct7FRsgPn2dEm7c tP3f2p02ilK+vQIpKEzrfL9hWOqmHS53BF24tCkf8uNm3Nr/0iFFTvWy3mhtPJmtzNIn t1GA== X-Gm-Message-State: AOAM531gd4izXqk7qfvrDPEbKVOdYDl0eoDxZU9M9uGcZ9oDPYLlx9ES RaVODqFJx/fbikxoXroFb7uWGu8A/gE= X-Google-Smtp-Source: ABdhPJyhdxNWGc2OMgaQUGxOhJl9dOHLm3WyAoV5T4Pujj6O8UB8+fOuMIjc3AdQdkmB/j7uhSl0nA== X-Received: by 2002:a17:907:9691:b0:6d1:711d:9050 with SMTP id hd17-20020a170907969100b006d1711d9050mr3443822ejc.755.1645426973552; Sun, 20 Feb 2022 23:02:53 -0800 (PST) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id j3sm4840227ejj.9.2022.02.20.23.02.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Feb 2022 23:02:53 -0800 (PST) From: Michal Meloun X-Google-Original-From: Michal Meloun Message-ID: Date: Mon, 21 Feb 2022 08:02:53 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Reply-To: mmel@freebsd.org Subject: Re: 1bd3e8ba6966 - main - ofw_iicbus: Add method for manual setting of basic OFW parameters. Content-Language: en-US To: Ravi Pokala , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202202201139.21KBd1qc072900@gitrepo.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4K2CtX6CwZz3QVJ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=C7vQIrMT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of melounmichal@gmail.com designates 2a00:1450:4864:20::62f as permitted sender) smtp.mailfrom=melounmichal@gmail.com X-Spamd-Result: default: False [-2.98 / 15.00]; HAS_REPLYTO(0.00)[mmel@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.98)[-0.977]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; MID_RHS_MATCH_TO(1.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62f:from]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 20.02.2022 20:14, Ravi Pokala wrote: > -----Original Message----- > From: on behalf of Michal Meloun > Date: 2022-02-20, Sunday at 03:39 > To: , , > Subject: git: 1bd3e8ba6966 - main - ofw_iicbus: Add method for manual setting of basic OFW parameters. > > The branch main has been updated by mmel: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1bd3e8ba696633ccd7525030d951b58ade167814 > > commit 1bd3e8ba696633ccd7525030d951b58ade167814 > Author: Michal Meloun > AuthorDate: 2022-02-20 09:45:14 +0000 > Commit: Michal Meloun > CommitDate: 2022-02-20 11:25:58 +0000 > > ofw_iicbus: Add method for manual setting of basic OFW parameters. > > Some IIC multifunction devices may have multiple I2C addresses per chip, but > only the primary address is listed in the DT (e.g. MAX776200). In this case, > the sub-devices for the secondary addresses must be created manually with > fixed OFW parameters (node, name, compatibility string, IIC address). > Add a bus method to the ofw_iicbus interface that does this. > > Hi Michal, > > This change seems to have broken the arm/ZEDBOARD kernel build: > > ================================================================ > [threepio:~/freebsd/src/clean-main] rpokala% less _.arm.ZEDBOARD > ... >>>> stage 3.1: building everything > -------------------------------------------------------------- > /usr/home/rpokala/freebsd/src/clean-main/sys/dev/fdc/fdc.c:1890:6: warning: variable 'unit' set but not used [-Wunused-but-set-variable] > int unit; > ^ > 1 warning generated. > /usr/home/rpokala/freebsd/src/clean-main/sys/dev/iicbus/ofw_iicbus.c:45:10: fatal error: 'ofw_iicbus_if.h' file not found > #include "ofw_iicbus_if.h" > ^~~~~~~~~~~~~~~~~ > 1 error generated. > --- ofw_iicbus.o --- > *** [ofw_iicbus.o] Error code 1 > > make[8]: stopped in /usr/home/rpokala/freebsd/src/clean-main/sys/modules/i2c/iicbus > ================================================================ > > Thanks, > > Ravi (rpokala@) Hi Ravi, Unfortunately I cannot reproduce this problem, the ZEDBOARD kernel (and all other arm kernels) compiles fine for me. Did you use any special option when compiling? Isn't there a previous error in your log for ZEDBOARD kernel? Michal