From nobody Sat Feb 05 15:17:13 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 93B19198A103; Sat, 5 Feb 2022 15:17:21 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JrbcJ5JJ2z4fjK; Sat, 5 Feb 2022 15:17:20 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 215FHDsO084528 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 5 Feb 2022 07:17:13 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 215FHDmr084527; Sat, 5 Feb 2022 07:17:13 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Sat, 5 Feb 2022 07:17:13 -0800 From: Gleb Smirnoff To: Richard Scheffenegger Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0c424c90eaa6 - main - tcp: move ECN handling code to a common file Message-ID: References: <202202050015.2150FeFE041456@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202202050015.2150FeFE041456@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4JrbcJ5JJ2z4fjK X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org X-Spamd-Result: default: False [-0.73 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[glebius]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; NEURAL_HAM_MEDIUM(-0.86)[-0.865]; NEURAL_HAM_SHORT(-0.67)[-0.670]; NEURAL_SPAM_LONG(0.90)[0.902]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Richard, On Sat, Feb 05, 2022 at 12:15:40AM +0000, Richard Scheffenegger wrote: R> The branch main has been updated by rscheff: R> R> URL: https://cgit.FreeBSD.org/src/commit/?id=0c424c90eaa6602e07bca7836b1d178b91f2a88a R> R> commit 0c424c90eaa6602e07bca7836b1d178b91f2a88a R> Author: Richard Scheffenegger R> AuthorDate: 2022-02-04 21:25:03 +0000 R> Commit: Richard Scheffenegger R> CommitDate: 2022-02-04 21:54:41 +0000 R> R> tcp: move ECN handling code to a common file R> R> Reduce the burden to maintain correct and R> extensible ECN related code across multiple R> stacks and codepaths. R> R> Formally no functional change. R> R> Incidentially this establishes correct R> ECN operation in one instance. I'm sorry - didn't notice it in the phab review. :( There is no reason to use KMOD_TCPSTAT_INC() in the tcp_ecn.c. Now it is a file statically compiled into kernel, unlike RACK or BBR. It should use just TCPSTAT_INC(). -- Gleb Smirnoff