From nobody Wed Dec 14 19:43:48 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NXQlm6rDKz4kPwF; Wed, 14 Dec 2022 19:43:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NXQlm626pz3xX0; Wed, 14 Dec 2022 19:43:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671047028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kh2Mj+E8Xbq94H5RxXwsmV9wDCrSd2WO5y8UO5ysWMw=; b=LLUqAOXsDJF3YQq5ec47WydlVVDzl2T9oUlytOfiAGVO77UYcxc+jAgU68rsm9uryxb8MB wzARG3rlUFSuQwTkGcefJiIWDm+cNBwznnrZJnQsD4nkN9wQyT9rD3Y7E591nwuNVAEukS aP8J5aqTPVPeMH3kFR5umxHlCDMyHcjuRr+z0RUAhj/L0uV5YrajBYGN1NWZQYSPYjLeKT VQ8lp0j74SUw9I78HqPexXWnHharigZMOiSlmSW9H3HSHpQnjamoBqxHeNxUu+mErTmT0h 5WMcLtS4GxYmKAmmhxACOyMG+5I22EfQjPU/G98QTQW4Ydo2VNX6OCKUu3FQNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671047028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kh2Mj+E8Xbq94H5RxXwsmV9wDCrSd2WO5y8UO5ysWMw=; b=TG2r7StBBLZO+I5stZ75OHf+/K/WGbQ1ZegBEXFJ1nRB3fv0XA8acvBG5rI5/K0LlF3jv3 9yW4Dqbl2aXkTU6osAlZiNB4l+PtBugbGNxRu+U/x2oeozcRi/uBHVT2GB094jadjsMF8c mZZQoqOjKn6llU4jX2anJ8SUJHIbF/6BJS97qd1uCbhuL9r4hKHaVid9JYoJprXA/qVMt7 VKicxn+1JhzrBhzwep3d/J7g0ngMz+IIkrlk6LsTfk93Hpbo9GgJFGwuPzzgv2zdkv5CkB TyiD6IjFfId/aMUpV5s2FLyRpBhrJ9l2uiAL/hZ43xY3OyEZVo46QX6rWyGsGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671047028; a=rsa-sha256; cv=none; b=GERtk+mrloKHpIhIV3eTzgtrF8xlyewbMFOWNDQbvhKG+C7vpC3yUKOKV7AvZTZ8KedU13 n0w2Y/QiyQzWQGynkHnr3RoZ0yzAuaJVKR9rGkMKygeOHkPxIxTUcZ29EJ2v/iDdXfWhmA 4HibIjpU8BmF1T7EYCM+wh5NtpUGr1LJUzDa+miCDtJ1vLgP7fZiM4dTR/cwfQ7NZesagX XLC2rAkKtB+aMm1MnjyEWa2ITvLui+ZMW3NwDA+DJonIyB4dosLahTYcRdPz8/qckb4Ild 88fEN/JcSjaSkSHwy51xag2U2T99TFqFCGYavdVAIq6MG4819oHgtv+mkKL/iA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NXQlm53pVz1551; Wed, 14 Dec 2022 19:43:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BEJhm7i035624; Wed, 14 Dec 2022 19:43:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BEJhmNY035623; Wed, 14 Dec 2022 19:43:48 GMT (envelope-from git) Date: Wed, 14 Dec 2022 19:43:48 GMT Message-Id: <202212141943.2BEJhmNY035623@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: c4a4b2633d97 - main - allocate inpcb aligned to cachelines List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c4a4b2633d975bd0813afca6b8e23ead29d80e82 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=c4a4b2633d975bd0813afca6b8e23ead29d80e82 commit c4a4b2633d975bd0813afca6b8e23ead29d80e82 Author: Andrew Gallatin AuthorDate: 2022-12-14 19:19:35 +0000 Commit: Andrew Gallatin CommitDate: 2022-12-14 19:19:35 +0000 allocate inpcb aligned to cachelines The inpcb struct is one of the most heavily utilized in the kernel on a busy network server. By aligning it to a cacheline boundary, we can ensure that closely related fields in the inpcb and tcbcb can be predictably located on the same cacheline. rrs has already done a lot of this work to put related fields on the same line for the tcbcb. In combination with a forthcoming patch to align the start of the tcpcb, we see a roughly 3% reduction in CPU use on a busy web server serving traffic over roughly 50,000 TCP connections. Reviewed by: glebius, markj, tuexen Differential Revision: https://reviews.freebsd.org/D37687 Sponsored by: Netflix --- sys/netinet/in_pcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index 3a83682b711f..e7f425f8593a 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -552,7 +552,7 @@ in_pcbstorage_init(void *arg) pcbstor->ips_zone = uma_zcreate(pcbstor->ips_zone_name, pcbstor->ips_size, NULL, inpcb_dtor, pcbstor->ips_pcbinit, - inpcb_fini, UMA_ALIGN_PTR, UMA_ZONE_SMR); + inpcb_fini, UMA_ALIGN_CACHE, UMA_ZONE_SMR); pcbstor->ips_portzone = uma_zcreate(pcbstor->ips_portzone_name, sizeof(struct inpcbport), NULL, NULL, NULL, NULL, UMA_ALIGN_PTR, 0); uma_zone_set_smr(pcbstor->ips_portzone,