From nobody Fri Dec 09 14:58:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NTDgN54XYz4jVSR; Fri, 9 Dec 2022 14:58:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NTDgN4bd5z4Db7; Fri, 9 Dec 2022 14:58:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670597936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dZ86SXfjsXvMRwE3mFT5BuQ0LZtXpEJtLqajUBBegPo=; b=Onl/8TTNJ0eVT2JRezFUmTMUak1WzSOJ0e3h+du4d1JeqZ0W5WE+LsYnreLoRe0na7Meag kEV0E0U3KhHsXS+pZA3A+8O8JOcUoOYHQBZ6f1unjpSybnkYRO7mskgqPdj886plrhjhw3 wrsddybY2kfd+xN2zMGyXMdyOwVnPiW4VbgD8aAVN8y/wMfKZILgI+0qLhLL8kwpQg2+pz 8CJ4tCPFayMbS2KoxRv8LPPzc2SeqmwSOrqTH4XARs7h9TQBpCrXDUU1A86hhLMw5cczoH A2UvZF4DwVIEuoDXN+Gi1LKQpQSNZzX/nWnudvS9EoIFIBvaO1pLfX9McjkA4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670597936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dZ86SXfjsXvMRwE3mFT5BuQ0LZtXpEJtLqajUBBegPo=; b=rkAHZABp6cr/VLjtH/KWbs4fA33RBgQa12aRePH9itwZnv/ZOmQLcx+LIJLIzRB/ikoCJN IiYBLvesZjRWXLSTFdx53zySfFEgcqpzA99JDjUMldjzLoQqnVv20BkVnLjrzaJWRMdmGz 9w19QOvquund72k7ItSGotsxwD0bwWfXSuLkhs/KXXIHK55UrlakqfYJJ9HeUkzGemK0ua MoPkJ8kdCCEVbd85ia9ow88A9xxlRiuNV3QnDDCmyeaYTcw1UFAYj6xCkfeI/ITUk+7gI/ oJiwzg/uU0rE993OYnyXQF1T1BNjD+4IIpTOkSr5qL+DKLzjHgMUu+5O/9kJSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670597936; a=rsa-sha256; cv=none; b=MKIvQ9u6KTZZC6cfQXEQIrQrwVcr4OJ/mbr5ynCeCFu8vfEGYvy4S/0Qy0QN+ZP6+JmAgb AjqvlUELpbalo/Pb4B6UvhCZI7BwVV06CplDvYJlIDckoHdKgIsicOKSpdUwJbQiFVpRwD lt5NEDI810be9xioeOAEKrhjJUiAyecrXTre29kLdII3SUTxTam/xm31iFmRn3eEyFnpZQ EDcAI68v2T4dYtOPuam0cbOzmqVcxlAGxE1vgJOIiL6khlP/Aj6VTXBeRRg/ZCkIlPhjtE ouOTojh6WqG1xFs7Ltc/ThrimV2lC0fVe/w1oGjFBJ7zXQx2+e0IIobXuU/mjA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NTDgN3fpZzg7P; Fri, 9 Dec 2022 14:58:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2B9EwuEU015434; Fri, 9 Dec 2022 14:58:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2B9EwunY015433; Fri, 9 Dec 2022 14:58:56 GMT (envelope-from git) Date: Fri, 9 Dec 2022 14:58:56 GMT Message-Id: <202212091458.2B9EwunY015433@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: e830a6cbbe8e - main - kboot: Use (void) instead of () for functiosn with no args List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e830a6cbbe8e7ab359e871b0ba95b9b025c0ffcc Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=e830a6cbbe8e7ab359e871b0ba95b9b025c0ffcc commit e830a6cbbe8e7ab359e871b0ba95b9b025c0ffcc Author: Warner Losh AuthorDate: 2022-12-09 14:55:42 +0000 Commit: Warner Losh CommitDate: 2022-12-09 14:57:50 +0000 kboot: Use (void) instead of () for functiosn with no args `int foo();` means 'a function that takes any number of arguments.` not `a function that takes no arguemnts`, that's spelled `int foo(void);` Adopt the latter. Sponsored by: Netflix --- stand/kboot/hostcons.c | 8 ++++---- stand/kboot/main.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/stand/kboot/hostcons.c b/stand/kboot/hostcons.c index 80d4a1c4319b..9ff536279a73 100644 --- a/stand/kboot/hostcons.c +++ b/stand/kboot/hostcons.c @@ -34,8 +34,8 @@ __FBSDID("$FreeBSD$"); static void hostcons_probe(struct console *cp); static int hostcons_init(int arg); static void hostcons_putchar(int c); -static int hostcons_getchar(); -static int hostcons_poll(); +static int hostcons_getchar(void); +static int hostcons_poll(void); struct console hostconsole = { "host", @@ -79,7 +79,7 @@ hostcons_putchar(int c) } static int -hostcons_getchar() +hostcons_getchar(void) { uint8_t ch; int rv; @@ -91,7 +91,7 @@ hostcons_getchar() } static int -hostcons_poll() +hostcons_poll(void) { struct host_timeval tv = {0,0}; long fds = 1 << 0; diff --git a/stand/kboot/main.c b/stand/kboot/main.c index 88657d908b34..85453db50fa5 100644 --- a/stand/kboot/main.c +++ b/stand/kboot/main.c @@ -125,7 +125,7 @@ kboot_rsdp_from_efi(void) } static void -find_acpi() +find_acpi(void) { rsdp = kboot_rsdp_from_efi(); #if 0 /* maybe for amd64 */ @@ -135,13 +135,13 @@ find_acpi() } vm_offset_t -acpi_rsdp() +acpi_rsdp(void) { return (rsdp); } bool -has_acpi() +has_acpi(void) { return rsdp != 0; }