From nobody Tue Dec 06 16:38:39 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NRR1q6ZfKz4jLMG; Tue, 6 Dec 2022 16:38:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NRR1q61gLz47tZ; Tue, 6 Dec 2022 16:38:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670344719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0OVmHBPg2m0sY8BKBsxWEjitEk/Y56Ox6W/gxd+YENQ=; b=wSS0/QsQzia6jJy0TpFB+9QfqhT1NP0GVixWl1JtJNvYdGyMwsR/6Lslyt/1goZXmkZSFn 03LjEBBHo1PfIHEi98XS0a1Ak4eX930TQMtrwsVAGY7YQ9i/kk4DDKn2RKTWQVwikP2G2i BZOM5bVTTEQFxj4RPmWlZGKNqoz2qoNkUBvCAbuqEGqtORkI3KQUPOQ7j5KLYbtIYSzFcG aNHb379qYT6CK2AT3HvwQJ+zWETSSmm+APCUUH/SGxRABeJPRViNMC19jZtmhmt+zIHSN6 AU4uILWYFjDHcvplMchKrCyU8wIspzbHj235T18IKimjbEFmmHtNIjT77nTtNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670344719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0OVmHBPg2m0sY8BKBsxWEjitEk/Y56Ox6W/gxd+YENQ=; b=SH0KhyaSP2hNktA7UsFjfyU5FDFJkvnpY6RgkYEys2finAziALAATOe37CNeDmFsb1Yx17 AD1PAUIGDMkOn5oQaJa70eZxJ5Tm19JjYoJeVrDIuHdjFazlT0dCx5qlzNQ13J46m0hoAW yzrlZi9FBxEeD9NPm7jUYhlInT7jKoIiz4aVyaUgvb/WegaElgu5VRpKzt1YIdul1rhdMp CEzjWOPwhGgPwqrIpyQkrMnhPVdM2WKjSgZIXzwg1OehYrcCU6KsLkAeUsk/WNunWttz1Q K+n42+/4y7rjfmoGfo1pGsLp4ZkxJywtpgVK1cc//wL6CLFe4u+1h1H3DibFlQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670344719; a=rsa-sha256; cv=none; b=bPD6qJNBD7pPjWkAVLe63bvJ4NcxZW6Opbnk/oL5KLLHzdMnvoWjnmFFsSxpDDozaI1aac 9fl7HXhNBHhPcQkgKp7lbGaUTEKB7pmayL0T0XHCZjD7Sp9Oka0TeOq5NP5W1cgOHjqbql ku5MVZ+Nc8v30OdnNHd02AL3u89X/cxp5RV7lPizhwJnIavsIGXmCrhYKwGGg47ZGzh9l2 /s47Cs3jUyNJYWv6QckS23T1xv8xyJ1AWLpCd3mKQudhulo+T5b6rjPQJZQNxyZSZq/Nm+ Nt2yVqWCz8Tc4Wp9LRVvJbxf1E9bM36U1k0/OsBWzFewvsBESxjC4X2Bwfuhvg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NRR1q4yGGzkr7; Tue, 6 Dec 2022 16:38:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2B6GcdeP091467; Tue, 6 Dec 2022 16:38:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2B6GcddP091465; Tue, 6 Dec 2022 16:38:39 GMT (envelope-from git) Date: Tue, 6 Dec 2022 16:38:39 GMT Message-Id: <202212061638.2B6GcddP091465@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 17859d538c23 - main - ixl: silence runtime warning when PCI_IOV is not enabled List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 17859d538c23d6faa5a5512262d678377130e591 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=17859d538c23d6faa5a5512262d678377130e591 commit 17859d538c23d6faa5a5512262d678377130e591 Author: Andrew Gallatin AuthorDate: 2022-12-06 16:35:18 +0000 Commit: Andrew Gallatin CommitDate: 2022-12-06 16:35:18 +0000 ixl: silence runtime warning when PCI_IOV is not enabled When PCI_IOV is not enabled, do not attempt to call iflib_softirq_alloc_generic(...IFLIB_INTR_IOV), as it results in boot-time warnings similar to: taskqgroup_attach_cpu: qid not found for iov cpu=2 ixl2: taskqgroup_attach_cpu failed 22 Instead, make it conditional on PCI_IOV like the other SR-IOV related code. Reviewed by: erj Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D37609 --- sys/dev/ixl/if_ixl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/ixl/if_ixl.c b/sys/dev/ixl/if_ixl.c index cb3ce72a95ed..352a35d95512 100644 --- a/sys/dev/ixl/if_ixl.c +++ b/sys/dev/ixl/if_ixl.c @@ -1064,8 +1064,11 @@ ixl_if_msix_intr_assign(if_ctx_t ctx, int msix) "Failed to register Admin Que handler"); return (err); } + +#ifdef PCI_IOV /* Create soft IRQ for handling VFLRs */ iflib_softirq_alloc_generic(ctx, NULL, IFLIB_INTR_IOV, pf, 0, "iov"); +#endif /* Now set up the stations */ for (i = 0, vector = 1; i < vsi->shared->isc_nrxqsets; i++, vector++, rx_que++) {