From nobody Sun Aug 28 21:25:40 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MG6784bHmz4ZPtY; Sun, 28 Aug 2022 21:25:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MG678412Nz3s6D; Sun, 28 Aug 2022 21:25:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661721940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IqidH0BXwPDw9/lV8uDPjK+0l87O3LeBTb9FS+1B/n4=; b=Up/E2SNlzWNkpIRtcAeJc4At0erHQuc0/ESYDuFkJq8j427IJNwgc8Boosc5RddY3iPGY2 hnptiVwi2rkqzvMf3FXYbA8Z3Gu0jPkVBFhsOX4wFX9M0+Wpv1CT5YZFEYqyUSTbVOxewS AW7S7uVA+vxVtkYiCq2kIfcHr0VT6O75LHFZGHqqB3oadOih9pDTfOnJY8ufWqNmn5tm7s WevCCyHZ/SOYkFIgkyzh6/tL+Bz3jkcSpOC9eqmhb3qyPsojfItkYFU/V7JE0fcODq+uJn XX/wiNKap54dWM4azTCVxyhEpex0vC3pvcSZ8u30lVAwaNwsGUx8lUX1vROXIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MG67831yMz1CQV; Sun, 28 Aug 2022 21:25:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27SLPemQ046105; Sun, 28 Aug 2022 21:25:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27SLPe3A046104; Sun, 28 Aug 2022 21:25:40 GMT (envelope-from git) Date: Sun, 28 Aug 2022 21:25:40 GMT Message-Id: <202208282125.27SLPe3A046104@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 0685c73cfe88 - main - nfscl: Add a console message for session recovery List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0685c73cfe88b94d60b1b2ddfdb36c684a008006 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661721940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IqidH0BXwPDw9/lV8uDPjK+0l87O3LeBTb9FS+1B/n4=; b=aBStraZXYCfChJ1S/BJnxQ5i85KtkFpd2bKTXH0SbxlD3EFadq8nw4o76LFZWnkn57iR7D kBykdZmnsXzeHScI1HmWEN3pTO02wWE4jXv96T4JfEfcvCn2yRq62VqTSaJNhQL/IQCYb3 OHmv6Q3mp8E9LXnwypcnj6/8fJ+HnGeucZN5klCsrUV74EY+ZXIg57kSWUf0LTItMUYulw P8jWhLANH+440xhyNGRsUODPgyPDzxQb8xkJ183OMgOpP0kzFMcKhJX4xf0bUdQSAEicb1 /wd7yXtsf82UbmKBh+UggifDhZnOT72l9/0sbxaL4mkh8o/c1E0zn5rErnhfOQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661721940; a=rsa-sha256; cv=none; b=lNrRI/nGdK40MhwyyeL1+qY2/VUyJXpQi+/dUvrJD6mRJ7U+SYQttsft24sojA3dkakt/1 ZTOxm9yFZGzdkA3/9vz5hq8vCtFzwME5K7WkTXZ4VnwpC/O8X/aFcjD0BcxA25/WNl4k0U 1Zwe/SmpbnUii5/UhV3corGgQPbmQkyfu+fHiphZw1AW6VXEEJZOII4V2/Hwj3Vy6hJc5q k+5AsZvXKT2qMdBxCBspt9wI+oRnYVOSn+S1AY3WhogD5lPXfGWSU+igH8lr7G++qzz4go 8l6SJR+4rbmYhY+FGsUXOktbxJ81RsXHmBJoM5xAun/gLmLQS46e4BH4gTCf3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=0685c73cfe88b94d60b1b2ddfdb36c684a008006 commit 0685c73cfe88b94d60b1b2ddfdb36c684a008006 Author: Rick Macklem AuthorDate: 2022-08-28 21:24:39 +0000 Commit: Rick Macklem CommitDate: 2022-08-28 21:24:39 +0000 nfscl: Add a console message for session recovery The NFSv4.1/4.2 client does recovery when it receives a NFSERR_BADSESSION reply from the server. If the server has not rebooted, this is often caused by multiple clients using the same /etc/hostid and, as such, not being recognized as different clients by the server. This trivial patch adds a console message to suggest that client's /etc/hostid's need to be checked for uniqueness. MFC after: 2 weeks --- sys/fs/nfs/nfs_commonkrpc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/fs/nfs/nfs_commonkrpc.c b/sys/fs/nfs/nfs_commonkrpc.c index 91ebd84fabd0..9badd8be47d4 100644 --- a/sys/fs/nfs/nfs_commonkrpc.c +++ b/sys/fs/nfs/nfs_commonkrpc.c @@ -1131,6 +1131,10 @@ tryagain: sep = NFSMNT_MDSSESSION(nmp); if (bcmp(sep->nfsess_sessionid, nd->nd_sequence, NFSX_V4SESSIONID) == 0) { + printf("Initiate recovery. If server " + "has not rebooted, " + "check NFS clients for unique " + "/etc/hostid's\n"); /* Initiate recovery. */ sep->nfsess_defunct = 1; NFSCL_DEBUG(1, "Marked defunct\n");