From nobody Sat Aug 20 20:47:05 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M99fT2Q51z4ZFfN; Sat, 20 Aug 2022 20:47:13 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M99fT0sKLz3vZN; Sat, 20 Aug 2022 20:47:13 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 27KKl6Uj005635 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 20 Aug 2022 13:47:06 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 27KKl50M005634; Sat, 20 Aug 2022 13:47:05 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Sat, 20 Aug 2022 13:47:05 -0700 From: Gleb Smirnoff To: Charlie Li Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, zi@freebsd.org Subject: Re: git: 1922eb3e9c23 - main - protosw: retire pr_slowtimo and pr_fasttimo Message-ID: References: <202208171852.27HIqKbY013087@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4M99fT0sKLz3vZN X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sat, Aug 20, 2022 at 01:35:38PM -0400, Charlie Li wrote: C> > -#define PR_SLOWHZ 2 /* 2 slow timeouts per second */ C> > -#define PR_FASTHZ 5 /* 5 fast timeouts per second */ C> > - C> > /* C> > * This number should be defined again within each protocol family to avoid C> > * confusion. C> > C> > C> This broke net-mgmt/net-snmp, which uses PR_SLOWHZ directly. Upstream C> issue filed at https://github.com/net-snmp/net-snmp/issues/445 Thanks for report! Looking into mibII/tcp.c code, I'm 99% sure it wasn't correct on FreeBSD for at least 10-15 years if not always. The next failure is: mibgroup/ip-mib/data_access/scalars_sysctl.c:285:38: error: use of undeclared identifier 'PR_SLOWHZ' ipReasmTimeout_val = IPFRAGTTL / PR_SLOWHZ; And this code was actually constructing correct value. I created pull requests upstream. -- Gleb Smirnoff