From nobody Tue Aug 16 17:11:39 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6d3f57wQz4Yw1q; Tue, 16 Aug 2022 17:11:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6d3f4gg9z3mp5; Tue, 16 Aug 2022 17:11:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660669902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1fSdpCJwixhPzwsi1tR610UUUPt468bu/cQ1flxJvBo=; b=x9nD6gpvzGH8SIAroFk+1Nj46wC/fDagVkDQsf1rU/idIZAWcYMcIjuLclmnbyBuDb5NWY uWC2YM0xg/IirCsakEarQK21jsw1W7H5h66KKrs/yM5G48v5T+Fdo/2mVBVZ/raK7ubxZj Qkb73RFtt/rxJQwXjnhSo6ij1E2+A/IafTZnSTL4W2TyLAvpfKrjV0plPibVxKYT40KLox qkyr+Nc6YTgmN/LEIfpSJF1rkoFn1bctB9BmS8wHQinhMg6ANIQT5zqWmLOhDsEM+AT6r1 m9AR/VwA9iZx4nyIa1qVsmGj/nfIAWcWD4peuVlnzhBUclXe5Htz76LzkV3OWw== Received: from [IPV6:2601:648:8680:ed60:4da3:1c9f:f35c:a167] (unknown [IPv6:2601:648:8680:ed60:4da3:1c9f:f35c:a167]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M6d3c62M6z11LD; Tue, 16 Aug 2022 17:11:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3cfb8729-cbcc-cb09-3811-1d9fc254c0bb@FreeBSD.org> Date: Tue, 16 Aug 2022 10:11:39 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Content-Language: en-US To: Warner Losh , Cy Schubert Cc: Alexey Dokuchaev , Dimitry Andric , Jessica Clarke , Konstantin Belousov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <20220816140000.365C5150@slippy.cwsent.com> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660669902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1fSdpCJwixhPzwsi1tR610UUUPt468bu/cQ1flxJvBo=; b=w2rYWXkeOXuvPzZW6oxPEUyS7dfk5wVZb+IukRaKaVM3wV9qxlvmhpDNZZlKdd+k7756T+ zAhV567nRrGnRGwxz054SnxJjIjEIqy6hpiIcEugamfYZopW5AyQjDGUifpGZdmvDVJHYZ YpKqp83hBDMBVTQRjEY666Ea5pP1g2jRxUaVSuzQPN+vP8jDB8cv0ftJddKM2fqnsr5R6h wobY/Ysl6EWU5TYbnZ5KQ9rf12byjmk3b+QYEHZuO8n4KJqFRt/s9nrYMpKhULfmejb498 Kg0S5tfW+/iUEo5VPslRNR/1OwvXL7fb1s9Fr4z1hSuMcWp/eWk4Yp923Oov8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660669902; a=rsa-sha256; cv=none; b=tVQBCqWbreW4VO4MpeI7cC2+SWKGmXxb162nwFk/EpypdknH9STOXBOFaavHFMufH1qER2 eAZ3byS2sTa9MpoxiVVGUPyvIugNzOZ3PZwm2PpFJMKnYc7LGcbBkcBbZ+5tK65D6dfI8c 1s6xCoWAPY/kyIokR83ttsoaNoaFcyAQOvnmaqe0DCdKIVmCxRJxqB2E7+lMYmTbgEjvoI 0SMB79ya9rr8DjT3zXyWLqVvo2Dkcw9l22UHHTvLJ7vq+t8sXi/TwdF/vVu4gy5FWiVTfP SrcrM/rt82GvVWZR8XOgmyMkJx7L9ng9glsHI4Ys/ziiO738Yd6PYYGl2kDnzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 8/16/22 7:51 AM, Warner Losh wrote: > On Tue, Aug 16, 2022, 8:00 AM Cy Schubert wrote: > >> In message , Alexey Dokuchaev writes: >>> On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: >>>> ... >>>> But I think it is better to have the definitions matching the >>>> declarations exactly. We should sweep through the whole tree and get >>>> rid of all K&R functions too. I believe Warner wanted to attempt that. >>> >>> I won't comment on the technical side of things, but seeing this plethora >>> of identical commits is not just annoying, but pessimizes blaming as >> well. >>> Why can't it all be done in more coarse pieces, if not one commit? >> >> Agreed. >> > > I'd prefer one burst. Cherry picking large commit that have conflicts is a > real pain. Especially since the pain is different for 12 and 13. Especially > since things get MFCd at different rates by different people. As someone > who has had to sort that out multiple times, I know I've spent quite a bit > more time unwinding one larger commit that was partially merged before I > got there. It was terrible. It creates a lot of extra work for the mergers. > Think boot loader that takes a while to settle before a lot of changes are > mfc'd due to its huge number of combinatorics (hundreds of boot > combinations) which take a while to have enough testing to know we've > mitigated the risk as best we can, not all by me or even all in src/stand. > With lots of commits, the lists are long but easily automated with any > conflicts being quick and fast to resolve. Larger commits are bigger > efforts to resolve making it harder to provide good support to old > branches. And that's already hard enough. > > Also with one burst, it's just a range delete in my email client once. FWIW, what I did with -Wset-but-unused was to work on them as individual commits in a branch for a couple of days to fix all the issues. I then got the non-trivial cases reviewed and tried to do large blasts of the remaining ones. The DRIVER_MODULE sweep was even more this way. I think for this one I ended doing 50-commits-at-a-time bursts at the end for the trivial ones. -- John Baldwin