From nobody Tue Aug 16 12:59:04 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6WSP0Rdbz4Z38Q for ; Tue, 16 Aug 2022 12:59:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6WSN2c9Mz4MSX for ; Tue, 16 Aug 2022 12:59:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vs1-xe32.google.com with SMTP id z185so465699vsb.4 for ; Tue, 16 Aug 2022 05:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=YQk4NIFaThj9a+1DufJidJjAB0BqKAy8csLMXFkuaIo=; b=t5aUzkWYKGsboth2oT0obUBIljVnhwliR3OGnqFCOXhRPM2PPF8rx/ShMHKWkUpxf2 Yj76xhpjmp6dTAcd5ep/p0+6btgADRbUJl5TSgtoJTKtKmvgZwTaPVZOM302TRQyuK45 Js9WBHaqVOq8Whoy7dqG+4yuJK7YAVdsquk1XKjO4WTOF8HswVk/NK3vBmW6fWB1I77W eezZng5/3V2KJctFJverjkh/oauEk8CcMYzmvvDqhmVyXz3KBt9Kzgrl7ntlPjOeJlRw kD1pScbJssK6IE/Jv7GUCehfgJQTX3/9M0UhNRnXIJ/iGAve4hbx388sd51VJFhKI45F TiQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=YQk4NIFaThj9a+1DufJidJjAB0BqKAy8csLMXFkuaIo=; b=LugDmyn+xqwjNWyeiqmnxPmNis7Fa+FnzvvMF2jFzzuwOJIEshALOLg5BysneSt15T 9IETufYXGoBreZWY1nogXc5IIEjiVqaHwdToBBwW4h68Le0wDImt4nP5Zq/WvRdY+i+T SPsve334AutG7UQLScljqCDYGsrqBCrG64ENuXwvCqjk9oyccjL4THXNTsE+h+EZ3KSc 6br8hBMDI5t8n9sGiPxZpX0UCTyj9RvL3+TaLkBZqWWNIi+ALRCwBuwUHG5DOlwZItmv Tq0c6nE5sNxD2AzBNGlZC++SjrhjYTZAuOkuZ3PHhvxi34G5C00S2U+dIYSKEgrl1/Xv NETQ== X-Gm-Message-State: ACgBeo3ZS47N3gwXsPdx1V9rVwi127wip2DiVpVYUAKYp/dsa4R6ng4w vbvhmU1I6hKoIuKTHhadWMqPyBvcJkHAQ8FGs3kbyg== X-Google-Smtp-Source: AA6agR5NqrTwFTF1wBlNTzA8vF47cvOOxOIqSdbAKhTquDmXMqlDR9X1pA0ggOP0yqfJQ30HKvPC4vdMqhIjnIpqT8s= X-Received: by 2002:a67:b208:0:b0:357:e999:441c with SMTP id b8-20020a67b208000000b00357e999441cmr7793187vsf.67.1660654755389; Tue, 16 Aug 2022 05:59:15 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <4ed11043-d368-3084-bb21-2b794e9da748@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Tue, 16 Aug 2022 06:59:04 -0600 Message-ID: Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning To: Alexey Dokuchaev Cc: Dimitry Andric , Jessica Clarke , Konstantin Belousov , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ca3d0905e65b5005" X-Rspamd-Queue-Id: 4M6WSN2c9Mz4MSX X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=t5aUzkWY; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::e32) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::e32:from]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com] X-ThisMailContainsUnwantedMimeParts: N --000000000000ca3d0905e65b5005 Content-Type: text/plain; charset="UTF-8" On Tue, Aug 16, 2022 at 6:50 AM Alexey Dokuchaev wrote: > On Tue, Aug 16, 2022 at 02:41:51PM +0200, Dimitry Andric wrote: > > On 2022-08-16 13:47, Alexey Dokuchaev wrote: > > > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > >> ... > > >> But I think it is better to have the definitions matching the > > >> declarations exactly. We should sweep through the whole tree and get > > >> rid of all K&R functions too. I believe Warner wanted to attempt that. > > > > > > I won't comment on the technical side of things, but seeing this > plethora > > > of identical commits is not just annoying, but pessimizes blaming as > well. > > > > I don't see any reason why this would "pessimize blaming"? What do you > > mean with that? > > Sorry, I've meant bisecting. Not sure why I used that word. > I don't believe this is a serious pessimization. Bisect will jump over these, on the average, with only a few strides. > > Because then somebody else will probably complain "why everything in one > > commit, it should be fine-grained"? > > I see; well, I believe a reasonable balance could be achieved, there are > a lot of numbers between 1 and 100. :) > The 50 other sweeps that we've done since the git conversions have been done exactly this way, though doing it by directory might not be terrible in some cases. My complaint is that the commit message should be 'Stop using K&R function definitions.' or similar, not 'fix a warning in clang' because the former has possibly useful content, while the latter's content is more ephemeral. But in reality, it isn't a huge deal either way. Warner --000000000000ca3d0905e65b5005 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Aug 16, 2022 at 6:50 AM Alexe= y Dokuchaev <danfe@freebsd.org&= gt; wrote:
On Tu= e, Aug 16, 2022 at 02:41:51PM +0200, Dimitry Andric wrote:
> On 2022-08-16 13:47, Alexey Dokuchaev wrote:
> > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > >> ...
> >> But I think it is better to have the definitions matching the=
> >> declarations exactly. We should sweep through the whole tree = and get
> >> rid of all K&R functions too. I believe Warner wanted to = attempt that.
> >
> > I won't comment on the technical side of things, but seeing t= his plethora
> > of identical commits is not just annoying, but pessimizes blaming= as well.
>
> I don't see any reason why this would "pessimize blaming"= ;? What do you
> mean with that?

Sorry, I've meant bisecting.=C2=A0 Not sure why I used that word.

I don't believe this is a serious pessim= ization.=C2=A0 Bisect will jump over these, on the
average, with = only a few strides.
=C2=A0
> Because then somebody else will probably complain "why everything= in one
> commit, it should be fine-grained"?

I see; well, I believe a reasonable balance could be achieved, there are a lot of numbers between 1 and 100. :)

= The 50 other sweeps that we've done since the git conversions have been= done
exactly this way, though doing it by directory might not be= terrible in some cases.

My complaint is that the = commit message should be 'Stop using K&R function
definit= ions.' or similar, not 'fix a warning in clang' because the for= mer has possibly
useful content, while the latter's content i= s more ephemeral. But in reality, it isn't
a huge deal either= way.

Warner=C2=A0
--000000000000ca3d0905e65b5005--