From nobody Fri Aug 12 12:25:07 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M42tr1YGRz4Z1V7; Fri, 12 Aug 2022 12:25:08 +0000 (UTC) (envelope-from matteo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M42tr0nP4z3W1M; Fri, 12 Aug 2022 12:25:08 +0000 (UTC) (envelope-from matteo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660307108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3fNPf1u0o6m7PK2NnfLhqK3a/aSGemXnxDQDqRNT5hQ=; b=wWWHgLdYRiBYiBoSNlurQAs2D3Ewo3vOVI9oef/fLRLqc7mgNMCKWfgNGov1M0G7DM5zrn tyyNztlJychm9MPkxfquoO2gpe6Jld5rG9HtDlY56iCEmMTQj83EYujWwPePkFZ1bK4VCa ysGk+VPVoQ0+MxGJhwmzI2raTyN0gzDYz+FBjWAkgal6Pbojtld3dtiUsfj0PKbM7aitLs mvDzgUA/F013PxmgVvoSzxEXbVIHKz867SgAbX97MrW0CHBNIwXOcVOku9iVr508BUTDw3 sssF7qgrT2bnspGhu5zFqVEhQqITDCP7mo2fXsl+3BdCOgDRWK05Bw+nqtHmlg== Received: from host-ubertino-mac-24f5a28a9493.wired.10net.amherst.edu (unknown [IPv6:2601:19b:4400:1779::109f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: matteo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M42tq5w5Hz1JBB; Fri, 12 Aug 2022 12:25:07 +0000 (UTC) (envelope-from matteo@freebsd.org) Date: Fri, 12 Aug 2022 08:25:07 -0400 From: Matteo Riondato To: Maxim Sobolev Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6a70a0c8bfa6 - main - Document implicit dependencies of the mlx5(4) & friends. Message-ID: <20220812122507.6ojv2jtul5jcewch@host-ubertino-mac-24f5a28a9493.wired.10net.amherst.edu> X-PGP-Key: http://rionda.to/files/matteogpg.asc References: <202208112333.27BNXe7R038996@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vgoqmxzbptosqwmc" Content-Disposition: inline In-Reply-To: <202208112333.27BNXe7R038996@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660307108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3fNPf1u0o6m7PK2NnfLhqK3a/aSGemXnxDQDqRNT5hQ=; b=XikO/Qqi5FqD2XKbdXUxS2baiR2nlQogw1yLkVNDuMUjBNWUnFXF+KTOLvaEkI/q/QbTk9 J/Egy1lEwh/pdCj9aj6KJD0RwoFygX7pboB0uXRVgQc/C7XW1hGFj27n+D19oLb0Z/3EV/ mgq4ZbA2cfwz5mltSI/hGx4lcj7OoU3aKhyHSEB74/vOwN5TIcOnDitxW9xGlufFf+TOwY Mm4i2rSinkGbN7MQBADEyrbkjSKesXlaVgSMhyO88nSqJ89DMem7A2sCLMKdWKSqZNgpE8 o7FjadlIGMayvq/qD/qpqneGE6odMHXyw/XEXElE0wA4f5EzXbPMTumn6dlmgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660307108; a=rsa-sha256; cv=none; b=X4+0MDocQi9n/1/n9gihOJ19wwQJIcjdkhoLodVh3RsdiTp+NJJUtN+LMzjhxLltUpqDuG 8it8OAW76d5iF/wJUfAcjT5TjC0Snb57Rqr6AJO1U8cBSAJFLrxGXlRjnPflchBXgSN0ri EDO12WSBwCS9XI3Fah7q0i+fvVKG5bKfsjAFqZa1MfEaqZvb/qMCzFWZt7EX5Wkk97hZEG Ji8co8bI2BApg7WG5kWIwCD9jlRJFn5Ds33zZOF6ZbDowgSn5q1/T5Qg2bQQAjStg4JzXx T7biZc1w9nQRnmvQ93zd/XoiNCRHi1APqAFLSFJOoqLfmXbW7jGBR1iPrc+rRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --vgoqmxzbptosqwmc Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-08-11 at 19:33 EDT, Maxim Sobolev wrote: >The branch main has been updated by sobomax: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3D6a70a0c8bfa6fe8a2739527e5c8= 22aec985e83e9 > >commit 6a70a0c8bfa6fe8a2739527e5c822aec985e83e9 >Author: Maxim Sobolev >AuthorDate: 2022-08-11 23:28:27 +0000 >Commit: Maxim Sobolev >CommitDate: 2022-08-11 23:33:09 +0000 > > Document implicit dependencies of the mlx5(4) & friends. > > MFC after: 2 weeks >--- > sys/amd64/conf/GENERIC | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC >index 53c6043a0146..9178abba36cc 100644 >--- a/sys/amd64/conf/GENERIC >+++ b/sys/amd64/conf/GENERIC >@@ -260,7 +260,8 @@ device le # AMD Am7900 LANCE and=20 >Am79C9xx PCnet > device ti # Alteon Networks Tigon I/II gigabit Ethernet > > # Nvidia/Mellanox Connect-X 4 and later, Ethernet only >-# mlx5ib requires ibcore infra and is not included by default >+# o requires COMPAT_LINUXKPI and xz(4) >+# o mlx5ib requires ibcore infra and is not included by default Hi Maxim, May I suggest editing the above line to "mlx5ib requires ibcore infra,=20 thus it is not included here" (replacing "and" with "thus" being the=20 important part). The mlx5en(4) page, in SYNOPSIS, lists also option RATELIMIT, option=20 KERN_TLS, and device firmware. Are these needed? I imagine that "device=20 firmware" certainly is (thus should perhaps be listed in the comment=20 above), but what about the options? > device mlx5 # Base driver > device mlxfw # Firmware update > device mlx5en # Ethernet driver Thanks, Matteo --vgoqmxzbptosqwmc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmL2Rp0TGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVAfvBEAC+TMsQhc/MmcTGL3EFY+LMtI7jbp9I PH0za/TEsU1XDtY9d249nY/waQgj5GwROwVvLNNETEhzrOv6kM2LeLZkaaJmj+nZ D65CgL0sX4wRRojbGehOzXARyhG0IMAvmFyQdozFk6VrDEqlSu2RJhOeh1dIsBx2 6AvUqydsvIRl7MI93MEZ5oeeG2OveHFDyij8r7fB7B4e/rqIBtIYCSPAJ9Q79tUl Iu5WJdH9C5nVb056YEoeRlj2oD4rxriKvXMVsUr7zAx3PaGATAqCI0K2Fbh2WrRn QD3bhLpRhfCf+2zHR5MO461RyLHZCnr+NCVN1VaH+TaWcIk4EdTAPVwfivbFIGSr YwRYxKXu2dfupxZqHKCmUcte1m7vQ5VAP3++moUaM1R9yLGpFjTf+HX/tgho/Ww5 Yh0fWhm/9EWLy+0Ok+s7aEhXULFs/YYQCZLiyzlu+Vz8AFgAJxfZS78rXIgkD9st Mkq956RxUMxbkDjzBPVM2uH5zOBIBrqj9vSK9wUZ1pdEb52RV7PzqrLOZmXYxRPg ISdvy0+afPd+xDHSCGwlUK9FU1W12RNuNAaOuL3GNwUjmsADCZPU8qjLgLk2KNhu WhNO9eRtlRMUGTLMVimL1u1L7jhrZ6BYZVOJ69+iO2gNrSQgePxKFzFsu9eqtu03 XJ1KWdepAVrVTQ== =UK8D -----END PGP SIGNATURE----- --vgoqmxzbptosqwmc--