From nobody Wed Aug 03 00:43:48 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LyClq4TsKz4Y4wx; Wed, 3 Aug 2022 00:43:51 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LyClp4Zj2z3XKJ; Wed, 3 Aug 2022 00:43:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTP id Iv6boV0ySSp39J2UHoBmxF; Wed, 03 Aug 2022 00:43:49 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id J2UGooCW8vn7BJ2UHosB1b; Wed, 03 Aug 2022 00:43:49 +0000 X-Authority-Analysis: v=2.4 cv=a/cjSGeF c=1 sm=1 tr=0 ts=62e9c4c5 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=biHskzXt2R4A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=jaCygfFNoWxb7CcOSigA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 41DC313A; Tue, 2 Aug 2022 17:43:48 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 14C4610F; Tue, 2 Aug 2022 17:43:48 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mark Johnston cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1165fc9a5266 - main - ctfconvert: Give bitfield types names distinct from the base type In-reply-to: <202208030039.2730dCnR016853@gitrepo.freebsd.org> References: <202208030039.2730dCnR016853@gitrepo.freebsd.org> Comments: In-reply-to Mark Johnston message dated "Wed, 03 Aug 2022 00:39:12 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 02 Aug 2022 17:43:48 -0700 Message-Id: <20220803004348.14C4610F@slippy.cwsent.com> X-CMAE-Envelope: MS4xfMi2tjRy3n0zMVMHoNE1qJREYxxbFOpLDbmcZJDEnE2hv1o7MslTr89Nrn0IsvMuHCgiZrQEwm+KzyZMGMvMyDb/xP+dQ4tRA7BP3eEBcSCgBKxooYCp w38dvQPVAXEpIiZPwktymw9VLam0OUf5t/ozjhiTT64OS1ZeCizvDEIC8NfHtsUuy9AGe/gtKk1WwiiHk6f8avlxQQVsZYt3RUc+zFN+TxAgyn0Nbp+bNCwr 2vWg8vToXWVysEzJiN7QHlyPIOKSdcGhtGEbKoJ2uQLCTqKlQdrLTYtZEeP6sgkSsNLrrcl/a1jTzPaRfq2Wztdlhml3Uk6A17cxLE46GY8= X-Rspamd-Queue-Id: 4LyClp4Zj2z3XKJ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.33) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.80 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; MV_CASE(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.33:from]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org,dev-commits-src-all@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N In message <202208030039.2730dCnR016853@gitrepo.freebsd.org>, Mark Johnston wri tes: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1165fc9a526630487a1feb63daef65c5 > aee1a583 > > commit 1165fc9a526630487a1feb63daef65c5aee1a583 > Author: Mark Johnston > AuthorDate: 2022-08-03 00:32:17 +0000 > Commit: Mark Johnston > CommitDate: 2022-08-03 00:32:17 +0000 > > ctfconvert: Give bitfield types names distinct from the base type > > CTF integers have an explicit width and so can be used to represent > bitfields. Bitfield types emitted by ctfconvert(1) share the name of > the base integer type, so a struct field with type "unsigned int : 15" > will have a type named "unsigned int". > > To avoid ambiguity when looking up types by name, add a suffix to names > of bitfield types to distinguish them from the base type. Then, if > ctfmerge happens to order bitfield types before the corresponding base > type in a CTF file, a name lookup will return the base type, which is > always going to be the desired behaviour. > > PR: 265403 > Reported by: cy > MFC after: 1 week > Sponsored by: The FreeBSD Foundation Thank you muchly. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0