From nobody Fri Apr 29 23:24:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 81D3D1995F4E; Fri, 29 Apr 2022 23:24:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KqpVc6Mdbz4cCw; Fri, 29 Apr 2022 23:24:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651274697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0rKYIG1vR4afctJQ7DWJGWFPmhc5TC8c88DHo5hge9I=; b=wUZgu2yNRBuRW8MqK+/fqfGWK7H88BzXtWDtpioeqMPFol7IskN22uzJ0tLFa21qeUVwwZ zA2B2R1nQguh29Qh+PHerxwQbn+cekr07tTscl0twxGTcgFbAB6VJQe3dMNDWQVJX98aDQ VAAuxdhFhV2co/Oj4hEtSFpwUZUbA9gKrcqMIgBixbM8ub7xDQiaN0geND1AsCByZbgPzx OtnRcDLqzqnbbeymiBBfgCQ5iTWJ43AAF6zEMP87zw+uNi8bmLJ+5GjrnFdM0eLLPtusa0 JqBeg5mfFQd9OybeTkKPfCnGn3WF6wRBJXeFTIjPXbzgCHQI7tLOdKJSD87qPw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 944EC15FF2; Fri, 29 Apr 2022 23:24:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23TNOuGh058901; Fri, 29 Apr 2022 23:24:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23TNOusA058900; Fri, 29 Apr 2022 23:24:56 GMT (envelope-from git) Date: Fri, 29 Apr 2022 23:24:56 GMT Message-Id: <202204292324.23TNOusA058900@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Alfonso S. Siciliano" Subject: git: 9b4c606b96ce - main - bsdinstall/partedit: Fix UFS auto partitioning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asiciliano X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9b4c606b96ce8a8b011dc50295c71c38741a0f4f Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651274697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0rKYIG1vR4afctJQ7DWJGWFPmhc5TC8c88DHo5hge9I=; b=sLk2w5FwypydVlEelP1Fk9Q1+8sy+MeCy9n1Br1qKPsrIdaqRkLyCyzO9rNJqJ7Ccn6FXQ CaKPkVGW6bSCN7kz4v8RW+EvqQsxMrmmx64pWWo3DYF+XkVTM1FP11EtogFfIwV20MJ4cv NPrjrGvcoLZ1vimOOGxVwHhEi5VAxYR5XajKGYE9nVMm5x4NBORYwYxTFySZzCOtbsBxr9 Wt8Y/1lvbIF3Z9obV527Fj8MIXP6Y/I8ZaEMFBsYfzeLUvPQMlfmtHvBwIsNpE+s/N0UsV 6dishC4q5ieUzFfTMCKNyCTES+stb1DmjVyG4SCLW8Fo6ViBK5m1ddceao3EMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651274697; a=rsa-sha256; cv=none; b=TKGKPoizNvM6AWJIixukeg3HJKf2E+6S2Kk5/dC8CbbFZkfFjlvsO37ZuHVWI7oQODuxTt eoVS/+TTC7cJA9uV2nHtkgXt1W+J6VufvGkRdlRnnZmIZBeV6nTVhaVE+h1SEmxCjNtK4+ +QQ/RxRTGJOyyBdokuJlKoMMeMa7D5Mh7yd+/9VppFuqn2gAeMvfy+F3Pr72i5CVpmOJIE mvXyYEUDobv65esZzTidra7btTFQlpHVT7WDDg94SW7Hd+BqtToqxOJnpWvswc3tmtpY3y KYu1s+Z0/2+ZssCQx9OGscgm43FddBNZJV5+qjsG2je1Knvkyy8tmVgk9RDBlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by asiciliano: URL: https://cgit.FreeBSD.org/src/commit/?id=9b4c606b96ce8a8b011dc50295c71c38741a0f4f commit 9b4c606b96ce8a8b011dc50295c71c38741a0f4f Author: Alfonso S. Siciliano AuthorDate: 2022-04-29 23:19:30 +0000 Commit: Alfonso S. Siciliano CommitDate: 2022-04-29 23:24:23 +0000 bsdinstall/partedit: Fix UFS auto partitioning Fix bsdinstall "Auto (UFS) Guided Disk Setup" and sade(8) "Auto". The problem is a string comparison failure, it arose during the dialog(3)/bsddialog(3) form conversion: * dialog uses only form.text while bsdialog differentiates between form.init and form.value. * dialog always allocates memory for form values while bsddialog only when a button is pressed. Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D35033 --- usr.sbin/bsdinstall/partedit/gpart_ops.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/usr.sbin/bsdinstall/partedit/gpart_ops.c b/usr.sbin/bsdinstall/partedit/gpart_ops.c index 65cda247e146..26aedb58ef39 100644 --- a/usr.sbin/bsdinstall/partedit/gpart_ops.c +++ b/usr.sbin/bsdinstall/partedit/gpart_ops.c @@ -1154,6 +1154,12 @@ addpartform: init_allocated = true; goto addpartform; } + } else { /* auto partitioning */ + items[0].value = strdup(items[0].init); + items[1].value = strdup(items[1].init); + items[2].value = strdup(items[2].init); + if (nitems > 3) + items[3].value = strdup(items[3].init); } /*