From nobody Wed Apr 27 19:18:03 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5AF3219987F5; Wed, 27 Apr 2022 19:18:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KpT6h20Kyz3GCV; Wed, 27 Apr 2022 19:18:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651087084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9Oe+rqAD4v+N28IOPxPacRKxOMfTer30DLD5qvQxYNU=; b=TdnXP0su5SJBfeAddslwUcCJJf+e0fouiAhEu0BQ381ogDgHixgyVo2Pwp9kOBCELZqepk O7dt7nmZPzeyeERlvXB8yUC3Bq/Pw22ycWQ9O4D4LKZ3ggsRlhavW0SAxHYuybLCqCOQYg glDB+su5w3tp0PPI2exIfcINWa4uhG5BydPFrPALXGXEfsf9FY+34gKzFdZGuqfvyhBn8Z JfEMQzaOT4ENqggigSVScjmY755XGyWXJJ05DITTwfNHpqf47t8vHhZ7yGhSd55b+zRTh2 iOTbp1RplZJAJALSF/HKNQ9sTMLqzVRhnTXcFs8q5IfhGFoW6CwitML0tYIfOw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2041916F4; Wed, 27 Apr 2022 19:18:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23RJI3Vq033829; Wed, 27 Apr 2022 19:18:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23RJI38p033828; Wed, 27 Apr 2022 19:18:03 GMT (envelope-from git) Date: Wed, 27 Apr 2022 19:18:03 GMT Message-Id: <202204271918.23RJI38p033828@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: b199e55ce6d9 - stable/11 - No need to stop XHCI endpoints in disabled state. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/stable/11 X-Git-Reftype: branch X-Git-Commit: b199e55ce6d9ec938933cb86fbad04fb064910d9 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651087084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9Oe+rqAD4v+N28IOPxPacRKxOMfTer30DLD5qvQxYNU=; b=fYrvmOHMqK161dbbCj64pfmiu712KJTt1z1Zjpa9BbTJpsL2WuqwrNzvR2JzJW4CoDzptv gPPikMZeMMZS0O5exDvJbSHu9wRstfmlAaTNGmFPyc2v14+Yh/TEkmGnA7lsFmlfJKTzG+ MqCLGvR2sK8gwQf2fQuGdjG1utjZqbwjo2sh4m61GmjBKk9aeMQHOfVFiauNkmEH4D16L7 opOf2ZZBvuMRTxcX0xRqUXeWbPVtHEqxroN3ZDTpdP826ly51XGgfGThPrrID7GfHs9OUY dfd020znHPGgXQKBR4QJAwxkSrnHPAFUMaNJgGVgMhUUQZMr0HzH94XLubcyew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651087084; a=rsa-sha256; cv=none; b=jbCqLWzv4ATlNgzr0vbIRNC+gWofqA+eLip/TTdyqb8rg9hIDYIQmfbJJxC8aAmGNP44UY nw+SWbpuQ9oFmOWatqHHK1jbbCLlSn72CrlBnjcq1wEgjpWe0rF0zpnssNcNiCIK+YmmXm TJ1+KH1yAlUIAHaCxaH+izvtWvHIoslD3j5jKeaYQXntUl8ZjOTtLqSCgnmxuVAXUJWYW6 PgHkMw24cOdnCupULEQa1M7zQ4v6ujGnqnCQenm/D1ZG84oHeNzdyB8kF8A0utFWrFMmD5 vm56gznMaPzAAgwziX4YnvJlzXAVdzM3JZnPKnX+ydqJ7v05nK2kpPZJZUr13w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/11 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=b199e55ce6d9ec938933cb86fbad04fb064910d9 commit b199e55ce6d9ec938933cb86fbad04fb064910d9 Author: Hans Petter Selasky AuthorDate: 2020-12-23 10:54:42 +0000 Commit: Hans Petter Selasky CommitDate: 2022-04-27 19:17:40 +0000 No need to stop XHCI endpoints in disabled state. Some AMD XHCI implementations apparently assert a permanent internal failure if this happens. Submitted by: ali.abdallah@suse.com PR: 251503 Sponsored by: Mellanox Technologies // NVIDIA Networking (cherry picked from commit 1622a498525b4ef0d23d30a587b9a3888c3ee0d5) --- sys/dev/usb/controller/xhci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/usb/controller/xhci.c b/sys/dev/usb/controller/xhci.c index c2ef925d4fd3..cfe1b40fdbf8 100644 --- a/sys/dev/usb/controller/xhci.c +++ b/sys/dev/usb/controller/xhci.c @@ -3896,6 +3896,8 @@ xhci_configure_reset_endpoint(struct usb_xfer *xfer) * endpoint context state diagram in the XHCI specification: */ switch (xhci_get_endpoint_state(udev, epno)) { + case XHCI_EPCTX_0_EPSTATE_DISABLED: + break; case XHCI_EPCTX_0_EPSTATE_STOPPED: break; case XHCI_EPCTX_0_EPSTATE_HALTED: