From nobody Tue Apr 19 14:52:58 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8547B11D0476; Tue, 19 Apr 2022 14:53:03 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KjRcb223Bz4sP4; Tue, 19 Apr 2022 14:53:03 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650379983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SF7nnwBOEb7kFoH89aYM629SkMR+N2dTXUlATUs1Ntw=; b=sZtptrE7AxzV9pgQibkWfU4WQv3suLt6H2hsQD2UgK3ruheDDWYXwomCxpjEQZFA2fBGmw tN1uOGIQD5z+nNv+HIomVCx/+/b7eVbHQ2OyLOm1VmPPTrVapzLi64SWZMz49Y+ztds9gC XvaPp2cXtvJUB0NOzW8lgiA/IpJvqLySB9jfVdY13bCZRlEUrmY3fGbSm3vU9kYPPn8ViQ OWsaZTMaNfDhBFVMT6eP1P9w8hyIm9BAGlXFEFMkrhGEKtLrtNbMbEh+Ufng1flmzKNxcZ sQOgjUB7jyuFPD8kBhGVmrS6BK1O8l8LZyiHaaf4dpNUOxeXXNsXp6RxFIMcwg== Received: from [IPV6:2003:cd:5f27:b000:f93a:b7b9:54ad:ca10] (p200300cd5f27b000f93ab7b954adca10.dip0.t-ipconnect.de [IPv6:2003:cd:5f27:b000:f93a:b7b9:54ad:ca10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 48E1BA441; Tue, 19 Apr 2022 14:53:02 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: <555d9a3b-b0ca-973a-8b39-4fff62499fd0@FreeBSD.org> Date: Tue, 19 Apr 2022 16:52:58 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: git: 8b83d7e0ee54 - main - Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel builds. Content-Language: en-US To: Mateusz Guzik Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202204182311.23INBqfC025671@gitrepo.freebsd.org> <960b9be3-c3b5-bd48-8038-97511f2f7909@FreeBSD.org> From: Stefan Esser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------w0s0NZQAva7rHkxTI1AgKyGZ" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650379983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SF7nnwBOEb7kFoH89aYM629SkMR+N2dTXUlATUs1Ntw=; b=ErByMq67XyagYFS+VPS16lVvGOsLZepQj6bDVX5dkKZh+Ak8or6PSkTf1S3Wkx+6wlaYsz GW/rC/wndANcd9IR7ZmxrA6W7V/iURy27nam6QF27l/s/MK5CKVH++cFzS+0FeWuRADZzj VkV9Q5RkxNcvejQlVYXBx8trfp1lZGZ5oeo+JTOzDymOH2BeWmP6g+FvLrwhIdjioGiNuz WZ69a2RtJUPej1shIlcgPjMaMkpl9HH0agjzwry37DjCmMILOLuMgvBMz+R2wgorA/mT1s T2OZU2DKqsbaqcwc9kD8gg5x9UfCkghzBi4SrlvJJbr2v12sfhTYfjipEWzw2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650379983; a=rsa-sha256; cv=none; b=BaDlR7C9zpKQA2eLBX3qT98fjS24KO0U84v4fQ9lKlWFFKsLIXE0gTsk5z3e1VQHxCi9Kz TO71GY+2QZXty0hdqqDZiudCV3yOEdtPzMPbCloJoBIMaHR5Q8RKb2Okj/IBQdK6BuJyjL mHYRC8Yl85O41/ROess2/nONGaC0FpWHbIbbZX9k2T7psQQ84Iftv0HFYuun+VJz40NNat AVuQpPURV4iBexOx6OXM6MfViTqewTxr3MsO0R6U9qGj/aermFyFjopABwgtl5yM45Z4ve hw8clPpGUS5CpZfKPBGSHSVkLKP3oslq0CQCsAmXgJwO4jQuPU1KbMeyhce9bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------w0s0NZQAva7rHkxTI1AgKyGZ Content-Type: multipart/mixed; boundary="------------YZVV5ZGbKBjgpLoIgQ00Zcr7"; protected-headers="v1" From: Stefan Esser To: Mateusz Guzik Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-ID: <555d9a3b-b0ca-973a-8b39-4fff62499fd0@FreeBSD.org> Subject: Re: git: 8b83d7e0ee54 - main - Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel builds. References: <202204182311.23INBqfC025671@gitrepo.freebsd.org> <960b9be3-c3b5-bd48-8038-97511f2f7909@FreeBSD.org> In-Reply-To: --------------YZVV5ZGbKBjgpLoIgQ00Zcr7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 19.04.22 um 14:47 schrieb Mateusz Guzik: > As of 19447fc4888379e539dfca7e4c62362d6c279357 the amd64 kernel + > modules build without with a config with these options removed: > diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC > index 53c6043a0146..98b4be69dc94 100644 > --- a/sys/amd64/conf/GENERIC > +++ b/sys/amd64/conf/GENERIC > @@ -69,43 +69,14 @@ options COMPAT_FREEBSD11 # Compatible > with FreeBSD11 > options COMPAT_FREEBSD12 # Compatible with FreeBSD12 > options COMPAT_FREEBSD13 # Compatible with FreeBSD13 > options SCSI_DELAY=3D5000 # Delay (in ms) before probin= g SCSI > -options KTRACE # ktrace(1) support > -options STACK # stack(9) support > options SYSVSHM # SYSV-style shared memory > options SYSVMSG # SYSV-style message queues > options SYSVSEM # SYSV-style semaphores > options _KPOSIX_PRIORITY_SCHEDULING # POSIX P1003_1B real-time > extensions > options PRINTF_BUFR_SIZE=3D128 # Prevent printf output being= > interspersed. > options KBD_INSTALL_CDEV # install a CDEV entry in /dev > -options HWPMC_HOOKS # Necessary kernel hooks for hw= pmc(4) > -options AUDIT # Security event auditing > -options CAPABILITY_MODE # Capsicum capability mode > -options CAPABILITIES # Capsicum capabilities > -options MAC # TrustedBSD MAC Framework > -options KDTRACE_FRAME # Ensure frames are compiled in= > -options KDTRACE_HOOKS # Kernel DTrace hooks > -options DDB_CTF # Kernel ELF linker loads CTF d= ata > options INCLUDE_CONFIG_FILE # Include this file in kernel > -options RACCT # Resource accounting framework= > -options RACCT_DEFAULT_TO_DISABLED # Set kern.racct.enable=3D0 b= y default > -options RCTL # Resource limits > - > -# Debugging support. Always need this: > -options KDB # Enable kernel debugger suppor= t. > -options KDB_TRACE # Print a stack trace for a pan= ic. > -# For full debugger support use (turn off in stable branch): > -options BUF_TRACKING # Track buffer history > -options DDB # Support DDB. > -options FULL_BUF_TRACKING # Track more buffer history > -options GDB # Support remote GDB. > -options DEADLKRES # Enable the deadlock resolver > -options INVARIANTS # Enable calls of extra sanity = checking > -options INVARIANT_SUPPORT # Extra sanity checks of > internal structures, required by INVARIANTS > -options QUEUE_MACRO_DEBUG_TRASH # Trash queue(2) internal > pointers on invalidation > -options WITNESS # Enable checks to detect > deadlocks and cycles > -options WITNESS_SKIPSPIN # Don't run witness on > spinlocks for speed > -options MALLOC_DEBUG_MAXZONES=3D8 # Separate malloc(9) zones > -options VERBOSE_SYSINIT=3D0 # Support > debug.verbose_sysinit, off by default My custom kernel built after applying one more change: diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index b258deab7d2b..8fbd6ed58efa 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -2177,7 +2177,7 @@ softdep_flushfiles(oldmnt, flags, td) int flags; struct thread *td; { - struct ufsmount *ump; + struct ufsmount *ump __unused; #ifdef QUOTA int i; #endif --------------YZVV5ZGbKBjgpLoIgQ00Zcr7-- --------------w0s0NZQAva7rHkxTI1AgKyGZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmJezMoFAwAAAAAACgkQR+u171r99UTs tQgAxP0rPwQpeptgYHu6FsE/9/IbjeOE/ropotEKNjIZYY6il5gyUXKmwjLOs+V28uTWQDkLVuSZ jVSBDRRimoYf9MQv/JwQLx2KG2gTemx1Z5mESzlziBsVBEF6UdPl7Wui3zME+lGGBEFP9rqPGoE7 8lHQ9EzQhB6YKcNdnozg9cO5pP6zk27XqEOm5slnGZkkifvphD8gjEy0nEoujswbb09k6ZpdQ+oA OyVJFVsUpAnljwmjhZEGdMGBhxMEbWMMe0klLLN9xgutYTbN4/OZmbEvl/hmHQr29wGGieaiW3ic xQ/65hIZaTgUU2c97PGqvo/TVXP2dW0/DRMq6QbI7Q== =5NvD -----END PGP SIGNATURE----- --------------w0s0NZQAva7rHkxTI1AgKyGZ--