From nobody Thu Apr 14 07:21:17 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 233211B3C391; Thu, 14 Apr 2022 07:21:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kf9qf0JRjz4nj4; Thu, 14 Apr 2022 07:21:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649920878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sUFurUVdMvguXxzlpflGdsfp5EBOtdn/dNSwNesZz/o=; b=PgNTMopACYkKI1sPh6UwxeICK0pMa/blnC/w7WWRhtEitCTtz/b7dHDjdPi+oHrw5VsIdG fE6YxEe7utl+Cl8Zqyp/TqRNi7ybxGjD3+yPTTN7kKdPNAbH8PcbzvdB2LNYrzss0My8wl 3sZLcZyQaZsXL3gkwP0eP1HdURdWeiK//yxEaIIfcHrstphSlTCBEvkYjE9qb1+7TH+ZCP usLPCo+s0jmfOYVsljZ3NVllWZNv9JMJj5ScxEaJ5nKocB7JH+9xVnrvwdq+VDsKMcZ2gN cFZvo6deNaPnpsQt9RnPWiVPha49EMkiaZ7h8VgHq9vGaIe40x4WX+W+2g0R0w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DC5911BEF8; Thu, 14 Apr 2022 07:21:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23E7LHMB048852; Thu, 14 Apr 2022 07:21:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23E7LHvv048851; Thu, 14 Apr 2022 07:21:17 GMT (envelope-from git) Date: Thu, 14 Apr 2022 07:21:17 GMT Message-Id: <202204140721.23E7LHvv048851@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 239170f29210 - main - cxgbe(4): Fix control flow issues reported by Coverity. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 239170f29210a21a68284dc967e57ed8047fb2ba Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649920878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sUFurUVdMvguXxzlpflGdsfp5EBOtdn/dNSwNesZz/o=; b=Nu57n6ow0CsMxd1HzgnZBMWlbQBHvsw2ZobjHFIt7dudv3spFnsXs4wt23F22E6Utmkvkp 8qKz0bed/2pC6TEhxLikb48hG7gJOfE35MkLTwVwbkKHBQMaEJBP3dauCiizemSHzT0ZLf DOQBDibAnW1yG3VNvK2a9FlmkGczQhQGBdYFlGQT7gIrbeUke2Fbq5pJSz+LC+sLqgETtj ARL8p5Pa7VxxXosR2Hnvg0oBRyVIZrZpj9S2llIu5/+7p+G0sCJlgqKEg7M1NR4CJm3QZf gciP+TtaVQgYw8AXyXcEyBeiPy+P/KFDgQR4k6C9W+ScFk489bDV/HiZJFOl2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649920878; a=rsa-sha256; cv=none; b=L50zKw8Bl2fs1eFRSvem7/GI5Q8Csqz/Ir4CbGYKu/wzrMAWkNVAFSWQfEm4YA30IbjjLM xuogNBqJlCSJDEIEBqVaKRC86QuYTyfncC0/2xsyXtizzpRIYdzoRKIkULoqqRk9Mi29jq 0nZlmqRt+NEIdHNFrfwEaiQHhZDBgjRJHKFvqVkAKnx4xUplKTCHye0rjezsKEb4yndwag Hkh6YFuLu8pK+43FrrhBGlQnqxpvBSoy4d831ZsKZHcf8nAQHEe9tk7NJ5/vI1coeF/QNd VwptHswhmwsIVcwKWCwxlXuo5O3of5JdoD3tTFEtmqAGqPrLxZPLEcYZpmoU7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=239170f29210a21a68284dc967e57ed8047fb2ba commit 239170f29210a21a68284dc967e57ed8047fb2ba Author: Navdeep Parhar AuthorDate: 2022-04-14 07:17:36 +0000 Commit: Navdeep Parhar CommitDate: 2022-04-14 07:17:36 +0000 cxgbe(4): Fix control flow issues reported by Coverity. CID 1487932: Control flow issues (NESTING_INDENT_MISMATCH). The macro on this line expands into multiple statements, only the first of which is nested within the preceding parent while the rest are not. 9828 ulp_region(RX_TLS_KEY); Reported by: Coverity (CID 1487932) Fixes: f88b31885c4 cxgbe(4): meminfo should get the TLS region's limits from the hardware. MFC after: 3 days Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index eba79deeced3..b4069119c167 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9824,8 +9824,9 @@ sysctl_meminfo(SYSCTL_HANDLER_ARGS) ulp_region(RX_RQUDP); ulp_region(RX_PBL); ulp_region(TX_PBL); - if (sc->cryptocaps & FW_CAPS_CONFIG_TLSKEYS) + if (sc->cryptocaps & FW_CAPS_CONFIG_TLSKEYS) { ulp_region(RX_TLS_KEY); + } #undef ulp_region md->base = 0;