From nobody Tue Apr 12 21:38:12 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2D98B1AF5B9E; Tue, 12 Apr 2022 21:38:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KdJxJ72L6z4bMC; Tue, 12 Apr 2022 21:38:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649799493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=78cZtEA6+rXo2yTkWdykBdNWhui6Aj48Qk+11QKwL0k=; b=UqfJMNW9poDJpPOesV/2ISX8/7HJkdyxoNjvdDBHH2PSuEvMg8bVA1CA/DVJW5FhX1gU2J vtoYElnGMaqg1uCrbfBGNuMxIpHpENYorRE22pHhvTVdYTq3QUoT3ShH+S02GjpVlbh7Bu N3GHthJ/G9wAMy3Wg5foNFKVFzCRDwgxtznZWBfTAs2TDXoAx2bi98YIIAnTNUbybQ1Wib dgUwmPR08I5g9K7mfg1Mx6cettHHmo36+3f3QZGBYBbJ+1pbMLJFp2qLsHi8T3E/qZoYi7 wl5eusLMWkFBpm6+lzJL1LTelhKoNEMR3R/xNh/sqSntC/2I9QxZgY/cXwMg/A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CEBAD1F0D9; Tue, 12 Apr 2022 21:38:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23CLcCxo008347; Tue, 12 Apr 2022 21:38:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23CLcCud008346; Tue, 12 Apr 2022 21:38:12 GMT (envelope-from git) Date: Tue, 12 Apr 2022 21:38:12 GMT Message-Id: <202204122138.23CLcCud008346@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: d76960962093 - main - tty: Remove an incorrect assertion from ttyinq_line_iterate() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d769609620931a62ebacbd4f1f5fd048c7e3d7c0 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649799493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=78cZtEA6+rXo2yTkWdykBdNWhui6Aj48Qk+11QKwL0k=; b=pACu7zzvyE/WKLsYMS8DZ/PBF6MnGYUJR2Q/d08XDpbpqSfuAHRSe4mz6w3vzFQ3PbGRgy UlFdI2ho/zEOjK9InGiXdX158aeMxtSkEVe7MgEYPKrDezHJDxj4jNHsG352R1PlWkA3Wp Kglrwkf6FBPFjzEgpbJpsw8Il92EYmy2mVrxzPw1H0Mwe6l8xS2ILncErXl4yJXRWgHSa8 6CyMDp+O2LMO8/3bEfzgR3n0qwSoVNLslPlWR7pXlsKtc7fAl7d9G+NVIvpIqrEnjzMSBB okeEUajL6friHgvcAqXOEAHIRU8Y3UE8YDQayYLb5Wa18QIxNTooKM+yQ9159g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649799493; a=rsa-sha256; cv=none; b=BnSROZoP4IVwEe94q1o7igK5guZdKpjx6bFWhHVec/xFlsfa57TUmrYZH3ur5HcCoWYVM6 WWQO7702c640HG/7Zmm5LG+bTCDvItVWTNSyYBklpUOGQmqSVgtHjWY/c5jyPaHzyFGoB6 hot5CLB557l0Z0mp+SNHjwJFLzKH54XWkwY0+GYLWZww45GX01HaxAG/mnBct5Klzkk7v8 hrk6TAWDzKsb/0NATR8vHnc+vAX2Dg46LGayPVCpJTAlO+xiEoXsnyaM5xZgj7Li8/t3qu muGWX/vM8+3kw5KDa4yxqTvKYGSF+iX6NYbFUxisnzH06SHPl5hGzqUlxRhwUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d769609620931a62ebacbd4f1f5fd048c7e3d7c0 commit d769609620931a62ebacbd4f1f5fd048c7e3d7c0 Author: Mark Johnston AuthorDate: 2022-04-12 21:30:04 +0000 Commit: Mark Johnston CommitDate: 2022-04-12 21:30:04 +0000 tty: Remove an incorrect assertion from ttyinq_line_iterate() We may legitimately have tib == NULL if we're at the very end of the queue. PR: 215373 Reported by: pho MFC after: 1 week Sponsored by: The FreeBSD Foundation --- sys/kern/tty_inq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/kern/tty_inq.c b/sys/kern/tty_inq.c index bd26211735d2..069da33ab26a 100644 --- a/sys/kern/tty_inq.c +++ b/sys/kern/tty_inq.c @@ -464,7 +464,6 @@ ttyinq_line_iterate(struct ttyinq *ti, /* Last byte iterated - go to the next block. */ if (boff == TTYINQ_DATASIZE - 1) tib = tib->tib_next; - MPASS(tib != NULL); } }