Re: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd.

-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of John Baldwin <jhb@FreeBSD.org>
Date: 2022-04-07, Thursday at 17:03
To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
Subject: git: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd.

    The branch main has been updated by jhb:

    URL: https://cgit.FreeBSD.org/src/commit/?id=885db9301ef9dfe420eff3c09aca497b7fc60924

    commit 885db9301ef9dfe420eff3c09aca497b7fc60924
    Author:     John Baldwin <jhb@FreeBSD.org>
    AuthorDate: 2022-04-08 00:01:27 +0000
    Commit:     John Baldwin <jhb@FreeBSD.org>
    CommitDate: 2022-04-08 00:01:27 +0000

        qlnx: Comment out remaining references to tx_data_bd.

Why comment out, as opposed to removing outright (like most of the other unused-but-set cleanup)?

Thanks,

Ravi (rpokala@)

    ---
     sys/dev/qlnx/qlnxe/qlnx_os.c | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c
    index 4c1a55064a68..9e172e27ab35 100644
    --- a/sys/dev/qlnx/qlnxe/qlnx_os.c
    +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c
    @@ -2909,7 +2909,7 @@ qlnx_free_tx_pkt(qlnx_host_t *ha, struct qlnx_fastpath *fp,
     	struct mbuf		*mp;
     	bus_dmamap_t		map;
     	int			i;
    -	struct eth_tx_bd	*tx_data_bd;
    +//	struct eth_tx_bd	*tx_data_bd;
     	struct eth_tx_1st_bd	*first_bd;
     	int			nbds = 0;

    @@ -2959,7 +2959,7 @@ qlnx_free_tx_pkt(qlnx_host_t *ha, struct qlnx_fastpath *fp,
     //	BD_SET_UNMAP_ADDR_LEN(first_bd, 0, 0);

     	for (i = 1; i < nbds; i++) {
    -		tx_data_bd = ecore_chain_consume(&txq->tx_pbl);
    +		/* tx_data_bd = */ ecore_chain_consume(&txq->tx_pbl);
     //		BD_SET_UNMAP_ADDR_LEN(tx_data_bd, 0, 0);
     	}
     	txq->sw_tx_ring[idx].flags = 0;