From nobody Tue Apr 05 04:32:57 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E65BF1A9300F; Tue, 5 Apr 2022 04:32:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KXZWZ39Lqz4gbh; Tue, 5 Apr 2022 04:32:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649133178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1M1f80H6l++twWg00XdapH1bLCA/xW2VvkAHDLKprnc=; b=F+2LqHdzZq3yMCgnd+NotN+jNDmSk1tmYBPunk/0iDHB5V+GSYB4Ee8ins/V72PTQVD1fE diDQsIlRXWSVhf7Q5g+VDrMb3PVAOOx3X/ZG8Vazyy4bX6Cx0y2Yx+lwcD+crpXbDwpQte Sn1X2gCH7IrkVlE8tMcJFsTCs6wUKQ2l6etzIY4Q7oZDOUJMOMJz6YHzQVMe3SmhXxQkG+ ZxR9mgDcjsUDT4mVcwzhwXJ0lyKcI4/YaPutDFmbb7UORyTBM+aXn9T4Wgz8xig7Zbc21+ FuCGegYmY6NvvWdFvHmFTv9FdIhPD/YfcxlrTxhN2kdd7XhXbZKP9s7+m/GNAw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D08B11FC26; Tue, 5 Apr 2022 04:32:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2354WvH9009695; Tue, 5 Apr 2022 04:32:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2354Wv3L009694; Tue, 5 Apr 2022 04:32:57 GMT (envelope-from git) Date: Tue, 5 Apr 2022 04:32:57 GMT Message-Id: <202204050432.2354Wv3L009694@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: c972f2c065bd - main - xl_attach: eliminate write only variable unit List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c972f2c065bdb7031e7935aac406365e4810df19 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649133178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1M1f80H6l++twWg00XdapH1bLCA/xW2VvkAHDLKprnc=; b=kbjpsAeZ6kLNotYdagCSMi5XAiJxPDodk9H003/kIVuxye9K46A1FLjGp5RjOubTCFLLQe 95VHdTWBtVgbubPGvSNDQFttPvBboPcckq+iwZyME6ujXYYDwWl1wphtENxX7eG032s7rl tV/tqzb61nX5C1NEDM1eolO1JjkRxksrEMkIJrl555wnTNuu4sBwqJa50l/mBXdwN3/r1Y E8/ZfxffLDAHrfWiCIbR8+9gjGPoqI5/R3hHtpzmso7+OC7HKhD7vi6VYwueloZsiQ9AEb hCzIDUxgtmt0Hr7rPTj/nTwFFSrNP4bKUHCsI0/caNEZ5aZY6q44z/coVXcntA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649133178; a=rsa-sha256; cv=none; b=sIryjxF483awX7NAVmJpVpU3hKQ+Lxwl1N6Jl7yKu7gctHI3xoPXCx814mBTLFNsWxU595 PE8AE0eb/acXBw2gZzTm4ApLwA5Y+SpZ13MfyVtowPelN4k/ow+ewtwPCZNwqA8RwHExo+ 33UiRyU+k6FiVzpz8tJwjrMpcfbSVl8FMNKvuZ2XRP42VRg4Rg80fIIDhuvJYMAZea41Uy 6mDQ3pr2MfxNHLeSOWhaZ8+tHhhARUS1ikpSk2ONhxoYSqLxRyNjXd6E0rq08hOUva1bKT 6KxZsfSgmgRuVKlEFhnNZV4QeXddgRlcUzXj+drWz4BZYzbaA53BSY0b936pDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=c972f2c065bdb7031e7935aac406365e4810df19 commit c972f2c065bdb7031e7935aac406365e4810df19 Author: Warner Losh AuthorDate: 2022-04-05 02:33:25 +0000 Commit: Warner Losh CommitDate: 2022-04-05 04:30:45 +0000 xl_attach: eliminate write only variable unit Sponsored by: Netflix --- sys/dev/xl/if_xl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/xl/if_xl.c b/sys/dev/xl/if_xl.c index ca6184758815..ae4d9fb8f5ff 100644 --- a/sys/dev/xl/if_xl.c +++ b/sys/dev/xl/if_xl.c @@ -1069,14 +1069,12 @@ xl_attach(device_t dev) struct xl_softc *sc; struct ifnet *ifp; int media, pmcap; - int error = 0, phy, rid, res, unit; + int error = 0, phy, rid, res; uint16_t did; sc = device_get_softc(dev); sc->xl_dev = dev; - unit = device_get_unit(dev); - mtx_init(&sc->xl_mtx, device_get_nameunit(dev), MTX_NETWORK_LOCK, MTX_DEF); ifmedia_init(&sc->ifmedia, 0, xl_ifmedia_upd, xl_ifmedia_sts);