git: 0f3163162003 - main - sctp: remove a test, which isn't safe
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 02 Apr 2022 13:40:09 UTC
The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0f316316200386986de7ac72cf717c13b28f387e commit 0f316316200386986de7ac72cf717c13b28f387e Author: Michael Tuexen <tuexen@FreeBSD.org> AuthorDate: 2022-04-02 13:09:50 +0000 Commit: Michael Tuexen <tuexen@FreeBSD.org> CommitDate: 2022-04-02 13:09:50 +0000 sctp: remove a test, which isn't safe We can't ensure the stcb is still around. This issue was found by syzkaller. MFC after: 3 days --- sys/netinet/sctp_output.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/netinet/sctp_output.c b/sys/netinet/sctp_output.c index 5f205b1c3af4..4ef771b0cc1a 100644 --- a/sys/netinet/sctp_output.c +++ b/sys/netinet/sctp_output.c @@ -13657,11 +13657,6 @@ out_unlocked: if (free_cnt_applied) { atomic_subtract_int(&asoc->refcnt, 1); } -#ifdef INVARIANTS - if (mtx_owned(&stcb->tcb_mtx)) { - panic("Leaving with tcb mtx owned?"); - } -#endif } if (top != NULL) { sctp_m_freem(top);