From nobody Thu Oct 28 15:45:36 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 53AA11836F3E; Thu, 28 Oct 2021 15:45:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hg8z56XCBz4hb1; Thu, 28 Oct 2021 15:45:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 3C8E19133; Thu, 28 Oct 2021 15:45:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 62d2dcafb7f3 - main - if_epair: delete mbuf tags To: Kristof Provost , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202110280850.19S8ocCH079483@gitrepo.freebsd.org> From: John Baldwin Message-ID: <451456f3-6a1f-78b3-4c34-01c6cf681cd0@FreeBSD.org> Date: Thu, 28 Oct 2021 08:45:36 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: <202110280850.19S8ocCH079483@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 10/28/21 1:50 AM, Kristof Provost wrote: > The branch main has been updated by kp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=62d2dcafb7f33fe8f47e9d5dd519d665f7af140e > > commit 62d2dcafb7f33fe8f47e9d5dd519d665f7af140e > Author: Kristof Provost > AuthorDate: 2021-10-26 07:57:56 +0000 > Commit: Kristof Provost > CommitDate: 2021-10-28 08:41:16 +0000 > > if_epair: delete mbuf tags > > Remove all (non-persistent) tags when we transmit a packet. Real network > interfaces do not carry any tags either, and leaving tags attached can > produce unexpected results. > > Reviewed by: bz, glebius > MFC after: 3 weeks > Sponsored by: Rubicon Communications, LLC ("Netgate") > Differential Revision: https://reviews.freebsd.org/D32663 Wireguard has similar functionality FWIW, so it might be worth exposing a generic "mb_free_tags". Wireguard also tries to reset some other state like the status of checksum offload since it is moving mbufs between an ifnet and a socket. Not sure if epair also needs to clear all the same things? -- John Baldwin