From nobody Tue Oct 26 21:04:44 2021
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E9A211826F28;
	Tue, 26 Oct 2021 21:05:05 +0000 (UTC)
	(envelope-from carpeddiem@gmail.com)
Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4Hf48d6Gnmz3hyV;
	Tue, 26 Oct 2021 21:05:05 +0000 (UTC)
	(envelope-from carpeddiem@gmail.com)
Received: by mail-io1-f49.google.com with SMTP id d63so1041877iof.4;
        Tue, 26 Oct 2021 14:05:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=g7kvhccdP2pszWsa7QmhJmxmHSn/69lLW598mHcdB3w=;
        b=jpW+nqnIluqrKMvqkXK6MsMIT6mPEQqW+rh0+AMfCPfAbP0lPUwBGRgAZOMxd2yU/P
         ez8nhPNWEJGN6U75spc6/R6KYr7d6ciXyrgWrdp4olx5t/w2BAo9kNAcp9BQx+OeNtfO
         baOs0v5Q4K0wKxDm6OFqjmjcRzGBm9UfaBgytrvA6b9Z/W/FikDnNJeea4OgiCGAM8xy
         +wM8Qend6nGAwgQHxTc1zqZcRDFmffGhJk4OM4iRFe2WtM7r9JoDx3yYs+yGvC7BluAw
         6qUqhsy7qXcSVbiar+Vqllj4YvdeGhnIxSitrw2SxaX4VGmrlVsPm/lPZqCyNcVOI1HF
         Sb2Q==
X-Gm-Message-State: AOAM533R2u9nc7/RRos47eXNZwxnfm+dj0lYnk8lG/uCIg20cyQW8u2q
	+GYN10ONyIQkR60HS640aiPYPUhiuMLFBHxzkesD6AZ8
X-Google-Smtp-Source: ABdhPJynHa4LF7ziXvq12wJRldnQhHkFZ0RdLzBEmHijvrzJN7PAM2xBIAj9uA7Vozcxtm1hIyEte1mxdPVUyltAHdg=
X-Received: by 2002:a05:6638:2410:: with SMTP id z16mr17507615jat.76.1635282298340;
 Tue, 26 Oct 2021 14:04:58 -0700 (PDT)
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
References: <202110230000.19N00JIK052888@gitrepo.freebsd.org> <YXhq9IHpMdoKQ5N+@server.rulingia.com>
In-Reply-To: <YXhq9IHpMdoKQ5N+@server.rulingia.com>
From: Ed Maste <emaste@freebsd.org>
Date: Tue, 26 Oct 2021 17:04:44 -0400
Message-ID: <CAPyFy2BWcrS03ySELvjiB4MpxbWEW8+oN1KOqbw=hWo6BYwAGA@mail.gmail.com>
Subject: Re: git: 7b1e19ad78c6 - main - Add libfido2 to the build
To: Peter Jeremy <peter@rulingia.com>
Cc: src-committers <src-committers@freebsd.org>, 
	"<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Rspamd-Queue-Id: 4Hf48d6Gnmz3hyV
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-ThisMailContainsUnwantedMimeParts: N

On Tue, 26 Oct 2021 at 16:54, Peter Jeremy <peter@rulingia.com> wrote:
>
> This triggered build failures on two of my hosts:
>
> The first problem is that libfido2 is always built but has hard
> dependencies on <dev/usb/usb_ioctl.h> and <dev/usb/usbhid.h>.  The latter
> two headers are optionally installed based on "WITHOUT_USB".  I worked
> around it by removing WITHOUT_USB but I'm not sure of the best general
> solution here - making libfido2 optional would make the SSH integration
> more complex.

Thanks for the report. I think we can always build ssh-sk-helper, but
have it use internal support only when MK_USB is true. This should
simplify the integration.