From nobody Tue Oct 26 15:32:08 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4A5A3182F2EE for ; Tue, 26 Oct 2021 15:32:17 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2q.ore.mailhop.org (outbound2q.ore.mailhop.org [54.187.71.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hdwmc6jzHz4gbJ for ; Tue, 26 Oct 2021 15:32:16 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1635262330; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=uB19c58GPvwrmlIny4Er4C8JZG/nM/nTzZzLSQ2JaIF8OGA4DNR0Wt0id7r0IIbDxj4sAuLqUnbG2 PTYLboRzFM5yNVE960aUG6ZGmj781Zh489FYaBmz5QEzEJDpRM47TM1zfUPc0YoM/JHgAsHWn6OXNF x3xNrzeGAlzMlwZPlf/sB5seL/AYUvZRJM86xH/t+BRPnclPaTmN0D4jB7azta9B7jdDLBCOQZYtjX Z62SDJDTUTjjPVnX59+aC/d0VT2LTmUldw6IaN7kUvY0V95YrHDrcd5I7YhieBn0mPjkI5ASPlfSV1 QMmZlVoJMTL78lAb7PcsqTFNhIUSlSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=kHp+/AgMnjXQKao+/n8p1lIkkn2C5jObzK8/isesJuo=; b=e1dZrXkmyEZIEPRhorrBsbj8bAyYAlEwWvTAdeHLwP0w8YflZDXVMtngVDIoDW8PJpdICJFBt1ogV LhKQrwHdoFKlVVbQBeltvP5hKZPlFlDkcy91ottZVgZhy3FDc4/l8goOaEi5MB6NNN7w7XmHXNJAl5 iRAvlCVmSLJs4fC+6KIG/1FTtFMomG0mi+Jkdl4xCUo89HP7eQDIbaBh0Qp8aeyqcdkmmzBspnovRH MdJzOs8sux5lbt3DJM7stwGvXozILDQc7xED85wXnODXiQqoUQAv8mTOLB3IfPDwIdwU+j2IPbB4VM pQ59K9odqFiWosqgrnQOiWNr3DLMOIw== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=24.8.225.114; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=kHp+/AgMnjXQKao+/n8p1lIkkn2C5jObzK8/isesJuo=; b=ws1jSO2sG+gmllyuGgLcACAqIkOUCf5qAdWkh/br7sbtsYeVv14tip6EfwnZOQ0tM8ZWIgSjJuxcd RZgPLNThWVL83f1+/R4G6kN9iHFuapdvdglspm+p/borfh2Ok30ar1FF2u2SF6nI7lNBk0/Dcx5Muz LMIuWZJDggo/b9UyhuLOeXsJoOPTxQ5PJxYKg6fVa2Qtc6kodCA3t+RW9+a9kbVphyvrJEq21qv6Jx hKVsraK6DfrZNjA7DWpz+tplhqa75rjUIkhpX4xVXb/30/tcoH0X51HdwKnujAdj5ATShYlC2hZzup 8zdUSx7tAUeSw+G8DfBGpsTCaPhw7jQ== X-Originating-IP: 24.8.225.114 X-MHO-RoutePath: aGlwcGll X-MHO-User: e1bebaea-3671-11ec-a67c-89389772cfc7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-24-8-225-114.hsd1.co.comcast.net [24.8.225.114]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id e1bebaea-3671-11ec-a67c-89389772cfc7; Tue, 26 Oct 2021 15:32:09 +0000 (UTC) Received: from [172.22.42.84] (rev2.hippie.lan [172.22.42.84]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 19QFW86v001129; Tue, 26 Oct 2021 09:32:08 -0600 (MDT) (envelope-from ian@freebsd.org) X-Authentication-Warning: paranoia.hippie.lan: Host rev2.hippie.lan [172.22.42.84] claimed to be [172.22.42.84] Message-ID: <57f6f877de121954935225fba9874a39b6b768c4.camel@freebsd.org> Subject: Re: git: fcfa64801a4f - main - sh: Set PATH envvar after setting HOME in dotfile From: Ian Lepore To: Ka Ho Ng , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Date: Tue, 26 Oct 2021 09:32:08 -0600 In-Reply-To: <202110261450.19QEoMqo020433@gitrepo.freebsd.org> References: <202110261450.19QEoMqo020433@gitrepo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.3 FreeBSD GNOME Team List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Hdwmc6jzHz4gbJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, 2021-10-26 at 14:50 +0000, Ka Ho Ng wrote: > The branch main has been updated by khng: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=fcfa64801a4fe836ff481465ea068e791aa4ce6a > > commit fcfa64801a4fe836ff481465ea068e791aa4ce6a > Author:     Ka Ho Ng > AuthorDate: 2021-10-26 14:48:57 +0000 > Commit:     Ka Ho Ng > CommitDate: 2021-10-26 14:50:09 +0000 > >     sh: Set PATH envvar after setting HOME in dotfile >     >     In single-user mode, all env vars are absent, so exptilde() would > not be >     able to expand ~ correctly. >     Place the lines setting PATH below HOME, so exptilde() would work > as >     expected. >     >     Sponsored by:   The FreeBSD Foundation >     MFC after:      3 days >     Reviewed by:    jilles, emaste >     Differential Revision:  https://reviews.freebsd.org/D27003 > --- >  bin/sh/dot.profile | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bin/sh/dot.profile b/bin/sh/dot.profile > index fd0c43fdb927..e296a360bcc7 100644 > --- a/bin/sh/dot.profile > +++ b/bin/sh/dot.profile > @@ -1,9 +1,9 @@ >  # $FreeBSD$ >  # > - > PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:~/bi > n > -export PATH >  HOME=/root >  export HOME > +PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:~/ > bin > +export PATH >  TERM=${TERM:-xterm} >  export TERM >  PAGER=less I've always been curious whether there's a reason we seem to favor VAR=value export VAR over the more compact form export VAR=value -- Ian