From nobody Mon Oct 18 20:15:50 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 67B4417F8117; Mon, 18 Oct 2021 20:15:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HY7RX2NKjz3M7x; Mon, 18 Oct 2021 20:15:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id A171A254DA; Mon, 18 Oct 2021 20:15:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 7881db834647 - main - Remove POWER_PM_TYPE_APM. It's now unused. To: Warner Losh Cc: Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202110181445.19IEj36g019473@gitrepo.freebsd.org> From: John Baldwin Message-ID: Date: Mon, 18 Oct 2021 13:15:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 10/18/21 9:50 AM, Warner Losh wrote: > On Mon, Oct 18, 2021 at 10:37 AM John Baldwin wrote: > >> On 10/18/21 7:45 AM, Warner Losh wrote: >>> The branch main has been updated by imp: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=7881db83464759ba783454d2d2eb1b970e352cd3 >>> >>> commit 7881db83464759ba783454d2d2eb1b970e352cd3 >>> Author: Warner Losh >>> AuthorDate: 2021-10-18 14:41:17 +0000 >>> Commit: Warner Losh >>> CommitDate: 2021-10-18 14:41:17 +0000 >>> >>> Remove POWER_PM_TYPE_APM. It's now unused. >>> >>> Sponsored by: Netflix >>> Reviewed by: markj >>> Differential Revision: https://reviews.freebsd.org/D32549 >>> --- >>> sys/sys/power.h | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/sys/sys/power.h b/sys/sys/power.h >>> index 524bc3fabb24..b0535312d1f7 100644 >>> --- a/sys/sys/power.h >>> +++ b/sys/sys/power.h >>> @@ -34,7 +34,6 @@ >>> #include >>> >>> /* Power management system type */ >>> -#define POWER_PM_TYPE_APM 0x00 >>> #define POWER_PM_TYPE_ACPI 0x01 >>> #define POWER_PM_TYPE_NONE 0xff >> >> Do we want to leave a comment that 0x00 was previously used? I don't know >> if we ever >> exposed this value to userland as part of any ABI? >> > > Good question, but I believe the answer is no. > > power_pm_type is static in sys/kern/subr_power.c. It's only exported from > that module > with power_pm_get_type(). This is only called from acpi.c to make decisions > about > whether or not to load, attach, or identify devices. There's also no sysctl > that publish > this, nor is this value used in userland in base. The whole sys/power.h > file has the look > of an internal kernel file because there's no #ifdef _KERNEL section around > all the > prototypes it defines. > > Have I missed something? No, that sounds about right. -- John Baldwin