From nobody Mon Oct 18 20:14:24 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F3AD917F7759 for ; Mon, 18 Oct 2021 20:14:31 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HY7Pz6Rtxz3LkV for ; Mon, 18 Oct 2021 20:14:31 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f53.google.com with SMTP id t2so43578076wrb.8 for ; Mon, 18 Oct 2021 13:14:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yFHswOQIa+gczhwdN8rjXNDvURoC7ilhOQhfss62qjQ=; b=FQ6VfoXUO6IEClyOsSM9YgxJFA1ad/pN5y1BocBwBdFKA22hXZey63YgWAeWc3RsMo hp0VJKZy8UarkY/i5ZWqe72mz2ajza9RxJfIpApmgrBjPONa8E716C5HVdoVTH+qQZJv vwvxBkFf/Q+R9ae0k3HJrbDRMJfh4P4ZdgmELPhT8+4CQJ84mFWcP16/HEL41W+Wfxk/ STg+V/CYVqzl+p32xmmJlHd7WRxAgYtMR2WO1oRYGcAXyO0o0ViX583WQGaJCl8fxJrR Ky2B1980C1wkqVQjmPIU1XE6NO96C+ImaF9aPLg4Rl8vsqruBlDNdl0mTXUGby6oKMBu ozwQ== X-Gm-Message-State: AOAM533isxveGhdpwMzJBDCadIxlNQaqiM5FbGe5k+g0zEkoGHNj0x5r dVJ/UL/D9c0oS+4stRJzAXANjQ== X-Google-Smtp-Source: ABdhPJy2zzdTAgWUefwkH2k24benHogmGzlya9opOe8970OM+WaPiYptivEtm+8xO4UpwR7P1rR0zA== X-Received: by 2002:a5d:59a3:: with SMTP id p3mr38828102wrr.146.1634588065047; Mon, 18 Oct 2021 13:14:25 -0700 (PDT) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id w5sm13197045wra.87.2021.10.18.13.14.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Oct 2021 13:14:24 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: 8398d52d6541 - main - arm: print out the undefined instruction upon an undefined instruction panic From: Jessica Clarke In-Reply-To: <202110181919.19IJJHws080182@gitrepo.freebsd.org> Date: Mon, 18 Oct 2021 21:14:24 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202110181919.19IJJHws080182@gitrepo.freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4HY7Pz6Rtxz3LkV X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 18 Oct 2021, at 20:19, Adrian Chadd wrote: >=20 > The branch main has been updated by adrian: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8398d52d6541d316fcd88c856b5a72bb= 9cce0534 >=20 > commit 8398d52d6541d316fcd88c856b5a72bb9cce0534 > Author: Adrian Chadd > AuthorDate: 2021-10-16 03:15:15 +0000 > Commit: Adrian Chadd > CommitDate: 2021-10-18 19:18:52 +0000 >=20 > arm: print out the undefined instruction upon an undefined = instruction panic >=20 > It's SUPER useful to be able to see the actual undefined = instruction > when we hit said undefined instruction. > --- > sys/arm/arm/undefined.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/sys/arm/arm/undefined.c b/sys/arm/arm/undefined.c > index ef9e72c89163..4e9a5295d338 100644 > --- a/sys/arm/arm/undefined.c > +++ b/sys/arm/arm/undefined.c > @@ -341,7 +341,8 @@ undefinedinstruction(struct trapframe *frame) > return; > } > else > - panic("Undefined instruction in kernel.\n"); > + panic("Undefined instruction in kernel = (0x%08x).\n", > + fault_instruction); As I said in the review, printing this without the PSR_T bit in SPSR isn=E2=80=99t all that helpful, you can=E2=80=99t decode it without = knowing what SPSR is (though you may be able to guess by seeing whether one decoding is total junk and the other might plausibly trap). Jess