From nobody Mon Oct 18 16:50:36 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0F4961804731 for ; Mon, 18 Oct 2021 16:50:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HY2tv5L3Fz4mYh for ; Mon, 18 Oct 2021 16:50:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92b.google.com with SMTP id h19so3262569uax.5 for ; Mon, 18 Oct 2021 09:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F8mO1182pyGjT9F2hZrNvrjWBm77zaBl9dQWHTXWexo=; b=f1/lHuBvxESqBnCEouWUB6h3IpBgWarrMeC9jFAUhzgN//86JsD7YCUtf/RoxAnxsx mxyI54iazmCoHW1F3iyyeKt2Be0CTrvLHJ6dJD+DztxdVBuZ7x3ZgNyCPFyk7ykkBqtG dM4Dl5gV6GNDWpwqmr4nzhLjIzu7/hgdLCRh0ADIP5X0m/O5vvYlJ6fcAZfBiDWV1+Gg 7QawG5Asijx/JP+BLfUelYAqqjs+kENSO/SO1HOsOjk7KxSNlY37r2LxYSGHEWBZOt3U Yi/85ouc9ftPX2/ECx2GiSSWL7VaBa3mTzFX/Dk9yBGLOSJB+Qhl7c2fakzAilF1JZD0 0Q3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F8mO1182pyGjT9F2hZrNvrjWBm77zaBl9dQWHTXWexo=; b=cGD1Sn7qjMds6BBojCOpgZ7cbNTD4Ga5PRZGFfKSEytLKfAH8W5Vtf7BxqPQRiETVG xGKfbX8wKq643y7yYGUCeL8XfluRZIBoBCmGLLnjj3/QvAy0BT1JTN1wk56wDWWTwIC2 nhcEJCtoabbVhHQ6ZQciB+AJD/0UDj42At/1tOQVCaXb9rnhaJ6cNFHSI0PZrhksJxG3 EI28ItflOV/trNx1s7zhwgMbvO933j43M9Qda7qQKPiA3/QHLsCqiQuI26Q1ZDORVTcx zaZ5yvLnUcYVJhdE5w8awk9GVfGV/YPTYX3wTzQIq/TndW7WmHqWUnhzfaHkVZtohtVd D3ng== X-Gm-Message-State: AOAM530/qucd8fO8YQMvZJAHZ0m3kdh9aX+YLOySB2MI3vhKqK7e+YZQ LzsaKOjKTDMMbGpp3tvy0cXqxQwY21S3mEOLd6wZax9duE9kog== X-Google-Smtp-Source: ABdhPJyb45XpOiveGyj6y6giFEFfNAb00qVzS2Q+1MDOrJobH5DYED/U2kuLYKKFjXFlm+4Gy04SPcWZCWTPINAvWsk= X-Received: by 2002:a67:c903:: with SMTP id w3mr28994375vsk.6.1634575847119; Mon, 18 Oct 2021 09:50:47 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202110181445.19IEj36g019473@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 18 Oct 2021 10:50:36 -0600 Message-ID: Subject: Re: git: 7881db834647 - main - Remove POWER_PM_TYPE_APM. It's now unused. To: John Baldwin Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b9f10e05cea358cf" X-Rspamd-Queue-Id: 4HY2tv5L3Fz4mYh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000b9f10e05cea358cf Content-Type: text/plain; charset="UTF-8" On Mon, Oct 18, 2021 at 10:37 AM John Baldwin wrote: > On 10/18/21 7:45 AM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7881db83464759ba783454d2d2eb1b970e352cd3 > > > > commit 7881db83464759ba783454d2d2eb1b970e352cd3 > > Author: Warner Losh > > AuthorDate: 2021-10-18 14:41:17 +0000 > > Commit: Warner Losh > > CommitDate: 2021-10-18 14:41:17 +0000 > > > > Remove POWER_PM_TYPE_APM. It's now unused. > > > > Sponsored by: Netflix > > Reviewed by: markj > > Differential Revision: https://reviews.freebsd.org/D32549 > > --- > > sys/sys/power.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/sys/sys/power.h b/sys/sys/power.h > > index 524bc3fabb24..b0535312d1f7 100644 > > --- a/sys/sys/power.h > > +++ b/sys/sys/power.h > > @@ -34,7 +34,6 @@ > > #include > > > > /* Power management system type */ > > -#define POWER_PM_TYPE_APM 0x00 > > #define POWER_PM_TYPE_ACPI 0x01 > > #define POWER_PM_TYPE_NONE 0xff > > Do we want to leave a comment that 0x00 was previously used? I don't know > if we ever > exposed this value to userland as part of any ABI? > Good question, but I believe the answer is no. power_pm_type is static in sys/kern/subr_power.c. It's only exported from that module with power_pm_get_type(). This is only called from acpi.c to make decisions about whether or not to load, attach, or identify devices. There's also no sysctl that publish this, nor is this value used in userland in base. The whole sys/power.h file has the look of an internal kernel file because there's no #ifdef _KERNEL section around all the prototypes it defines. Have I missed something? Warner --000000000000b9f10e05cea358cf--