Re: git: c05b382edb17 - main - Revert "bootstrap: No need to disable shared libraries for bootstrap tools"
- Reply: Gleb Smirnoff : "Re: git: c05b382edb17 - main - Revert "bootstrap: No need to disable shared libraries for bootstrap tools""
- In reply to: Warner Losh : "git: c05b382edb17 - main - Revert "bootstrap: No need to disable shared libraries for bootstrap tools""
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 11 Oct 2021 18:01:11 UTC
On Mon, Oct 11, 2021 at 05:54:24PM +0000, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c05b382edb173d199ddef86976d594fbbb7bbf24 > > commit c05b382edb173d199ddef86976d594fbbb7bbf24 > Author: Warner Losh <imp@FreeBSD.org> > AuthorDate: 2021-10-11 17:49:48 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2021-10-11 17:49:48 +0000 > > Revert "bootstrap: No need to disable shared libraries for bootstrap tools" > > This reverts commit e8f26e5dc859a8fbc663e108421f657325ca3054. > > Although the change worked locally, it's breaking something in the CI > build for the riscv64 build (which makes no sense it would only break > that since we're building host tools to bootstrap at that point). This also seems to have broken syzbot's FreeBSD CI builds, which run "make kernel-toolchain -DNO_CLEAN" before building a kernel: https://syzkaller.appspot.com/text?tag=CrashLog&x=10b4cb98b00000 I wasn't sure if the reverted commit might be tripped up by -DNO_CLEAN, so I was about to submit a syzkaller change to automatically try a clean build after a failing -DNO_CLEAN build. The build host is also quite old, running some stable/12 revision from a couple of years ago. > Sponsored by: Netflix > --- > Makefile.inc1 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index fb640eefdb82..9b81d4029608 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -720,6 +720,7 @@ BSARGS= DESTDIR= \ > -DNO_CPU_CFLAGS \ > -DNO_LINT \ > -DNO_PIC \ > + -DNO_SHARED \ > MK_ASAN=no \ > MK_CTF=no \ > MK_CLANG_EXTRAS=no \