From nobody Tue Oct 05 19:54:58 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 770149F6F09; Tue, 5 Oct 2021 19:55:00 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HP7bS2ghYz4t9p; Tue, 5 Oct 2021 19:55:00 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-qt1-x82f.google.com with SMTP id a13so243984qtw.10; Tue, 05 Oct 2021 12:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jWUvMJrec6y9v/FlMG7eOxxsUlORFgk9UScwaVnTwKo=; b=ci8rdLxCPrbdmip43AYthI9zKZsujxKJytS3/gUBhiqMG0TuLn/TvPYHpSCAY7G7LM zCGBgjuvupQ6SgTQ4SZ5dyo3ANMzS5YPpWy3Lke1wxb4gJvD4vBPFwedmu0XdIDzbM9K odmmg+s4jYbiMWf4ilrFxxZ/jge31uIAqFmtx4ViwOnXAmuW53IRC7LA7m8I/SEL4c2z 85K4artOwEu98oLmJUuYhvQ2I+avY95LyOkB5ZWtnS8+v6EdVwb4LU0Vw0GEfQSb3H3x 9g0UjshuNQqYJO7TgOMXwKgdDRG7CqfqAGJRByDlQ4jO3mjSyeTlO+I5wgy8kvnqzM+U Q/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jWUvMJrec6y9v/FlMG7eOxxsUlORFgk9UScwaVnTwKo=; b=aTnzTvFgDztFF1h5PcAKUEPZvppYeID3MLqwSlxbxiKMNbYE6afXD9+xGgndwcyN3W oqbtkY+EJpextzdY6crsON+rWpgRf1pLDj+y0wVDP4PfbIoEIQGMBoCh5QyIhElG+2BX 93wOoI3aeMlYAf4ViEIzHIu2/8g/biFoYfnmfV93yL4jYSS3iIUq+C8DPuwsdWHEspD1 riULIFmtPcbY5wNxhdDSLVQUWTb0g+YBWfBNogR2KCz7Dkg6QECry+0qjxr1vKdQOLHo Q5KNfCQY9VIf/XgbjBlDk+rYdocdFVaaUop0lN9KQDPZJk4gOCfT5c8YopAT416teIoo LtEg== X-Gm-Message-State: AOAM531dRb+nzcggDLdHiIjejA7U+WB5C2GhO78vtaz2/EIK2y61Kr5v rLA1VZvWa8pG/o6Fdvj4yf5Fr4sjVyg= X-Google-Smtp-Source: ABdhPJyMpWkNkgz5aCtfgWoJjlr1NtUwLEmzlXu5MuWrHqPavTzmGqnNzT3DTWpZx5tL+1ItVCqdxg== X-Received: by 2002:ac8:c9:: with SMTP id d9mr8841641qtg.189.1633463699565; Tue, 05 Oct 2021 12:54:59 -0700 (PDT) Received: from mavoffice.ixsystems.com ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id k10sm10213395qkk.124.2021.10.05.12.54.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 12:54:58 -0700 (PDT) Sender: Alexander Motin Subject: Re: git: 730ea72c706e - main - cam(4): Limit search for disks in SES enclosure by single bus To: Alan Somers Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202110051904.195J48iO062191@gitrepo.freebsd.org> From: Alexander Motin Message-ID: <99fe068a-356c-7d58-8c70-6ecdf504ab25@FreeBSD.org> Date: Tue, 5 Oct 2021 15:54:58 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4HP7bS2ghYz4t9p X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 05.10.2021 15:48, Alan Somers wrote: > On Tue, Oct 5, 2021 at 1:41 PM Alexander Motin wrote: >> >> On 05.10.2021 15:14, Alan Somers wrote: >>> On Tue, Oct 5, 2021 at 1:04 PM Alexander Motin wrote: >>>> >>>> The branch main has been updated by mav: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=730ea72c706ef8e025616772cfd86fd89ed3d42e >>>> >>>> commit 730ea72c706ef8e025616772cfd86fd89ed3d42e >>>> Author: Alexander Motin >>>> AuthorDate: 2021-10-05 19:01:16 +0000 >>>> Commit: Alexander Motin >>>> CommitDate: 2021-10-05 19:01:16 +0000 >>>> >>>> cam(4): Limit search for disks in SES enclosure by single bus >>>> >>>> At least for SAS that we only support now disks are typically >>>> connected to the same bus as the enclosure. Limiting the search >>>> scope makes it much faster on systems with multiple buses and >>>> thousands of disks. >>>> >>>> Reviewed by: imp >>>> MFC after: 2 weeks >>>> Sponsored by: iXsystems, Inc. >>>> Differential Revision: https://reviews.freebsd.org/D32305 >>>> --- >>>> sys/cam/scsi/scsi_enc_ses.c | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/sys/cam/scsi/scsi_enc_ses.c b/sys/cam/scsi/scsi_enc_ses.c >>> >>> >>> Sounds juicy. Do you have any benchmarks? >> >> I don't think we've benchmarked that system with payload yet, if that is >> what you mean, polishing usability. But I don't think there can be too >> much interesting, since big speeds don't require so many HDDs these >> days, but much smaller number of SSDs instead. This particular system >> is about capacity -- ~20PiB raw on 1248 disks in one ZFS pool. :) > > 1248 disks? That's huge. But I'm not asking about throughput. Your > commit message said "much faster". What operation is "much faster"? > Enumerating disks at startup? That would be useful. I don't think you notice the difference on startup, too many other things going on, but during idle it reduces periodic CPU load spikes by enc_daemon processes by several times, proportionally to the number of HBAs/buses. More annoyance than a real problem though. -- Alexander Motin