From nobody Tue Oct 05 19:48:27 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 064329F5DF5; Tue, 5 Oct 2021 19:48:39 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HP7S66SyFz4sFp; Tue, 5 Oct 2021 19:48:38 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f171.google.com with SMTP id a3so792010oid.6; Tue, 05 Oct 2021 12:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9dLaoF7wO7yb0F5ctYjRn2FuWRqUaXfiU3GRRWIA/Bc=; b=nOjXgOe+OO0g+u+phsRB+fn2gq8ZpAgFtuL4WF1eUU4BbVJW248avu3Ytl76VPmib4 ekAQok/9AT68Eem5YPSDRJ6S/U2BsRKnmWZIWnnegFfWLS1ClIoJZWeQ4+72tbV7gEKA bdsmpFUiPoprSM/dfEE5CHnAYYZnEiRCaJKPa8s8uEN71hyWmO1uimG/40Z3qFbHtIqI jvXhMVpj7nHDnzxT7kHTIGMhsG85JP1fsk36TonHIYW6JbYPNbk/1KXl9QbsJVvDSKdw SxbZNHmlOaNgbtnLZYoKLfLhLNv61fL4TseaZ+R+EnCuskSk7kZVi8hQ+rKObh/rUPrL EsXg== X-Gm-Message-State: AOAM531E7auDQScJ+iCeFKsWx0gItPOHaix+7GlVY/yI7k2slOvYTAA6 GsW3TxIBmg8FLDgiHQ2kHvxAWNuSADNDmA1Jqj8bz35h X-Google-Smtp-Source: ABdhPJzCpBIUYYUJJTsyJ4WfpfLwNQpQZMiESG5JOC1GD4evyEvUkwXuCF5f30HA/06cdWt0CxZRqFpBxcYN5uO7aIc= X-Received: by 2002:a54:4e94:: with SMTP id c20mr4012418oiy.57.1633463318145; Tue, 05 Oct 2021 12:48:38 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202110051904.195J48iO062191@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Tue, 5 Oct 2021 13:48:27 -0600 Message-ID: Subject: Re: git: 730ea72c706e - main - cam(4): Limit search for disks in SES enclosure by single bus To: Alexander Motin Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4HP7S66SyFz4sFp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, Oct 5, 2021 at 1:41 PM Alexander Motin wrote: > > On 05.10.2021 15:14, Alan Somers wrote: > > On Tue, Oct 5, 2021 at 1:04 PM Alexander Motin wrote: > >> > >> The branch main has been updated by mav: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=730ea72c706ef8e025616772cfd86fd89ed3d42e > >> > >> commit 730ea72c706ef8e025616772cfd86fd89ed3d42e > >> Author: Alexander Motin > >> AuthorDate: 2021-10-05 19:01:16 +0000 > >> Commit: Alexander Motin > >> CommitDate: 2021-10-05 19:01:16 +0000 > >> > >> cam(4): Limit search for disks in SES enclosure by single bus > >> > >> At least for SAS that we only support now disks are typically > >> connected to the same bus as the enclosure. Limiting the search > >> scope makes it much faster on systems with multiple buses and > >> thousands of disks. > >> > >> Reviewed by: imp > >> MFC after: 2 weeks > >> Sponsored by: iXsystems, Inc. > >> Differential Revision: https://reviews.freebsd.org/D32305 > >> --- > >> sys/cam/scsi/scsi_enc_ses.c | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/sys/cam/scsi/scsi_enc_ses.c b/sys/cam/scsi/scsi_enc_ses.c > > > > > > Sounds juicy. Do you have any benchmarks? > > I don't think we've benchmarked that system with payload yet, if that is > what you mean, polishing usability. But I don't think there can be too > much interesting, since big speeds don't require so many HDDs these > days, but much smaller number of SSDs instead. This particular system > is about capacity -- ~20PiB raw on 1248 disks in one ZFS pool. :) > > -- > Alexander Motin 1248 disks? That's huge. But I'm not asking about throughput. Your commit message said "much faster". What operation is "much faster"? Enumerating disks at startup? That would be useful. -Alan