From nobody Thu Nov 25 18:13:21 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 027BB183C98A; Thu, 25 Nov 2021 18:13:35 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J0Qwt444hz4Rdg; Thu, 25 Nov 2021 18:13:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6B035CFC5; Thu, 25 Nov 2021 18:13:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f171.google.com with SMTP id p19so6803721qtw.12; Thu, 25 Nov 2021 10:13:34 -0800 (PST) X-Gm-Message-State: AOAM53244Ee0SdCn4IRo3/IyinF2HPEHwomYBgQbd8A8TfTN5tXi8bMG P9MqdQ3e6cE39Z0OQAGSQSQfSmp/xG+0xLJ1+Fk= X-Google-Smtp-Source: ABdhPJyJVBiBWLFQ2oSDDEggiC5uluQPE367lFgnA3ZUJoIamk1jNF83LAEyDz0PUJoayGTgW2Gm0A3Udcv77jXuxgw= X-Received: by 2002:a05:622a:291:: with SMTP id z17mr19880545qtw.138.1637864014056; Thu, 25 Nov 2021 10:13:34 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202106300806.15U86pGq037942@gitrepo.freebsd.org> <20210706090311.aomxh4n45tkpktdc@aniel.nours.eu> <20211125142339.zxkjpbohkxk4hete@aniel.nours.eu> <9226a616-d279-9702-f13f-cee7299afc7a@FreeBSD.org> In-Reply-To: From: Kyle Evans Date: Thu, 25 Nov 2021 12:13:21 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 0a0f7486413c - main - man: Build manpages for all architectures To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Cc: Andriy Gapon , Baptiste Daroussin , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637864014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8jazAQq3ixe7aORGcwLQ9i+uha8TKBsDcHHRaqAj8Aw=; b=mkyy1FapWbOGGUP1XYXnchC2tj1B50pAM2yICP693LoRJkm4wCAWmLI12GR2cuUfaJmixc z+Ys3sX3967Te4lG/lAZO/V6Am15t7LRyCcb/uArWWaSLxzzYCxivoh2mFMlYxvUYLz7d0 wuopw/6+yd14BNxn06XwBdmDDzLSDLeevabVmcRLZmmlz9xCINbo6QfdrpdWR/r23IjdSi sY1Orete1ijh1oo5pWBhzhbgez5dCAS22cenVyQN6Tk1+A1rtIuuY5jxp9Nupxo1g+rRtj k1FXDGpVaEJmKxxAp+rCs16xCiK5svYV3gTqmeX4apzYVQg/nkXeur39+wnEPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637864014; a=rsa-sha256; cv=none; b=K6wIm1AdzfurNKmbOqvS4n4qPDmT75EzCOkhUlR5tjymA2gR4Uh5XXfXtzRqnMyIXoyVXy XYYlqlmno+DbWvwmY8JvmxDfj0gYiPIainwnhYouB+OcyjplkwEKXd5l4PqrzWdS2O3TVh KjJ4J9wEtAtfkezK9FcgBES7TjTVgaBAz7xGoNTh8S1XVyg0pNvPOVrr/xrKSUnFVPpRtl YvdqCNkQ+M7qdSHqsCFWPgpIZhM2afZkusqrQ87vJfNmar9oKcKwWzN5lKKSFtSS10NyXN fvC82GqaEr0w76DXATgDuZCo3rG/aJZ6CkyJiy1Y6pfJGgD9fX2ki1hhMhnUEw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Thu, Nov 25, 2021 at 11:14 AM Fernando Apestegu=C3=ADa wrote: > > On Thu, Nov 25, 2021 at 4:57 PM Kyle Evans wrote: > > > > On Thu, Nov 25, 2021 at 9:28 AM Fernando Apestegu=C3=ADa wrote: > > > > > > On Thu, Nov 25, 2021 at 4:15 PM Kyle Evans wrote: > > > > > > > > On Thu, Nov 25, 2021 at 8:30 AM Andriy Gapon wrot= e: > > > > > > > > > > On 25/11/2021 16:23, Baptiste Daroussin wrote: > > > > > > On Thu, Nov 25, 2021 at 03:57:41PM +0200, Andriy Gapon wrote: > > > > > >> Looking at the output I got another thought: do we need archit= ecture sub-dir > > > > > >> links at all now that we install manpages to a main directory? > > > > > >> Is there any benefit to having the same manpage in a directory= (like man4) > > > > > >> and its immediate subdirectory (like man4/arm) ? > > > > > >> > > > > > > Hardlink not in the same directory is imho a fragile setup anyw= ay, what if a > > > > > > user has different mount points here, the hardlink would be bro= ken. while there > > > > > > is little chances someone is doing that, history told me people= are doing weird > > > > > > things and if they haven't yet, they will soon. > > > > > > > > > > > > I continue to think this kind of links should be 1/ symlinks, 2= / relative > > > > > > symlinks if they are in a situation which can become a cross de= vice issue. > > > > > > > > > > Yeah... but are they needed at all? :-) > > > > > > > > > > > > > It's handy in the sense that it'd be nice to install all arch manpa= ges > > > > > > Not also handy. From the original commit: > > > ---------- > > > Building and installing architecture-specific man pages only > > > raises a number of > > > problems: > > > > > > * The https://www.freebsd.org/cgi/man.cgi is incomplete. As an > > > example, it does not show results for pae(4). The reason for = this is > > > that the cgi interface runs on FreeBSD amd64. > > > > > > * In FreeBSD amd64 some manual pages have broken X-refs. See hp= trr(4) > > > for an example. > > > > > > * Also, we have broken links in our Release Notes. This is a > > > consequence of the first point. See > > > https://www.freebsd.org/releases/13.0R/hardware/#proc-i386. > > > > #1 and #3 are a broken man.cgi, and we should fix it or replace it. #2 > > I think man.cgi is perfectly able to deal with this. The impression I > got the first time I asked about this[1] was the problem is that we do > not ship all the man pages in the released packages. man.cgi can not > show manpages that are not installed. > > [1] https://lists.freebsd.org/pipermail/freebsd-doc/2021-March/035449.htm= l > Ok, cool, so your patch basically does the right thing except we don't need the links. If man.cgi needs the links *and* that they're installed, then yes, man.cgi is still wrong re: discovering these. > > is arguably not a real problem, the xref makes it clear it's an i386 > > I'm sorry, I don't know what you mean here. Do you mean from hptrr(4) > x-ref it is clear that PAE is a i386 thing? > Right, from the context: The hptrr driver only works on the i386 and amd64 platforms as it requires a binary blob object from the manufacturer which they only supply for these platforms. The hptrr driver does not work on i386 wi= th pae(4) enabled. Thanks, Kyle Evans