From nobody Thu Nov 25 15:56:54 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0D2B918A0716; Thu, 25 Nov 2021 15:57:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J0MvQ48PHz4dxP; Thu, 25 Nov 2021 15:57:06 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 68779B7C1; Thu, 25 Nov 2021 15:57:06 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f181.google.com with SMTP id q14so6479887qtx.10; Thu, 25 Nov 2021 07:57:06 -0800 (PST) X-Gm-Message-State: AOAM532MYmkI4c6AEB/cvMZNFSAmcy0J1lbMSeMq8mYXX8tgLF5Q9Rpu x7R+zlxUUnoe/2Lxdt38seNd1TRzsWC07fpsdco= X-Google-Smtp-Source: ABdhPJybEty2dwUVhQBOSlSPnwI2i1mPTUngfN65o2wLHh4mvgmM4TPG2hbfqR4mYiiBop3iBsc6lh6/ORuRoIu1zlg= X-Received: by 2002:a05:622a:2d6:: with SMTP id a22mr18162151qtx.29.1637855825812; Thu, 25 Nov 2021 07:57:05 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202106300806.15U86pGq037942@gitrepo.freebsd.org> <20210706090311.aomxh4n45tkpktdc@aniel.nours.eu> <20211125142339.zxkjpbohkxk4hete@aniel.nours.eu> <9226a616-d279-9702-f13f-cee7299afc7a@FreeBSD.org> In-Reply-To: From: Kyle Evans Date: Thu, 25 Nov 2021 09:56:54 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 0a0f7486413c - main - man: Build manpages for all architectures To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Cc: Andriy Gapon , Baptiste Daroussin , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637855826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wchdglK720o6GAzLJEOeJvTFXx4K6IsMRJhq1GQaAXE=; b=Dw0U+ejmIMS5YbkvK5Pw43BpFeFVnXYpjKYFTfas9Ew6lGJGcqIJprNPvBGNHEiNgr5Mxt LggO1bzDRfyCUrNEc7FF0DLNXg3UPm+5OYTkhKl3d8nmEt/f12F9mdZQSQf7uPvsvs1zw9 bMIzOUsuvnh9EQnEcl4qb5CzlfLni8dK79/dmhuzLB9x9BsCtTP1l0G5XN5cc7EZq4DXyz Ch6Uoh0r/Ke/arNDX2zChXygZrumoCjj+r8O6nI/lYeA/KKq4oCe0n8FMKFD2qwNQpeJcX DcaO4uC0E0JmmRWITRQrbzv1aiirP60Mj6QsH/1sS9DRYZCTNHo5hjQHtzdt7w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637855826; a=rsa-sha256; cv=none; b=TUPPvGmAH6Igs44qLbP2OUVFdGij/4m/t5mNOoBEF/WgITSZo3u+/1/pxrUa+P2Tm4mTiD KsDcqEDMS3+VDibR9e2Rw1L3RlUbuOWvUrRirS8PqQgdRj0EmHC072IhGTWCjGOHqWXqVU clh//E2700f5XkleTG+TNIeRujhvpm08ruApqbHcUZhxVvOIN70rESO6Xl+KzuM5u/42np KDoQobQbd/0ruhCGs6K9G4MDOikmHEfD3lOpFC8aIBqbmC0FeYrPaPHZhOi1kEe2Xm5fGE OHZSey45nc64yrvrbOtCU8QvBBWUoZokPigmxCwVE6SNho7AxB5ccBP0QhG5Lg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Thu, Nov 25, 2021 at 9:28 AM Fernando Apestegu=C3=ADa wrote: > > On Thu, Nov 25, 2021 at 4:15 PM Kyle Evans wrote: > > > > On Thu, Nov 25, 2021 at 8:30 AM Andriy Gapon wrote: > > > > > > On 25/11/2021 16:23, Baptiste Daroussin wrote: > > > > On Thu, Nov 25, 2021 at 03:57:41PM +0200, Andriy Gapon wrote: > > > >> Looking at the output I got another thought: do we need architectu= re sub-dir > > > >> links at all now that we install manpages to a main directory? > > > >> Is there any benefit to having the same manpage in a directory (li= ke man4) > > > >> and its immediate subdirectory (like man4/arm) ? > > > >> > > > > Hardlink not in the same directory is imho a fragile setup anyway, = what if a > > > > user has different mount points here, the hardlink would be broken.= while there > > > > is little chances someone is doing that, history told me people are= doing weird > > > > things and if they haven't yet, they will soon. > > > > > > > > I continue to think this kind of links should be 1/ symlinks, 2/ re= lative > > > > symlinks if they are in a situation which can become a cross device= issue. > > > > > > Yeah... but are they needed at all? :-) > > > > > > > It's handy in the sense that it'd be nice to install all arch manpages > > Not also handy. From the original commit: > ---------- > Building and installing architecture-specific man pages only > raises a number of > problems: > > * The https://www.freebsd.org/cgi/man.cgi is incomplete. As an > example, it does not show results for pae(4). The reason for this= is > that the cgi interface runs on FreeBSD amd64. > > * In FreeBSD amd64 some manual pages have broken X-refs. See hptrr(= 4) > for an example. > > * Also, we have broken links in our Release Notes. This is a > consequence of the first point. See > https://www.freebsd.org/releases/13.0R/hardware/#proc-i386. #1 and #3 are a broken man.cgi, and we should fix it or replace it. #2 is arguably not a real problem, the xref makes it clear it's an i386 concept and we reference, e.g., ports manpages that are inherently broken with some frequency anyways; see: `find *bin | xargs mandoc -Tlint | grep Xr`, a subset of those are ports, although I haven't counted. > > Would anyone try this patch > https://people.freebsd.org/~fernape/fix-dnoroot.patch? > > It seems to work(around) the problem, at least with: > > makefs -D -B little -o label=3DFreeBSD_root -o version=3D2 ufs.part METAL= OG > and > tar -c -f archive.tbz @METALOG > > Cheers. > > on some machines, e.g., I develop arm stuff on amd64 and there are > > some drivers that simply aren't applicable to amd64, I'd like to be > > able to find those. I think the implementation is a bit odd, though, > > leading into: > > > > > I mean, whichever way we install manpages they are always installed i= nto manX. > > > I do not see a point / benefit of having another copy / link / whatev= er in > > > manX/arch. > > > > > > > I guess I haven't read the context much here, but I don't see why > > either. /usr/bin/man's built-in search behavior checks > > $mandir/$machine and $mandir/$machine_arch before $mandir, it seems > > like we should be leaving them there and letting man do its thing. If > > you need a non-native arch then you can hopefully just poke around the > > arch subdirs (presumably mostly section 4 pages) to figure it out. > > There's a reason they're arch subdirs, and trying to install links or > > arch-specific pages into the main $mandir is asking for trouble when > > we actually have conflicting pages for whatever reason between archs. > > > > Thanks, > > > > Kyle Evans