From nobody Fri Nov 19 16:46:46 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 781C8189AD73 for ; Fri, 19 Nov 2021 16:46:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HwjHk2Xq2z4fmX for ; Fri, 19 Nov 2021 16:46:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x935.google.com with SMTP id p2so22392725uad.11 for ; Fri, 19 Nov 2021 08:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3v11TT6w0sclY19A4dAaBmcF5ZEz1fXn6umni8hi9sw=; b=oPLQKccb3flX3vFAGsb57s267LyVTAl+9qEf0JwlYtGLghvtpySt0WIqF5mG1pU2rk FpQC1DYlsTEvV9TUVnOl7fi+KDhge4/GYJ4DNkqdp/T3ZbOEsom924OpE/46lkDc/WPU 9uhNYUvD3LpB0YaqUUJGWILu44RdZ5Z/4PlW2520vu5dwO5IgKMl8CzZfTjd+jDDIx2L dLjhKqpIHnbw17BVk8C+hrenSUqzP71QzlivqAkm18+hWDVCXHiD9oYbul+chGvq4VGD CZdYt6mqLUOBp1hBU1sjtnM233pG0yM+5b0hHDpxC3+wBEr2NX8a3RburMSXQSxt9CTA wPcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3v11TT6w0sclY19A4dAaBmcF5ZEz1fXn6umni8hi9sw=; b=3biPH8z5QfuYkV8DzldoB8A6gJktvH86CFvXw1xNSkbPA1HMEA/XYsfsYKARWy9IkQ ixeQIeBzHZUGOBfGxc5a6+jF2lvWE29HMJ912sfWind50aggG6H5pyTfMAznM2mqp/eq pV3pcOlFMJAFl7iuX+3tcXavwHXgT2Uf/TExm6SoNXyNG+ohLh/xUaDafemoBswFOTkx vupWelOJGq78C9NrPU2j4LGeuVcwhQ/eHTyG1bULjGpTwuUF8+ERjwqXAjOwr6XQT7sa /JRbttYvykOsOBXdKHLzVD/qgTQya68hgt1E0hfhMFYdpj/5CGWo2bomEgWRFbzlL/Lj /gHw== X-Gm-Message-State: AOAM531amh1NEXD40bM7S3SE9gJj5W5xIkzVhT2Da/9Oy7h818+X4DXr xVAvvTNu14Su1YxO6OV5/lbRaisQXjjdB0gWsbTlUxsGcbI= X-Google-Smtp-Source: ABdhPJymtUTxX8l/w/92ag/KgYMyTPCh/XVfkV6MnLXpI7RPLNwIKAnSKnNdQJY8zO27+qO81MRNaViRPc4qFLr0Go0= X-Received: by 2002:a67:fdc3:: with SMTP id l3mr95049956vsq.42.1637340417803; Fri, 19 Nov 2021 08:46:57 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202111190620.1AJ6KS08078314@gitrepo.freebsd.org> <708f1f87-0082-5259-24df-cf23b87b628f@gmail.com> In-Reply-To: <708f1f87-0082-5259-24df-cf23b87b628f@gmail.com> From: Warner Losh Date: Fri, 19 Nov 2021 09:46:46 -0700 Message-ID: Subject: Re: git: 9cb485d18f01 - main - geom: Remove g_class.config To: Alexander Motin Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000fadbae05d127053f" X-Rspamd-Queue-Id: 4HwjHk2Xq2z4fmX X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000fadbae05d127053f Content-Type: text/plain; charset="UTF-8" Thanks Alexander... I understand this comment for MFCing, but -current isn't KBI stable, though I likely should have bumped FreeBSD_version to cope instead. Am I missing something? Warner On Fri, Nov 19, 2021 at 8:05 AM Alexander Motin wrote: > I have no objections, but I'd leave padding there to not break KBI for > out of tree GEOM classes. > > On 19.11.2021 01:20, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=9cb485d18f01900800efe4ec3cfcfadd335da858 > > > > commit 9cb485d18f01900800efe4ec3cfcfadd335da858 > > Author: Wuyang Chung > > AuthorDate: 2021-10-16 01:43:54 +0000 > > Commit: Warner Losh > > CommitDate: 2021-11-19 06:17:07 +0000 > > > > geom: Remove g_class.config > > > > g_class.config is write only, remove it. > > --- > > sys/geom/geom.h | 1 - > > sys/geom/geom_subr.c | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/sys/geom/geom.h b/sys/geom/geom.h > > index 1aba1f46d6d5..0d6d74d0b51c 100644 > > --- a/sys/geom/geom.h > > +++ b/sys/geom/geom.h > > @@ -96,7 +96,6 @@ struct g_class { > > u_int version; > > u_int spare0; > > g_taste_t *taste; > > - g_config_t *config; > > g_ctl_req_t *ctlreq; > > g_init_t *init; > > g_fini_t *fini; > > diff --git a/sys/geom/geom_subr.c b/sys/geom/geom_subr.c > > index 2f7ea7754f7b..abaae5ccf57f 100644 > > --- a/sys/geom/geom_subr.c > > +++ b/sys/geom/geom_subr.c > > @@ -222,7 +222,6 @@ retry: > > > > /* Bar new entries */ > > mp->taste = NULL; > > - mp->config = NULL; > > > > LIST_FOREACH(gp, &mp->geom, geom) { > > error = mp->destroy_geom(NULL, mp, gp); > > > > -- > Alexander Motin > --000000000000fadbae05d127053f--