From nobody Fri Nov 19 15:05:28 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 36CDB188FBFF; Fri, 19 Nov 2021 15:05:31 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hwg2g0lV5z3MJh; Fri, 19 Nov 2021 15:05:31 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-qk1-x730.google.com with SMTP id o63so10453034qkb.4; Fri, 19 Nov 2021 07:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=nOa+FYBNjK61vAI3hJrkhTK5kc0KRixn7CrhxpwnvME=; b=UFcUxwmVQU367di/bsndp3Eh9whDlLBduU12Qia5FsJpNGyf57M9+a3Z7wDLzjfBPK 5GceHPkuhjSBNl450rYVNqb1G3cIr6NQ4CBmzHPwf4zkvrbqo4HEaIZd3Q0YUkR9UD80 CajFB/1+R6aVUbDeJrGt5VyzWO45Q+8JYr255qAX3Y/xMkpH8bwfH4vdEDGpGZJMB8fP 5ouoiHkvy4K7Ncg2zRFxq7TJGTvSXW8ZNVz/ixsPvlvHdzn6WfOLv25NvKytT8A3UzlT lv45g6LqtZWoKbvETiUbIZcBHj0wPqfNjn4UypconVrgKwTPRa7cI4ENV48T0ksPDYUM Wigg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nOa+FYBNjK61vAI3hJrkhTK5kc0KRixn7CrhxpwnvME=; b=1MgHwGJLZZdh9G10m/2+i9EAWG6G/useMT+0lXom457qlpojzhv40lVKHUkxLt9OL1 QVt6mF9bHWiCEuwmA6B9PzO1jNZK3wCO0doJ+MKp4t3JNqkwInPODtfk9zq3DmbvLgWc qSx4w+VseAQomftuh97MAJuSHaEK9JvMvnK2XAQWi/HZ+54gezpf0Ke8NKZJGOc0lHC+ eRdSrLq+mXEZ6KUyP5xHxOApjK+NC8wIEI+tSyaUJpvF+KgY6q+PR0b5BEBB6cSkGkCK h/C1A8Dm0A5XPqlOu1cekyYzNn21/4fmcnAY4uKwsfyp74+xlujwvMyXQYsfkqdU2O1o /VyQ== X-Gm-Message-State: AOAM532LlAOOBRu0LtTl/v9RpxJIgjtKq76JQpqags7n0DbjOvpPOM8z c7mK63zEhHExrDqCu+3LfjEttGjQz2o= X-Google-Smtp-Source: ABdhPJyMdekVGclgxHuGwEUTqO+7lixu96pTfHFJhMWWAiwo99ndejRuPrcIE0pGexNyhbaiymKaXw== X-Received: by 2002:a05:620a:d96:: with SMTP id q22mr29369547qkl.219.1637334330296; Fri, 19 Nov 2021 07:05:30 -0800 (PST) Received: from spectre.mavhome.dp.ua (104-55-12-234.lightspeed.knvltn.sbcglobal.net. [104.55.12.234]) by smtp.gmail.com with ESMTPSA id r20sm1911358qkp.21.2021.11.19.07.05.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 07:05:29 -0800 (PST) Subject: Re: git: 9cb485d18f01 - main - geom: Remove g_class.config To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202111190620.1AJ6KS08078314@gitrepo.freebsd.org> From: Alexander Motin Message-ID: <708f1f87-0082-5259-24df-cf23b87b628f@gmail.com> Date: Fri, 19 Nov 2021 10:05:28 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: <202111190620.1AJ6KS08078314@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Hwg2g0lV5z3MJh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N I have no objections, but I'd leave padding there to not break KBI for out of tree GEOM classes. On 19.11.2021 01:20, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9cb485d18f01900800efe4ec3cfcfadd335da858 > > commit 9cb485d18f01900800efe4ec3cfcfadd335da858 > Author: Wuyang Chung > AuthorDate: 2021-10-16 01:43:54 +0000 > Commit: Warner Losh > CommitDate: 2021-11-19 06:17:07 +0000 > > geom: Remove g_class.config > > g_class.config is write only, remove it. > --- > sys/geom/geom.h | 1 - > sys/geom/geom_subr.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/sys/geom/geom.h b/sys/geom/geom.h > index 1aba1f46d6d5..0d6d74d0b51c 100644 > --- a/sys/geom/geom.h > +++ b/sys/geom/geom.h > @@ -96,7 +96,6 @@ struct g_class { > u_int version; > u_int spare0; > g_taste_t *taste; > - g_config_t *config; > g_ctl_req_t *ctlreq; > g_init_t *init; > g_fini_t *fini; > diff --git a/sys/geom/geom_subr.c b/sys/geom/geom_subr.c > index 2f7ea7754f7b..abaae5ccf57f 100644 > --- a/sys/geom/geom_subr.c > +++ b/sys/geom/geom_subr.c > @@ -222,7 +222,6 @@ retry: > > /* Bar new entries */ > mp->taste = NULL; > - mp->config = NULL; > > LIST_FOREACH(gp, &mp->geom, geom) { > error = mp->destroy_geom(NULL, mp, gp); > -- Alexander Motin