From nobody Mon Nov 15 16:26:12 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4BBA81854153 for ; Mon, 15 Nov 2021 16:26:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HtF1r0rFrz4S6r for ; Mon, 15 Nov 2021 16:26:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x929.google.com with SMTP id i6so36058126uae.6 for ; Mon, 15 Nov 2021 08:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pc00qRiFMUTCOOlMAuxaNrH41SBwIntFov9o/XsOYzg=; b=AzwDrnfVCYCoSMW17i+VluBDM1R+23TbmlYLXNr6hJetbYD7+DpxSrItHsq9aVaBSG o8tOONu81bm0i5JKtDgn1ncpVfLqrj+T3dOiPn8Obz4ypWdBY5kCnbZn0Z6SIrCQXV9Y qdGRsZxg4B5yzK6gFeXm1tf1AUI+5HQMhviL+JIhIWUiT6v+VxqyB7EXPHjlfApXF5zU 8qk7juAiR+jkYfHUez7QsOtScTwRnHaARxzwAzSjFcAyfMwMsv1vBffRwpMRsAf8xGct 09O2h8w+apu9voU6iB6dsOsEOczdsBq167/6TBPPrQpBl7uk9N8802KUzdvjOc+rPZCu 3rlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pc00qRiFMUTCOOlMAuxaNrH41SBwIntFov9o/XsOYzg=; b=DtLAA9vRbZezpQ+MF2xpl3NJTQeFN6FGEpSPHH5/QOyY8NPMemsWDzufpRLFqLrTxn fM/nz2QIH2RlzDqzOMAGmqMRfdih6GG7XwWDh/gM+gr9PXMA+iaI+pFocQiEpPLWg+Bp xBY/WPsw7XlPouDjWcR+fUatYTeP/bil6J8sJgL8v53P+xv5c5fQ2oub8rYggt4OrS6n duIabbsytSOX2ORG3is5QRDjxQpkaFO4CuOZrwkOYnJ4KbI9cnVtGgdqd0OLN7ZKvWFP yHIiKbovlwfLD1WTbguBFWuC69lPLocRq52S00FrQ3RK3o6I02WfvNz7rN3jBY24R9Fl DHtQ== X-Gm-Message-State: AOAM530W+7atXm71QXmgGgcVShqM44twkAgUGCcKD/1yv8fQoW14A5GB A11ueuhQa4Q7T1wGZk5sm3uL6lTI7jO+a91KfsojwZCs3ko= X-Google-Smtp-Source: ABdhPJzur7/q7s1h/3xJ78hIf1ieXtQgY28udEzMnRgUPCen4+rPdGxu6p47Ej6z2jEqjta3AkMRbFLEJtmIvecM0Cc= X-Received: by 2002:a9f:2383:: with SMTP id 3mr45119uao.77.1636993583526; Mon, 15 Nov 2021 08:26:23 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202111111131.1ABBVH6s017371@gitrepo.freebsd.org> <2a564b11-b1f4-a4fe-745b-27f45fb134eb@FreeBSD.org> <5A60AA15-F560-44D9-89A0-BD0A197E5E58@netflix.com> <5cef43ac-0c37-5b3b-c938-1024fc746cb0@FreeBSD.org> In-Reply-To: <5cef43ac-0c37-5b3b-c938-1024fc746cb0@FreeBSD.org> From: Warner Losh Date: Mon, 15 Nov 2021 09:26:12 -0700 Message-ID: Subject: Re: git: b8d60729deef - main - tcp: Congestion control cleanup. To: John Baldwin Cc: Randall Stewart , Jessica Clarke , Randall Ray Stewart , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="0000000000000bc8c005d0d64526" X-Rspamd-Queue-Id: 4HtF1r0rFrz4S6r X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --0000000000000bc8c005d0d64526 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 15, 2021 at 9:16 AM John Baldwin wrote: > On 11/14/21 7:03 AM, Randall Stewart wrote: > > John: > > > > This is fine to do, but I want to make sure everyone understands that > > I was specifically asked to make compile fail on the transport call > > if CC_XXXX or CC_DEFAULT was not defined. Its not how I had the code > > originally but it was requested specifically. > > > > I am fine with all the changes aka it showing up in DEFAULT that=E2=80= =99s a > > good solution. > > > > And I think Warner=E2=80=99s patch with an ifndef in cc.c works perfect= ly that > > way if you are say netapp and don=E2=80=99t use newreno you can do a > > > > nooptions CC_NEWRENO > > options CC_CUBIC > > options CC_DEFAULT=3D\=E2=80=9Dcubic\=E2=80=9D > > > > And it all just works for you ;) > > No worries. I think this is one of those cases where some things just > aren't obvious until subjected to wider testing. You sought review (and > got a fair bit of it), and without some kind of available pre-commit CI > I don't know that we can expect folks to boot changes in qemu for all > architectures by hand prior to commit (which I think might have been the > only realistic way to catch the breakage on arm64 or the vnet issues). > I do think one of the goals of Warner's group is to figure out a way to > provide some level of pre-commit CI that folks can opt into. > To be fair, there is a simple level of pre-commit checking/CI that folks ca= n opt into today. If you push your branch to github or gitlab, CirrusCI will run a simple smoke test and test-boot on both amd64 and arm64, though I don't know if that would have caught the panic due to different ordering issue or not (I've not tried it). There may be a registration of your fork with CirrusCI that's needed, though. I try to use this for any non-trivial chang= e unless I've done a full build/install world/kernel cycle on the changes. If you are interested in this stuff, please subscribe to git@. I'm trying to have a discussion there, and it would benefit from more participation. > FWIW, the arm64 breakage wasn't really due to the changes in this commit > either, it was just that this commit exposed a longstanding bug in the > hhook code that hadn't yet surfaced. > One thing that would have caught more problems, though, is a make universe prior to commit: That would have caught the now-broken config files. While it would be nice to get this Warner --0000000000000bc8c005d0d64526--