From nobody Fri Dec 31 18:08:25 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B887319235BE; Fri, 31 Dec 2021 18:09:14 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JQY7G4byTz3hx2; Fri, 31 Dec 2021 18:09:14 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f51.google.com with SMTP id s6so24627475ioj.0; Fri, 31 Dec 2021 10:09:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XGnzZkW88cGrm1aRye2Yp7+FUPdEg3iQMEYqy2ARofY=; b=2xf6yzioy+4bFvzsVsXelBsO+DZy91Zhbcvqef6PBizrkV8TOMs0jfKLxe63vHkOj7 HbEyVe+Yi8QqOvQt2cKDsuOnXYaJzJ3o3dyhb3ASUWQYcOv3aHAxfH42R6QjIKLbq5uG 1+OXKAsvOZKtXy8clN7Xq1GyYvAIcwXO+giKm0HcYfMq1GIRipxgcHPQXDR75JGdkj/A Yo9N56NCcpMJvS3aHnoO1CX2GfiMwRIBAMRlhEY8AKAS2us5PyqTpkMyn8j0sjjm+cDV yiKJFaqmZ26bcimBZyr5gXhc7tD4/yG4W5Fj1pezKL13GcwjgszmJhnXKKs0aOqhDmda Hh/A== X-Gm-Message-State: AOAM531SwhC0vh5XEkGIYCRIs1abFOE7gTggjfgUtCKqvrLNEDGk+z59 WI36KpO6A+qo1EAyJMlCUd45XSvSQZw8Tuy9yMk= X-Google-Smtp-Source: ABdhPJwTkj4HjC//u6HEIi2ANUYQ0GrNHtgWRJvLXdqXDAr54c7Xqf6Ym0l3+heDgVZofEnbtbV2nYXiCjrSqvdyDgk= X-Received: by 2002:a6b:fe09:: with SMTP id x9mr16297950ioh.206.1640974148669; Fri, 31 Dec 2021 10:09:08 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202112301154.1BUBsR1q017491@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Fri, 31 Dec 2021 13:08:25 -0500 Message-ID: Subject: Re: git: e2650af157bc - main - Make CPU_SET macros compliant with other implementations To: Warner Losh Cc: Kyle Evans , Konstantin Belousov , Stefan Esser , Antoine Brodin , src-committers , "" , dev-commits-src-main@freebsd.org, FreeBSD Ports Management Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4JQY7G4byTz3hx2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Some time ago I started a best practises doc for potentially disruptive src changes (and have received some feedback, including from folks on this thread). I'll paste it here for further discussion. --- This is the suggested process for introducing tool chain and other changes in the src tree that may cause significant disruption to ports. Some examples of potentially disruptive changes are: - major compiler updates - OpenSSL updates - adding a library or system call (such as memfd) that is already present on other systems - changing the semantics or APIs of existing libraries The goal of this document is not to be overly prescriptive, but to document a process that has produced good results in the past, avoid surprises among ports committers and maintainers, and clarify the expectation on port maintainers to collaborate on addressing fallout from the potentially disruptive change. The project gets the best results when everybody works together, in good faith, to solve problems with disruptive changes. Disruptive change process: 1. Request a ports exp-run with the desired change. This is used to determine the initial impact of the change. If the exp-run shows no impact or minimal impact the rest of the process may be skipped. 2. Verify that important packages build, and fix identified failures. Maintainers of important packages should be prepared to assist. Important (critical?) packages include: - pkg - binutils - gcc =E2=80=A6 (need to expand this list) 3. Post a Heads-Up email to at least the FreeBSD-current and FreeBSD-ports mailing lists with a proposed schedule. Where appropriate add other mailing lists, such as FreeBSD-toolchain. Allow at least three weeks between the Heads-Up email and the commit. 4. In the period between the Heads-Up email and the commit, developers proposing the change and maintainers of ports affected by the change work together to resolve any ports failures. 5. Request additional exp-runs as necessary (by adding a comment in the existing PR). 6. Commit may proceed once all important/critcal ports build, and either: - The deadline proposed in the Heads-Up email has been reached - There is a concensus that remaining failures are insignificant (for example, a small number of unmaintained leaf ports are the only outstanding failures) 7. Collaborate on fixing any outstanding issues (e.g. broken leaf ports)