Re: git: c2c8e360d8c0 - main - tcp: virtualise net.inet.tcp.msl sysctl.

> On 26. Dec 2021, at 17:20, Gleb Smirnoff <glebius@FreeBSD.org> wrote:
> 
> On Sun, Dec 26, 2021 at 03:06:04PM +0000, Alexander V. Chernikov wrote:
> A> commit c2c8e360d8c0b8712158d334686d88f052aef819
> A> Author:     Alexander V. Chernikov <melifaro@FreeBSD.org>
> A> 
> A>     tcp: virtualise net.inet.tcp.msl sysctl.
> A>     
> A>     VNET teardown waits 2*MSL (60 seconds by default) before expiring
> A>      tcp PCBs. These PCBs holds references to nexthops, which, in turn,
> A>      reference ifnets. This chain results in VNET interfaces being destroyed
> A>      and moved to default VNET only after 60 seconds.
> A>     Allow tcp_msl to be set in jail by virtualising net.inet.tcp.msl sysctl,
> A>      permitting more predictable VNET tests outcomes.
> A>     
> A>     MFC after:      1 week
> A>     Reviewed by:    glebius
> A>     Differential Revision: https://reviews.freebsd.org/D33270
> 
> Thanks! Does our test framework use some kind of boilerplate jail config
> so that we can enable smaller MSL for all tests at once?
Or does it make more sende to use tcpdrop -s TIME_WAIT to clean up at the end of the test?

Best regards
Michael
> 
> -- 
> Gleb Smirnoff