From nobody Sun Dec 26 10:15:31 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4E84F1905E2B; Sun, 26 Dec 2021 10:15:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JMGs00NlMz3ljk; Sun, 26 Dec 2021 10:15:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D2FE3656; Sun, 26 Dec 2021 10:15:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BQAFVSA093364; Sun, 26 Dec 2021 10:15:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BQAFVka093363; Sun, 26 Dec 2021 10:15:31 GMT (envelope-from git) Date: Sun, 26 Dec 2021 10:15:31 GMT Message-Id: <202112261015.1BQAFVka093363@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andriy Gapon Subject: git: fe3c0370dafa - stable/13 - twsi: use twsi_error() to handle wrong bus status when starting List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: fe3c0370dafa085688ff97db7fe84cd033497c96 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640513732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n3rDrzVwStpCX7O5Dem8i1+u3+ZGU9e6I0g2qM3UrWU=; b=YuWcG2Jr8o9gUCTB9Lt18AEaalkAG8N8I9QfNC08iH+45bSy94w4ilHEYaVWl0eEu5ECtv eHbIIuR9x6Rz6gA4f/9lOwahsTCrMJLcc07jA489GxEJOAdn48+QZOopJdilnwgtANRRMU yEmBLdco+yrafNDIjyvuzYqjhB0hXznZ0FQLG9PyrXOEyMQ1VMl+JxaxZr9ktrmLcAP5ss n3hjnSpRiU9faWwNzHeFVYeL1uE8lLThai6oyvmE3kypQlJbIuMWy9flOB/BzTgP4bBPxj 0ZCIMxVrTp1tS+j8IJn5g3JVAGsfUJAIqH8UBR3E6tonrF+3rZOMIWlxJtt4Ww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640513732; a=rsa-sha256; cv=none; b=XMmKI8/KB3ZJKRr++HcjZdqr2e3D74PDCgeUSuXTudDgh+0wU6PlV+3YXzlimZRlnggg3d 2F5i+0ikTnm1u2CsaSOg4bRLarRJJWMroc4AKcDqRm9Q24+dvEP/iAgKYNl/LYPJZHP/k9 vpAKGfNKxdshVsvUnVGHC8K0KLvgPQ2KlMeg/P8s3yhZizRPStaytuw8RJ8MfebfxSWBcu vfbQkq6z7JByYazedNtRbcSOkVpqal620Kpc/bfvisI5JlMvq4jFs/w4olMe4O3sc8mtVH gJgOXkZc1vFIb1EgNhUrp0T8xd+YOV5plJo4ClBFYX2J4qc4s3vmfSkvXwm9sQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=fe3c0370dafa085688ff97db7fe84cd033497c96 commit fe3c0370dafa085688ff97db7fe84cd033497c96 Author: Andriy Gapon AuthorDate: 2021-12-19 09:28:02 +0000 Commit: Andriy Gapon CommitDate: 2021-12-26 10:15:18 +0000 twsi: use twsi_error() to handle wrong bus status when starting (cherry picked from commit 46e0c03795443675f95db6da2195825d24a9fb7c) --- sys/dev/iicbus/twsi/twsi.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sys/dev/iicbus/twsi/twsi.c b/sys/dev/iicbus/twsi/twsi.c index 740c7e14a31f..91433f2cfe4a 100644 --- a/sys/dev/iicbus/twsi/twsi.c +++ b/sys/dev/iicbus/twsi/twsi.c @@ -480,6 +480,19 @@ out: return (rv); } +static void +twsi_error(struct twsi_softc *sc, int err) +{ + /* + * Must send stop condition to abort the current transfer. + */ + debugf(sc, "Sending STOP condition for error %d\n", err); + sc->transfer = 0; + sc->error = err; + sc->control_val = 0; + TWSI_WRITE(sc, sc->reg_control, sc->control_val | TWSI_CONTROL_STOP); +} + static int twsi_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) { @@ -501,9 +514,8 @@ twsi_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) debugf(sc, "status=0x%x\n", status); if (status != TWSI_STATUS_IDLE) { debugf(sc, "Bad status at start of transfer\n"); - TWSI_WRITE(sc, sc->reg_control, TWSI_CONTROL_STOP); - mtx_unlock(&sc->mutex); - return (IIC_ESTATUS); + twsi_error(sc, IIC_ESTATUS); + goto end; } sc->nmsgs = nmsgs; @@ -531,6 +543,7 @@ twsi_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) if (sc->error != 0) debugf(sc, "Error: %d\n", sc->error); +end: /* Disable module and interrupts */ debugf(sc, "status=0x%x\n", TWSI_READ(sc, sc->reg_status)); TWSI_WRITE(sc, sc->reg_control, 0); @@ -541,19 +554,6 @@ twsi_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) return (error); } -static void -twsi_error(struct twsi_softc *sc, int err) -{ - /* - * Must send stop condition to abort the current transfer. - */ - debugf(sc, "Sending STOP condition for error %d\n", err); - sc->transfer = 0; - sc->error = err; - sc->control_val = 0; - TWSI_WRITE(sc, sc->reg_control, sc->control_val | TWSI_CONTROL_STOP); -} - static void twsi_intr(void *arg) {