From nobody Sat Dec 25 11:55:05 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 71D0618F2374; Sat, 25 Dec 2021 11:55:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JLj6L1L2Jz4kTw; Sat, 25 Dec 2021 11:55:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0E830164F8; Sat, 25 Dec 2021 11:55:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BPBt5pY006036; Sat, 25 Dec 2021 11:55:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BPBt5Rt006035; Sat, 25 Dec 2021 11:55:05 GMT (envelope-from git) Date: Sat, 25 Dec 2021 11:55:05 GMT Message-Id: <202112251155.1BPBt5Rt006035@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: efe456a0ef00 - stable/12 - libllvmminimal: Add missing Support/ABIBreak.cpp List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: efe456a0ef002f39fb898a99b1d57de673dd5793 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640433306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EIbCfdCCu/ullcjHVTw0D918IUYX7AO+OiHI7NvCAIs=; b=hCNzaEkxI5uSkQKPy9gkBNU8PANsU7+XnZBfp6sTl40BOjV3r4tdnO0h9UMYeZMx6hjoef WYpNeQSAp4qn5tTqyEcxtrUMp1BM8SHfwDrB4i0Y88jpQjtKrRbGIpMHJXP1+24Ry0voa9 A1RKduIFcTRaXxODeWmqBhEad/KIOjnBvRYNrAIaA+LfnSKpgzOrcZlvTsDpN1tuPR/qb+ XAogCvnMswBdoAQ1q1XMZJHeNVL3UuigJef3Zzwl85Hiqnbxk3iBs3nXhDOnd2wrQ+kwIj XhcYBRzi3IgF8ALum0vK/3a//nwMLQvvJ7fm/75tjInkoivyooBXhbkfn90Olw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640433306; a=rsa-sha256; cv=none; b=mTzIKSZGUGPrmW2AFsIEnJa2Blky8AXYame12+wI0LxmwCFUKQv4/kQM/Fo0AhoA78t9qJ pAEq/6jFxI+nfmus37Py5Lbt16K0Edok9W+LFjt8SVviUMe20heIx6HupKjzc1jJULJCHz lIowTrQJ2mJQzO0y97rcnh2AEQgmGR2t00IrcqK2G1XyJ9BuSAIltwsO+DIcrHLwuHvjXu a07c4kcfbmwxBZNV5rT1DCpWG/pqqWUuwZ8e/XZ59hk8+SsYVwzjN8M+anGLnqifXxDYTw s6gOjz8cv4Mai/Qfaa1TQ2FCGfD514fHCe5OovKcYqWrr6swbDmVX+8BwSXx6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=efe456a0ef002f39fb898a99b1d57de673dd5793 commit efe456a0ef002f39fb898a99b1d57de673dd5793 Author: Jessica Clarke AuthorDate: 2021-01-27 19:19:00 +0000 Commit: Dimitry Andric CommitDate: 2021-12-25 11:50:57 +0000 libllvmminimal: Add missing Support/ABIBreak.cpp When building natively on RISC-V, linking the bootstrap clang-tblgen fails with: ld: error: undefined symbol: llvm::EnableABIBreakingChecks >>> referenced by PrettyStackTrace.cpp >>> PrettyStackTrace.o:(.sdata+0x0) in archive /usr/obj/usr/src/freebsd-src/riscv.riscv64/tmp/obj-tools/lib/clang/libllvmminimal/libllvmminimal.a >>> referenced by Signals.cpp >>> Signals.o:(.sdata+0x8) in archive /usr/obj/usr/src/freebsd-src/riscv.riscv64/tmp/obj-tools/lib/clang/libllvmminimal/libllvmminimal.a >>> referenced by Timer.cpp >>> Timer.o:(.sdata+0x28) in archive /usr/obj/usr/src/freebsd-src/riscv.riscv64/tmp/obj-tools/lib/clang/libllvmminimal/libllvmminimal.a This is likely due to Error.h's inclusion of abi-breaking.h. It's unclear why this only affects RISC-V, but perhaps relates to its more eager use of .sdata due to the ABI's support for linker relaxations. Regardless, this is theoretically an issue for all architectures. Reported by: Dennis Clarke Reviewed by: dim Tested by: mhorne MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D28367 (cherry picked from commit 48397f6c7d2d693602105d8ec24c5741202e264d) --- lib/clang/libllvmminimal/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/clang/libllvmminimal/Makefile b/lib/clang/libllvmminimal/Makefile index 0b5a204583fb..76826547ddbf 100644 --- a/lib/clang/libllvmminimal/Makefile +++ b/lib/clang/libllvmminimal/Makefile @@ -7,6 +7,7 @@ INTERNALLIB= SRCDIR= llvm/lib SRCS+= Demangle/ItaniumDemangle.cpp +SRCS+= Support/ABIBreak.cpp SRCS+= Support/APFloat.cpp SRCS+= Support/APInt.cpp SRCS+= Support/ARMTargetParser.cpp