From nobody Sat Dec 25 11:23:34 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 57222191CD97; Sat, 25 Dec 2021 11:23:56 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp6.goneo.de (smtp6.goneo.de [IPv6:2001:1640:5::8:31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JLhQL6tx6z4gTX; Sat, 25 Dec 2021 11:23:54 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from hub1.goneo.de (hub1.goneo.de [IPv6:2001:1640:5::8:52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by smtp6.goneo.de (Postfix) with ESMTPS id DE82510A3329; Sat, 25 Dec 2021 12:23:45 +0100 (CET) Received: from hub1.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPS id 0EA2610A75DF; Sat, 25 Dec 2021 12:23:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1640431424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZVv0TX7Qb5WYex6F1qwHqx5qOHbpVIIMnf/rlrUB3aA=; b=p9TBgHRgGmm5pIkfM3pgpEMs2cTrgR1JlRVTwoYosKQwb0qXelG6vGXFFL03X9ivvXIFgO NJUepKSlMdalUgAZg8IvZwtG/o2YMcsbnuOwjjL1ttAdeQi9wLecsCqjKSpnuahBcdopmh npLSlDhHC3M5RtZJFw8aQuxkoELbAOX2IRSRp6dWnBf7BkOYMAFlbqtFXt9eKk7iYZOB+5 zey2Sshbs6/PGJqM8wf81JS0si7VRb9jFv/dgkc4t8GH842nXtFchy6M2e3TCXSNbNpjRd OijptPWyNkeFeJsmuF/NQx1RjcvbNj7KvqzvaavZHpBQMzU7KtUvo1WmdBzTCw== Received: from jelly.fritz.box (dynamic-2a01-0c23-6177-aa00-4851-0cd5-f84b-0588.c23.pool.telefonica.de [IPv6:2a01:c23:6177:aa00:4851:cd5:f84b:588]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPSA id BC52F10A32F5; Sat, 25 Dec 2021 12:23:43 +0100 (CET) Date: Sat, 25 Dec 2021 12:23:34 +0100 From: FreeBSD User To: Doug Moore Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 184c63db3c94 - main - Fix clerical error in page alloc Message-ID: <20211225122334.651e9acd@jelly.fritz.box> In-Reply-To: <202112240851.1BO8pdnH043305@gitrepo.freebsd.org> References: <202112240851.1BO8pdnH043305@gitrepo.freebsd.org> Organization: FreeBSD in der Heimstatt List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-UID: 2a0918 X-Rspamd-UID: fc2109 X-Rspamd-Queue-Id: 4JLhQL6tx6z4gTX X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=walstatt-de.de header.s=DKIM001 header.b=p9TBgHRg; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@walstatt-de.de has no SPF policy when checking 2001:1640:5::8:31) smtp.mailfrom=freebsd@walstatt-de.de X-Spamd-Result: default: False [-2.31 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[walstatt-de.de:s=DKIM001]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[walstatt-de.de]; NEURAL_HAM_LONG(-0.67)[-0.671]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[walstatt-de.de:+]; NEURAL_HAM_SHORT(-0.34)[-0.341]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25394, ipnet:2001:1640::/32, country:DE]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Am Fri, 24 Dec 2021 08:51:39 GMT schrieb Doug Moore : > The branch main has been updated by dougm: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=184c63db3c949d8ba766dc7b2bd2f082404e169d > > commit 184c63db3c949d8ba766dc7b2bd2f082404e169d > Author: Doug Moore > AuthorDate: 2021-12-24 08:47:21 +0000 > Commit: Doug Moore > CommitDate: 2021-12-24 08:47:21 +0000 > > Fix clerical error in page alloc > > Fix a very recent change that introduced a page accounting error > in case of a reserveration being broken. > Reviewed by: alc > Fixes: fb38b29b5609 (page_alloc_br) vm_page: Remove extra test, > dup code from page alloc Differential Revision: > https://reviews.freebsd.org/D33645 --- > sys/vm/vm_page.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c > index c24da96f4312..03351b0ad3dd 100644 > --- a/sys/vm/vm_page.c > +++ b/sys/vm/vm_page.c > @@ -2186,11 +2186,11 @@ vm_page_find_contig_domain(int domain, int > req, u_long npages, vm_paddr_t low, vm_page_t m_ret; > > vmd = VM_DOMAIN(domain); > - if (!vm_domain_allocate(vmd, req, npages)) > - return (NULL); > #if VM_NRESERVLEVEL > 0 > again: > #endif > + if (!vm_domain_allocate(vmd, req, npages)) > + return (NULL); > /* > * Try to allocate the pages from the free page queues. > */ > It seems that our hosts running with this patch are "dead" after a while while under load (poudriere): ssh on both IPv4 and IPv6 are dead as well as http/https on IPv4/IPv6 (remote site, no connection via ssh anymore, but hosts respond to ping, nmap show several other services on local network as reachable, but no ssh(22)/apache24(http/https). Other hosts at OS level before this patch seem to be allright so far (i.e. FreeBSD 14.0-CURRENT #39 main-n251899-fa255ab1b895: Thu Dec 23 13:48:41 CET 2021 amd64). I have to admit its a wild guess that this patch is the culprit, but it is strange that two out of four hosts with this patch applied are now both unreachable on both ssh and http (lates www/apache24) while two other hosts stuck with the version showed above seem to operate on ssh/http. Can investigate earliest after 26th of December. Kind regards, oh