From nobody Wed Dec 22 21:11:15 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 72F4118F590D; Wed, 22 Dec 2021 21:11:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JK5bT1Zmlz4lCD; Wed, 22 Dec 2021 21:11:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id B235C41E8; Wed, 22 Dec 2021 21:11:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3fe0ad90-954d-0e8a-abb4-386382e0de5e@FreeBSD.org> Date: Wed, 22 Dec 2021 13:11:15 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: git: 6378393308bc - main - Add an internal libiscsiutil library. Content-Language: en-US From: John Baldwin To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202112221843.1BMIhZs4089815@gitrepo.freebsd.org> In-Reply-To: <202112221843.1BMIhZs4089815@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640207477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Kg9bF8Pjy7j8uPjjSpz+YIdJx3BbwUzKt8vsFoJ96s=; b=dtF032wvH+pHlIJ+vJ9PrVGJof8IRLMiebKLdslG9ejVnjvQy6iJJUPfpal+X1huMDoK/Q qj8uUa+OaMH14J+UUZ8wsH4AklBdwDel7Ub3FRqSRdElxmAeh5p2zOuhm/eDYf8P47L1Nf Eiee0psBGC8AMNAikkeXb40YpEfU2jD7SBnEImKl+7FmDMS7fFZ9taHAv50PrfAmOMaZBi YXIIe8rePsiK1NaPXi25c4EjfsK3dbmFGL11aoOvs2jlNDw8XV6T+tSlOHV6not0B5b92h SDtY9v7KoGIkY/16jSiNQIkHcXG+OkYmidEBq2tfDz5YIxTarA25OifGYb1m5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640207477; a=rsa-sha256; cv=none; b=vjKajjXxEv/+B9gxrzN+hp8lDklAO0LuarrkH1ETG08++Qe1BfDG7AomFZLbB4pqaevZtt 2NBiZXOYQ9z56ZRA9FXerG/PSmxFc2UcYOVMBDnK03ov/1q7jFwUYA09Lbydu3ViTrAQ74 VAJDlh0BoxiFeDhqDJtRIdFAy4XRTFcPNrlbilSNRS4Ncee3X45OSa8GO12/OXwCWZAJWB P7E770hLjXLEy7bRtyAh3t4bN6XmsBuE0rExoaGeTS1BKmGcyK9MUEY1pIHjO9bhPQo/ts v7vYyZp772Mlm/pB2zrHoes+CBiwZxh62RXLj+23MjcR2A/WW4gR48v0iod+TQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 12/22/21 10:43 AM, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=6378393308bc6bd81fb871dacf6b03cf1a390d8b > > commit 6378393308bc6bd81fb871dacf6b03cf1a390d8b > Author: John Baldwin > AuthorDate: 2021-12-22 18:35:46 +0000 > Commit: John Baldwin > CommitDate: 2021-12-22 18:43:11 +0000 > > Add an internal libiscsiutil library. > > Move some of the code duplicated between ctld(8) and iscsid(8) into a > libiscsiutil library. > > Sharing the low-level PDU code did require having a > 'struct connection' base class with a method table to permit separate > initiator vs target behavior (e.g. in handling proxy PDUs). > > Reviewed by: mav, emaste > Sponsored by: Chelsio Communications > Differential Revision: https://reviews.freebsd.org/D33544 I know this has broken the build on some 32-bit platforms due to a -Wno-cast-align warning. I'm waiting on a local buildworld to reproduce so I can work on testing fixes (which will probably just be quieting the warning via NO_WCAST_ALIGN=yes). In this case the warning is a false positive as the structure (ctld_connection) with the stronger alignment is the one that is allocated and upcasted to the base type internally and then downcasted again with the warning on the downcast back to the original type. -- John Baldwin