From nobody Wed Dec 22 13:44:48 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1CA8A18E45CB; Wed, 22 Dec 2021 13:44:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JJvhJ60BYz4WkT; Wed, 22 Dec 2021 13:44:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AE1B91E29C; Wed, 22 Dec 2021 13:44:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BMDimIE087682; Wed, 22 Dec 2021 13:44:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BMDimdR087681; Wed, 22 Dec 2021 13:44:48 GMT (envelope-from git) Date: Wed, 22 Dec 2021 13:44:48 GMT Message-Id: <202112221344.1BMDimdR087681@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Vincenzo Maffione Subject: git: d10ea34d1128 - stable/12 - e1000: remove unused ifp backpointer List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vmaffione X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: d10ea34d1128571f99df29cc77bf5849d1661dd9 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640180688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tYszotxWyRLCtdhf0NqNjiEr9vTQlnPY/uwbS4QCAis=; b=G0wTPHvMXBwELmDFA4e1yw9osMYXNgFE2utbsfgwIuwjHvm3f6HGUwbwSeR1a6LfuilKSW oXfHgr+5AEshztHZPCLwrJni7TItZgYVWW2MR43CUw3Z9GEFqOpE5oBZO+//rWhBiopI/p IhHMmQ/WeVmTJI2xC3ZL6z9Mxw3bLRDJjazwidDCevCTKomx6y5So04U03vkzw5MVQzBcl jhVVt0oqT9t88NT9pig+v/QD2EG0eTUajKMktqpkuL1I1y8W7Kod97NbbSBaA8ew9xPwze GrOU7NC9LKi7RhiUpVMnGiZitrITV3etJTloooJlU50hA26iwr5EnawZRX7G4g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640180688; a=rsa-sha256; cv=none; b=RKxUf5G5DDugiXmX1nOkfIGKH8wJJmsA28hZBvU+gZTjS6BGC381/DWB71Xu1jmOhz+MXo jKIqiipEKNwvS8HTAAQG7wPzoyV0mvWEpVb36IhI4OJGND6uWWYHnXf7yur9RnDvmjaLmj FEhql5ePeCBJRWfsAQH3sP7OBlzIQB3bY7nOZtfufXYiGCiKJGDcCQFKYkgTlMJG6F3enn 3CFGMsluQD8CpQ5sadKPmJNZbdNlZW8XHmSjdK6w8642UECM1dBqc8F8aMnStIlIVF3Bzg h6+He6m82I+O0FqELZuZ3+m7Ks+xZncGx65aLNNit43VjQRp4TEnjYSHonW04g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by vmaffione: URL: https://cgit.FreeBSD.org/src/commit/?id=d10ea34d1128571f99df29cc77bf5849d1661dd9 commit d10ea34d1128571f99df29cc77bf5849d1661dd9 Author: Vincenzo Maffione AuthorDate: 2021-11-29 21:28:26 +0000 Commit: Vincenzo Maffione CommitDate: 2021-12-22 13:44:39 +0000 e1000: remove unused ifp backpointer The ifp (struct ifnet) backpointer in the e1000 private ifnet data is not used anymore since the iflib transition. Remove it so that developers are not tempted to use it and get a NULL pointer dereference. Reviewed by: markj, kbowling, erj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D33157 (cherry picked from commit d91559564dc647846479824340bdf94b7cf98c05) --- sys/dev/e1000/if_em.h | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h index 9b34075ff2d9..4b087d3c2c05 100644 --- a/sys/dev/e1000/if_em.h +++ b/sys/dev/e1000/if_em.h @@ -441,7 +441,6 @@ struct em_rx_queue { /* Our softc structure */ struct e1000_softc { - struct ifnet *ifp; struct e1000_hw hw; if_softc_ctx_t shared;