From nobody Mon Dec 20 16:29:07 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9090118EFADF for ; Mon, 20 Dec 2021 16:29:20 +0000 (UTC) (envelope-from mw@semihalf.com) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JHlR41Nx7z3rM6 for ; Mon, 20 Dec 2021 16:29:20 +0000 (UTC) (envelope-from mw@semihalf.com) Received: by mail-lf1-x12c.google.com with SMTP id bu9so1407568lfb.7 for ; Mon, 20 Dec 2021 08:29:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=q7gzwBHpBvSH2QW4djTR+Vjd++ALymTCEpYHXNfW5ao=; b=uUgCq/YDh6bR5oFkx7zyxvcSFKe2M9DIZYCpbtaqYJg4m+stpXCqO9xi4NvEWfPO6u D/JHwq1W+GvvE5oVwop2NtBEmO7VKNyJJYKvHn9q9QmoAnJNHddRZRo+RNf/RnfjWGJY GKqdzC1NAX0oxDqIZSdnGnRuvRMGJsqktsqwyd/WCqHvstaiivqqAiq/EWg2sDPVC+Kb dsrTZX7vDnY7G+NMbOwMCIuHfPSDD3tlumYgvj4VxbDtRd0OW1qbkSOUnHV5n5//jR3I G0Z/RUc5MHFIo6/nf18AoFWIO1zWCPww0Q/uHvdqjA5QmX6dRhxD1ZzYIRwQ6Yzp64+t l8qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q7gzwBHpBvSH2QW4djTR+Vjd++ALymTCEpYHXNfW5ao=; b=8E36w4RkONejEu3CoPIwTp3tx+OQnxo1o7zFyx4kFFUNQiMXX/RLUJWcr05xb2k+li Q7NWjzVtixY/6UA3sTkQbaWcPcsoeuUpH9n/ZeTb3S0+fxM1cEj6w/Sfp6IQrG/jPOQg 9qtVoca7fuxdnQ0dG4cWOIfGYLo6bB+l6nFJ7a4xx3stNlaWG2gWNkrVYSDsXPozylgI nsM1+9qjaj0wWV31Z/uymsLKfMC2pjWJOBB65RRlrvZvSQ8fndGq0PuU0lXfNoIrUr3a DaScet8+fESVinilvKd60Q/MVV3Kmtv+hsiFhm00XfzG1ar1sI0tFq2OT97aL2VZKPRs Mq2g== X-Gm-Message-State: AOAM5303VR4Qe3cxErApW9WAjUqg/o880hRKGIOLRNzOOOxIrvjmSgyo 8F5Mq65csOTexFdDXW1ncWTTfzl/UTdLGEKD+vuysA== X-Google-Smtp-Source: ABdhPJxohwRIK8IQukKc7SBSTc0ZER+CEDWNnopwgoV9Pk/Ikl8+n7ydvfLTzi4/yk/repyl7U7IclY3zoU5kAcfoxY= X-Received: by 2002:a05:6512:c24:: with SMTP id z36mr10589129lfu.671.1640017758664; Mon, 20 Dec 2021 08:29:18 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202112200529.1BK5T0np047358@gitrepo.freebsd.org> In-Reply-To: From: Marcin Wojtas Date: Mon, 20 Dec 2021 17:29:07 +0100 Message-ID: Subject: Re: git: 4f741801d860 - main - t_setrlimit: Adjust resource limit to 20M To: Mark Johnston Cc: Kyle Evans , Wojciech Macek , Marcin Wojtas , Wojciech Macek , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4JHlR41Nx7z3rM6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Hi, pon., 20 gru 2021 o 15:21 Mark Johnston napisa=C5=82(a)= : > > On Mon, Dec 20, 2021 at 01:54:22AM -0600, Kyle Evans wrote: > > I found the PR that I was thinking of, that you folks might want to > > join if you haven't already: https://bugs.freebsd.org/260303 > > I've posted an update there. I'm in the middle of a move this week and > will be a slower than usual to follow up, but would be happy to have > some further discussion of the solution. > We're open to discuss. > > I don't think a revert's necessary, just something to consider if this > > ends up becoming a non-issue due to other low-level changes. > > I'd argue for a revert: the original test is valid and was changed only > to cope with an incompatibility between the RLIMIT_STACK and stack gap > implementations. The WIP I wrote to deal with that does not require > such a change to the test. At the moment, the test passes anyway since > the stack gap was disabled by default. > I'll issue a revert patch then. Best regards, Marcin > > Thanks, > > > > Kyle Evans > > > > On Mon, Dec 20, 2021 at 1:32 AM Wojciech Macek wrote= : > > > > > > Hi Kyle, > > > > > > Thanks for the comment, I thought this one is discussed but apparentl= y I was mistaken. > > > Adding Marcin to handle this on our side. I'm fine with reverting it = anyway or do whatever you decide. > > > > > > Regards, > > > Wojtek > > > > > > pon., 20 gru 2021 o 07:51 Kyle Evans napisa=C5= =82(a): > > >> > > >> On Sun, Dec 19, 2021 at 11:29 PM Wojciech Macek wr= ote: > > >> > > > >> > The branch main has been updated by wma: > > >> > > > >> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D4f741801d86089a1c5d= 631ba1e0f1421cdcf7a7e > > >> > > > >> > commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > > >> > Author: Dawid Gorecki > > >> > AuthorDate: 2021-12-20 05:27:12 +0000 > > >> > Commit: Wojciech Macek > > >> > CommitDate: 2021-12-20 05:28:20 +0000 > > >> > > > >> > t_setrlimit: Adjust resource limit to 20M > > >> > > > >> > With ASLR enabled by default, RLIMIT_STACK test fails due to t= he fact > > >> > that default stack gap can be as big as 15M. Because of that t= he > > >> > resource limit of 4M results in test program receiving SIGSEGV > > >> > immediately after exiting the setrlimit syscall. Since the ide= a of this > > >> > test is to check if rlim_cur does not extend past rlim_max, ad= justing > > >> > the resource limit to 20M should not invalidate the test resul= ts. > > >> > > > >> > > >> I can't seem to find the PR at the moment, but isn't this exactly th= e > > >> kind of thing markj@ talked about trying to avoid elsewhere? It seem= s > > >> like this probably should've been involved in the discussion rather > > >> than hacked around independently. > > >> > > >> Thanks, > > >> > > >> Kyle Evans